Improved travis tests efficiency

Author: Geolim4

.travis.yml

@@ -12,6 +12,7 @@
 language: php
 services:
   - memcached
+  # - redis-server
 before_script: phpenv config-add var/php/conf/phpfastcache.ini
 php:
   # - 5.3
@@ -27,3 +28,4 @@ script:
   - php -f tests/SyntaxChecker.test.php
   - php -f tests/Autoload.test.php
   - php -f tests/NewCacheInstance.test.php
+  - php -f tests/Psr6InterfaceImplements.test.php

src/phpFastCache/CacheManager.php

@@ -78,18 +78,21 @@ class CacheManager
      */
     public static function getInstance($driver = 'auto', $config = [])
     {
+        static $badPracticeOmeter = [];
+
         $driver = ucfirst(strtolower($driver));
         $config = array_merge(self::$config, $config);
-        if ($driver === 'Auto') {
+        if (!$driver || $driver === 'Auto') {
             $driver = self::getAutoClass($config);
         }
 
         $instance = crc32($driver . serialize($config));
         if (!isset(self::$instances[ $instance ])) {
+            $badPracticeOmeter[$driver] = 1;
             $class = self::getNamespacePath() . $driver . '\Driver';
             self::$instances[ $instance ] = new $class($config);
-        } else {
-           trigger_error('[' . $driver . '] Calling CacheManager::getInstance for already instanced drivers is a bad practice and have a significant impact on performances.
+        } else if(++$badPracticeOmeter[$driver] >= 5){
+           trigger_error('[' . $driver . '] Calling many times CacheManager::getInstance() for already instanced drivers is a bad practice and have a significant impact on performances.
            See https://github.com/PHPSocialNetwork/phpfastcache/wiki/[V5]-Why-calling-getInstance%28%29-each-time-is-a-bad-practice-%3F');
         }
 
@@ -99,9 +102,9 @@ public static function getInstance($driver = 'auto', $config = [])
     /**
      * @param $config
      * @return string
-     * @throws \Exception
+     * @throws phpFastCacheDriverCheckException
      */
-    public static function getAutoClass($config)
+    public static function getAutoClass($config = [])
     {
         static $autoDriver;
 

src/phpFastCache/Drivers/Sqlite/Driver.php

@@ -97,7 +97,7 @@ public function getSqliteDir()
      */
     public function driverCheck()
     {
-        return extension_loaded('pdo_sqlite') || @mkdir($this->getFilesDir(), $this->setChmodAuto(), true);
+        return extension_loaded('pdo_sqlite') && @mkdir($this->getSqliteDir(), $this->setChmodAuto(), true);
     }
 
     /**

src/phpFastCache/Drivers/Ssdb/Driver.php

@@ -160,7 +160,7 @@ protected function driverConnect()
                 return true;
             }
         }catch(SSDBException $e){
-            throw new phpFastCacheDriverException('Ssdb failed to connect with error: '. $e->getMessage(), 0 , $e);
+            throw new phpFastCacheDriverCheckException('Ssdb failed to connect with error: '. $e->getMessage(), 0 , $e);
         }
     }
 

tests/Autoload.test.php

@@ -14,7 +14,7 @@
 
 if (!class_exists('phpFastCache\CacheManager')) {
     echo "[FAIL] Autoload failed to find the CacheManager\n";
-    $status = 1;
+    $status = 255;
 }
 echo "[PASS] Autoload successfully found the CacheManager\n";
 

tests/Psr6InterfaceImplements.test.php

@@ -0,0 +1,33 @@
+<?php
+
+/**
+ * @author Khoa Bui (khoaofgod)  <[email protected]> http://www.phpfastcache.com
+ * @author Georges.L (Geolim4)  <[email protected]>
+ */
+
+use phpFastCache\CacheManager;
+use Psr\Cache\CacheItemPoolInterface;
+
+
+chdir(__DIR__);
+require_once __DIR__ . '/../vendor/autoload.php';
+
+$status = 0;
+echo "Testing new cache instance\n";
+
+/**
+ * Testing memcached as it is declared in .travis.yml
+ */
+$driverInstance = CacheManager::getInstance();
+
+if (!is_object($driverInstance)) {
+    echo '[FAIL] CacheManager::getInstance() returned an invalid variable type:' . gettype($driverInstance) . "\n";
+    $status = 1;
+}else if(!($driverInstance instanceof CacheItemPoolInterface)){
+    echo '[FAIL] CacheManager::getInstance() returned an invalid class:' . get_class($driverInstance) . "\n";
+    $status = 1;
+}else{
+    echo '[PASS] CacheManager::getInstance() returned a valid CacheItemPoolInterface object: ' . get_class($driverInstance) . "\n";
+}
+
+exit($status);

tests/SyntaxChecker.test.php

@@ -29,8 +29,8 @@ function read_dir($dir, $ext = null)
     return $list;
 }
 
-$list = read_dir('.', 'php');
-$list += read_dir('.', 'tpl');
+$list = read_dir(__DIR__ . '/../', 'php');
+$list += read_dir(__DIR__ . '/../', 'tpl');
 
 $exit = 0;
 foreach ($list as $file) {