switch to "copy into place" for file writing

make file writing return a failure state if any portion of writing fails

add checks to remove "Warning:" messages from phpfastcache for uninitialized array access.

Author: arcfieldOSS

phpfastcache/3.0.0/drivers/files.php

@@ -87,6 +87,7 @@ function driver_set($keyword, $value = "", $time = 300, $option = array() ) {
             }
         }
 
+        $written = true;
         /*
          * write to intent file to prevent race during read; race during write is ok
          * because first-to-lock wins and the file will exist before the writer attempts
@@ -95,20 +96,24 @@ function driver_set($keyword, $value = "", $time = 300, $option = array() ) {
         if($toWrite == true && !@file_exists($tmp_path && !@file_exists($file_path))) {
                 try {
                     $f = @fopen($tmp_path, "c");
+                    if ($f) {
                     if (flock($f,LOCK_EX| LOCK_NB))  {
-                    fwrite($f, $data);
-                        fflush($f);
-                        flock($f,LOCK_UN);
+                            $written = ($written && fwrite($f, $data));
+                            $written = ($written && fflush($f));
+                            $written = ($written && flock($f, LOCK_UN));
                     } else {
                         //arguably the file is being written to so the job is done
+                            $written = false;
+                    }
+                        $written = ($written && @fclose($f));
+                        $written = ($written && @rename($tmp_path,$file_path));
                     }
-                    fclose($f);
-                    @rename($tmp_path,$file_path);
                 } catch (Exception $e) {
                     // miss cache
-                    return false;
+                    $written = false;
                 }
         }
+        return $written;
     }
 
     function driver_get($keyword, $option = array()) {

phpfastcache/3.0.0/phpfastcache.php

@@ -159,7 +159,7 @@ public static function getPath($skip_create_path = false, $config) {
             $path = $config['path'];
         }
 
-        $securityKey = $config['securityKey'];
+        $securityKey = array_key_exists('securityKey',$config) ? $config['securityKey'] : "";
         if($securityKey == "" || $securityKey == "auto") {
             $securityKey = self::$config['securityKey'];
             if($securityKey == "auto" || $securityKey == "") {
@@ -193,7 +193,7 @@ public static function getPath($skip_create_path = false, $config) {
 
 
             self::$tmp[$full_pathx] = true;
-            self::htaccessGen($full_path, $config['htaccess']);
+            self::htaccessGen($full_path, array_key_exists('htaccess',$config) ? $config['htaccess'] : false);
         }
 
         return realpath($full_path);