Skip to content

Commit 0ef9d0e

Browse files
author
skiera
committed
Eclipse Indigo support
Updated required plug-ins
1 parent b015c38 commit 0ef9d0e

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

META-INF/MANIFEST.MF

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: PHP Tool Codesniffer
44
Bundle-SymbolicName: org.phpsrc.eclipse.pti.tools.codesniffer;singleton:=true
5-
Bundle-Version: 1.3.0.I20110319000000
5+
Bundle-Version: 1.3.0.R20110619000000
66
Bundle-Activator: org.phpsrc.eclipse.pti.tools.codesniffer.PHPCodeSnifferPlugin
77
Bundle-Vendor: Sven Kiera
88
Require-Bundle: org.eclipse.ui,
99
org.eclipse.core.runtime,
10-
org.phpsrc.eclipse.pti.core;bundle-version="1.3.0",
10+
org.phpsrc.eclipse.pti.core;bundle-version="1.6.0",
1111
org.phpsrc.eclipse.pti.library.pear;bundle-version="1.2.0",
12-
org.eclipse.php.ui;bundle-version="2.1.0",
13-
org.eclipse.php.debug.core;bundle-version="2.1.0",
14-
org.eclipse.php.debug.ui;bundle-version="2.1.0",
12+
org.eclipse.php.ui;bundle-version="3.0.0",
13+
org.eclipse.php.debug.core;bundle-version="3.0.0",
14+
org.eclipse.php.debug.ui;bundle-version="3.0.0",
1515
org.eclipse.core.resources;bundle-version="3.4.1",
1616
org.eclipse.dltk.core,
1717
org.eclipse.wst.validation,

src/org/phpsrc/eclipse/pti/tools/codesniffer/core/PHPCodeSniffer.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@
2020
import org.eclipse.core.runtime.IPath;
2121
import org.eclipse.core.runtime.Path;
2222
import org.eclipse.core.runtime.QualifiedName;
23+
import org.eclipse.dltk.compiler.problem.DefaultProblemIdentifier;
2324
import org.eclipse.dltk.compiler.problem.IProblem;
2425
import org.eclipse.dltk.compiler.problem.ProblemSeverities;
26+
import org.eclipse.dltk.compiler.problem.ProblemSeverity;
2527
import org.phpsrc.eclipse.pti.core.launching.OperatingSystem;
2628
import org.phpsrc.eclipse.pti.core.launching.PHPToolLauncher;
2729
import org.phpsrc.eclipse.pti.core.php.inifile.INIFileEntry;
@@ -146,9 +148,9 @@ protected IProblem[] parseOutput(ISourceFile file, String output, PHPCodeSniffer
146148

147149
Document doc = parser.getDocument();
148150
problems.addAll(createProblemMarker(file, doc.getElementsByTagName("error"),
149-
ProblemSeverities.Error, tabWidth, prefs.getIgnoreSniffs()));
151+
ProblemSeverity.ERROR, tabWidth, prefs.getIgnoreSniffs()));
150152
problems.addAll(createProblemMarker(file, doc.getElementsByTagName("warning"),
151-
ProblemSeverities.Warning, tabWidth, prefs.getIgnoreSniffs()));
153+
ProblemSeverity.WARNING, tabWidth, prefs.getIgnoreSniffs()));
152154
}
153155
}
154156
} catch (Exception e) {
@@ -158,7 +160,7 @@ protected IProblem[] parseOutput(ISourceFile file, String output, PHPCodeSniffer
158160
return problems.toArray(new IProblem[0]);
159161
}
160162

161-
protected ArrayList<IProblem> createProblemMarker(ISourceFile file, NodeList list, int type, int tabWidth,
163+
protected ArrayList<IProblem> createProblemMarker(ISourceFile file, NodeList list, ProblemSeverity type, int tabWidth,
162164
String[] ignoreSniffs) {
163165
if (tabWidth <= 0)
164166
tabWidth = 2;
@@ -192,8 +194,10 @@ protected ArrayList<IProblem> createProblemMarker(ISourceFile file, NodeList lis
192194
if (column > 1)
193195
lineStart += (column - 1 - (file.lineStartTabCount(lineNr) * (tabWidth - 1)));
194196

197+
System.out.println(IProblem.Syntax);
198+
System.out.println(DefaultProblemIdentifier.decode(IProblem.Syntax));
195199
problems.add(new CodeSnifferProblem(file.getFile().getFullPath().toOSString(), item.getTextContent(),
196-
IProblem.Syntax, new String[0], type, lineStart, file.lineEnd(lineNr), lineNr, column, source));
200+
DefaultProblemIdentifier.decode(IProblem.Syntax), new String[0], type, lineStart, file.lineEnd(lineNr), lineNr, column, source));
197201
}
198202

199203
return problems;

src/org/phpsrc/eclipse/pti/tools/codesniffer/core/problem/CodeSnifferProblem.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,15 @@
99
package org.phpsrc.eclipse.pti.tools.codesniffer.core.problem;
1010

1111
import org.eclipse.dltk.compiler.problem.DefaultProblem;
12+
import org.eclipse.dltk.compiler.problem.IProblemIdentifier;
13+
import org.eclipse.dltk.compiler.problem.ProblemSeverity;
1214

1315
public class CodeSnifferProblem extends DefaultProblem {
1416

1517
protected String source;
1618

17-
public CodeSnifferProblem(String originatingFileName, String message, int id, String[] stringArguments,
18-
int severity, int startPosition, int endPosition, int line, int column, String source) {
19+
public CodeSnifferProblem(String originatingFileName, String message, IProblemIdentifier id, String[] stringArguments,
20+
ProblemSeverity severity, int startPosition, int endPosition, int line, int column, String source) {
1921
super(originatingFileName, message, id, stringArguments, severity, startPosition, endPosition, line, column);
2022
this.source = source;
2123
}

0 commit comments

Comments
 (0)