Fix warning for view referencing same table twice

Author: simolus3

drift_dev/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.25.3-dev
+
+- Fix warning on Dart-defined views referencing the same table multiple times.
+
 ## 2.25.2
 
 - Fix `generateInsertable: true` on `@UseRowClass` not respecting inherited

drift_dev/lib/src/analysis/driver/driver.dart

@@ -56,7 +56,7 @@ class DriftAnalysisDriver {
   final DriftBackend backend;
   final DriftAnalysisCache cache = DriftAnalysisCache();
   final DriftOptions options;
-  final bool _isTesting;
+  final bool isTesting;
 
   Future<KnownDriftTypes?>? _loadingTypes;
 
@@ -65,8 +65,8 @@ class DriftAnalysisDriver {
   DriftAnalysisDriver(
     this.backend,
     this.options, {
-    bool isTesting = false,
-  }) : _isTesting = isTesting;
+    this.isTesting = false,
+  });
 
   SqlEngine newSqlEngine() {
     return SqlEngine(
@@ -272,7 +272,7 @@ class DriftAnalysisDriver {
         if (e is! CouldNotResolveElementException) {
           backend.log.warning('Could not analyze $id', e, s);
 
-          if (_isTesting) rethrow;
+          if (isTesting) rethrow;
         }
 
         return null;

drift_dev/lib/src/analysis/resolver/resolver.dart

@@ -49,6 +49,9 @@ class DriftResolver {
       }
     } on CouldNotDeserializeException catch (e, s) {
       driver.backend.log.warning('Could not deserialize $element', e, s);
+      if (driver.isTesting) {
+        rethrow;
+      }
     }
 
     // We can't resolve the element from cache, so we need to resolve it.

drift_dev/lib/src/analysis/serializer.dart

@@ -667,7 +667,7 @@ class ElementDeserializer {
         } else if (sourceKind == 'dart') {
           TableReferenceInDartView readReference(Map json) {
             final id = DriftElementId.fromJson(json['table'] as Map);
-            final reference = references.singleWhere((e) => e.id == id);
+            final reference = references.firstWhere((e) => e.id == id);
             return TableReferenceInDartView(
                 reference as DriftTable, json['name'] as String);
           }

drift_dev/test/analysis/resolver/dart/view_test.dart

@@ -188,4 +188,32 @@ abstract class CommonNames extends View {
 '''))
     }, result.dartOutputs, result.writer);
   });
+
+  test('can use views referencing same table multiple times', () async {
+    await emulateDriftBuild(
+      inputs: {
+        'a|lib/a.dart': '''
+import 'package:drift/drift.dart';
+
+class Users extends Table {
+  IntColumn get id => integer().autoIncrement()();
+  TextColumn get name => text()();
+}
+
+class UsersView extends View {
+  Users get a;
+  Users get b;
+
+  @override
+  Query as() => select([a.id, b.name])
+      .from(a)
+      .join([
+        innerJoin(b, b.name.equalsExp(a.id))
+      ]);
+}
+''',
+      },
+      logger: loggerThat(neverEmits(anything)),
+    );
+  });
 }