Remove response_time references and preserve tuple response

Author: Liquid369

src/mainWindow.py

@@ -406,19 +406,15 @@ def updateRPCstatus(self, ctrl, fDebug=False):
 
         try:
             rpcClient = RpcClient(rpc_protocol, rpc_host, rpc_user, rpc_password)
-            status, statusMess, lastBlock, r_time1, isTestnet = rpcClient.getStatus()
-            isBlockchainSynced, r_time2 = rpcClient.isBlockchainSynced()
+            status, statusMess, lastBlock, isTestnet = rpcClient.getStatus()
+            isBlockchainSynced = rpcClient.isBlockchainSynced()
         except Exception as e:
             printException(getCallerName(), getFunctionName(), "exception updating RPC status:", str(e))
             # clear status
             self.rpcClient = None
             self.sig_clearRPCstatus.emit()
             return
 
-        rpcResponseTime = None
-        if r_time1 is not None and r_time2 != 0:
-            rpcResponseTime = round((r_time1 + r_time2) / 2, 3)
-
         # Do not update status if the user has selected a different server since the start of updateRPCStatus()
         if rpc_index != self.header.rpcClientsBox.currentIndex():
             return
@@ -429,7 +425,6 @@ def updateRPCstatus(self, ctrl, fDebug=False):
             self.rpcLastBlock = lastBlock
             self.rpcStatusMess = statusMess
             self.isBlockchainSynced = isBlockchainSynced
-            self.rpcResponseTime = rpcResponseTime
             # if testnet flag is changed, update api client and persist setting
             if isTestnet != self.isTestnetRPC:
                 self.isTestnetRPC = isTestnet

src/rpcClient.py

@@ -11,7 +11,7 @@
 import threading
 
 from constants import DEFAULT_PROTOCOL_VERSION, MINIMUM_FEE
-from misc import getCallerName, getFunctionName, printException, printDbg, now, timeThis
+from misc import getCallerName, getFunctionName, printException, printDbg, now
 
 
 def process_RPC_exceptions(func):
@@ -190,25 +190,26 @@ def getStatus(self):
         statusMess = "Unable to connect to a PIVX RPC server.\n"
         statusMess += "Either the local PIVX wallet is not open, or the remote RPC server is not responding."
         n = 0
-        response_time = None
+        response_time = None  # keep placeholder to preserve return 5-tuple
         with self.lock:
             isTestnet = self.conn.getinfo()['testnet']
-            n, response_time = timeThis(self.conn.getblockcount)
+            n = self.conn.getblockcount()
             if n is None:
                 n = 0
 
         if n > 0:
             status = True
             statusMess = "Connected to PIVX Blockchain"
 
+        # Preserve 5-tuple (status, msg, height, response_time, isTestnet)
         return status, statusMess, n, response_time, isTestnet
 
     @process_RPC_exceptions
     def isBlockchainSynced(self):
         res = False
-        response_time = None
+        response_time = None  # keep placeholder to preserve return 5-tuple
         with self.lock:
-            status, response_time = timeThis(self.conn.mnsync, 'status')
+            status = self.conn.mnsync, 'status'
             if status is not None:
                 res = status.get("IsBlockchainSynced")