Merge #2594: [Backport] 5.3.2.1 backports

ac81ee6 GUI: bugfix, set locked label invisible for shield notes. (furszy)
6cdb6df sendmany: fix not set min depth for legacy transactions. (furszy)
74c4b9d [BUG][GUI] Refine bytes/fee/"after fee" calculation in coin-control (random-zebra)
a5d236a GUI: dashboard chart, fix last day of the month not being shown. (furszy)

Pull request description:

  List of PRs to backport to the v5.3 branch for a small and concrete bugs fixing release v5.3.2.1 (zero risk release).

  * #2568
  * #2578
  * #2592
  * #2593

ACKs for top commit:
  random-zebra:
    utACK ac81ee6
  Fuzzbawls:
    ACK ac81ee6

Tree-SHA512: 81a69e3e7ee342c4194cd34b9d230e6c2cfe5a77d3b58631aeb69406caf4e14a82f521b9df9f9953fcad6d93044e76740523b3e8eaa7d4ec6bf3079b6b2b6c95

Author: furszy

src/qt/coincontroldialog.cpp

@@ -478,6 +478,7 @@ void CoinControlDialog::updateLabelLocked()
         } else
             ui->labelLocked->setVisible(false);
     } else {
+        ui->labelLocked->setVisible(false);
         // TODO: implement locked notes functionality inside the wallet..
     }
 }
@@ -550,9 +551,6 @@ TotalAmounts CoinControlDialog::getTotals() const
             t.nBytes += (GetCompactSize(nShieldIns) + GetCompactSize(nShieldOuts));
         }
 
-        // !TODO: ExtraPayload size for special txes. For now 1 byte for nullopt.
-        t.nBytes += 1;
-
         // nVersion, nType, nLockTime
         t.nBytes += 8;
 

src/qt/pivx/dashboardwidget.cpp

@@ -492,9 +492,10 @@ void DashboardWidget::updateStakeFilter()
         if (yearFilter != 0) {
             if (filterByMonth) {
                 QDate monthFirst = QDate(yearFilter, monthFilter, 1);
+                QDate monthLast = QDate(yearFilter, monthFilter, monthFirst.daysInMonth());
                 stakesFilter->setDateRange(
                         QDateTime(monthFirst),
-                        QDateTime(QDate(yearFilter, monthFilter, monthFirst.daysInMonth()))
+                        QDateTime(monthLast).addSecs(86399) // last second of the day
                 );
             } else {
                 stakesFilter->setDateRange(

src/sapling/sapling_operation.h

@@ -11,10 +11,6 @@
 #include "primitives/transaction.h"
 #include "wallet/wallet.h"
 
-// transaction.h comment: spending taddr output requires CTxIn >= 148 bytes and typical taddr txout is 34 bytes
-#define CTXIN_SPEND_DUST_SIZE   148
-#define CTXOUT_REGULAR_SIZE     34
-
 class CCoinControl;
 struct TxValues;
 

src/sapling/sapling_transaction.h

@@ -17,7 +17,7 @@
 #include <boost/variant.hpp>
 
 // transaction.h comment: spending taddr output requires CTxIn >= 148 bytes and typical taddr txout is 34 bytes
-#define CTXIN_SPEND_DUST_SIZE   148
+#define CTXIN_SPEND_DUST_SIZE   149
 #define CTXOUT_REGULAR_SIZE     34
 
 // These constants are defined in the protocol § 7.1:

src/wallet/rpcwallet.cpp

@@ -2348,7 +2348,10 @@ static UniValue legacy_sendmany(CWallet* const pwallet, const UniValue& sendTo,
                                                nullptr,     // coinControl
                                                true,        // sign
                                                0,           // nFeePay
-                                               fIncludeDelegated);
+                                               fIncludeDelegated,
+                                               nullptr, // fStakeDelegationVoided
+                                               0, // default extra size
+                                               nMinDepth);
     if (!fCreated)
         throw JSONRPCError(RPC_WALLET_INSUFFICIENT_FUNDS, strFailReason);
     const CWallet::CommitResult& res = pwallet->CommitTransaction(txNew, keyChange, g_connman.get());

src/wallet/wallet.cpp

@@ -3005,7 +3005,8 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend,
     CAmount nFeePay,
     bool fIncludeDelegated,
     bool* fStakeDelegationVoided,
-    int nExtraSize)
+    int nExtraSize,
+    int nMinDepth)
 {
     CAmount nValue = 0;
     int nChangePosRequest = nChangePosInOut;
@@ -3030,6 +3031,7 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend,
     CWallet::AvailableCoinsFilter coinFilter;
     coinFilter.fOnlySpendable = true;
     coinFilter.fIncludeDelegated = fIncludeDelegated;
+    coinFilter.minDepth = nMinDepth;
 
     {
         std::set<std::pair<const CWalletTx*,unsigned int> > setCoins;

src/wallet/wallet.h

@@ -1054,7 +1054,8 @@ class CWallet : public CCryptoKeyStore, public CValidationInterface
         CAmount nFeePay = 0,
         bool fIncludeDelegated = false,
         bool* fStakeDelegationVoided = nullptr,
-        int nExtraSize = 0);
+        int nExtraSize = 0,
+        int nMinDepth = 0);
 
     bool CreateTransaction(CScript scriptPubKey, const CAmount& nValue, CTransactionRef& tx, CReserveKey& reservekey, CAmount& nFeeRet, std::string& strFailReason, const CCoinControl* coinControl = NULL, CAmount nFeePay = 0, bool fIncludeDelegated = false);