-
Notifications
You must be signed in to change notification settings - Fork 78
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Description
Required prerequisites
- I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
- Consider asking first in a Discussion.
Motivation
I found many wrong type annotations in the codebase after a quick glance.
-def constrain_placement(self, placement: dict, keepout: float) -> tuple[float]:
+def constrain_placement(self, placement: list[float], keepout: float) -> tuple[float, float, float, float]:Also, mypy reports:
-Found 129 errors in 13 files (checked 82 source files)We should enable a CI workflow to check type annotations are correct.
Solution
Update type annotations and enable mypy in the CI workflow. And remove:
Alternatives
No response
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request