Skip to content

Commit acf24e6

Browse files
🐛 fix(joss_paper) update action, debug affiliations and add DOIs (#63)
--------- Co-authored-by: Fabien Casenave <fabien.casenave@safrangroup.com>
1 parent 6e66cd5 commit acf24e6

File tree

4 files changed

+23
-12
lines changed

4 files changed

+23
-12
lines changed

.github/workflows/draft-pdf.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,15 @@ jobs:
1313
- name: Checkout
1414
uses: actions/checkout@v4
1515
- name: Build joss draft PDF
16-
uses: openjournals/openjournals-draft-action@master
16+
id: generate-files
17+
uses: xuanxu/paper-action@main
1718
with:
19+
repository_url: http://github.com/PLAID-lib/plaid
20+
branch: action_paper
21+
issue_id: 8393
1822
journal: joss
19-
paper-path: docs/joss_paper/paper.md
2023
- name: Upload
2124
uses: actions/upload-artifact@v4
2225
with:
2326
name: paper
24-
path: docs/joss_paper/paper.pdf
27+
path: ${{ steps.generate-files.outputs.pdf_path}}

docs/joss_paper/paper.bib

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,17 @@ @article{casenave2025physics
22
title={Physics-Learning AI Datamodel (PLAID) datasets: a collection of physics simulations for machine learning},
33
author={Casenave, Fabien and Roynard, Xavier and Staber, Brian and Akkari, Nissrine and Piat, William and Bucci, Michele Alessandro and Kabalan, Abbas and Nguyen, Xuan Minh Vuong and Saverio, Luca and Perez, Rapha{\"e}l Carpintero and others},
44
journal={arXiv preprint arXiv:2505.02974},
5-
year={2025}
5+
year={2025},
6+
doi={https://doi.org/10.48550/arXiv.2505.02974}
67
}
78

89
@inproceedings{poinot2018seven,
910
title={Seven keys for practical understanding and use of CGNS},
1011
author={Poinot, Marc and Rumsey, Christopher L},
1112
booktitle={2018 AIAA Aerospace Sciences Meeting},
1213
pages={1503},
13-
year={2018}
14+
year={2018},
15+
doi={https://doi.org/10.2514/6.2018-1503}
1416
}
1517

1618
@article{casenave2024mmgp,
@@ -20,21 +22,24 @@ @article{casenave2024mmgp
2022
volume={36},
2123
year={2024}
2224
}
25+
2326
@article{kabalan2025elasticity,
2427
title={Elasticity-based morphing technique and application to reduced-order modeling},
2528
author={Kabalan, Abbas and Casenave, Fabien and Bordeu, Felipe and Ehrlacher, Virginie and Ern, Alexandre},
2629
journal={Applied Mathematical Modelling},
2730
volume={141},
2831
pages={115929},
2932
year={2025},
30-
publisher={Elsevier}
33+
publisher={Elsevier},
34+
doi={https://doi.org/10.1016/j.apm.2025.115929}
3135
}
3236

3337
@article{kabalan2025ommgp,
3438
title={{O-MMGP}: {O}ptimal {M}esh {M}orphing {G}aussian {P}rocess Regression for Solving {PDEs} with non-Parametric Geometric Variations},
3539
author={Kabalan, Abbas and Casenave, Fabien and Bordeu, Felipe and Ehrlacher, Virginie},
3640
journal={arXiv preprint arXiv:2502.11632},
37-
year={2025}
41+
year={2025},
42+
doi={https://doi.org/10.48550/arXiv.2502.11632},
3843
}
3944

4045
@inproceedings{perez2024gaussian,
@@ -50,5 +55,6 @@ @article{perez2024learning
5055
title={{Learning signals defined on graphs with optimal transport and Gaussian process regression}},
5156
author={Carpintero Perez, Rapha{\"e}l and Da Veiga, S{\'e}bastien and Garnier, Josselin and Staber, Brian},
5257
journal={arXiv preprint arXiv:2410.15721},
53-
year={2024}
58+
year={2024},
59+
doi={https://doi.org/10.48550/arXiv.2410.15721},
5460
}

docs/joss_paper/paper.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ date: "07 June 2025"
1010
authors:
1111
- name: Fabien Casenave
1212
orcid: 0000-0002-8810-9128
13-
affiliation: 1
13+
affiliation: "1"
1414
- name: Xavier Roynard
1515
orcid: 0000-0001-7840-2120
16-
affiliation: 1
16+
affiliation: "1"
1717
- name: Alexandre Devaux--Rivière
1818
orcid: 0009-0001-7474-944X
19-
affiliation: 1,2
19+
affiliation: "1, 2"
2020
affiliations:
2121
- name: SafranTech, Safran Tech, Digital Sciences & Technologies, 78114 Magny-Les-Hameaux, France
2222
index: 1

tests/containers/test_sample.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,9 @@ def test_get_zone_names(self, sample, base_name):
549549
base_name=base_name,
550550
)
551551
assert sample.get_zone_names(base_name) == ["zone_name_1", "zone_name_2"]
552-
assert sorted(sample.get_zone_names(base_name, unique = True)) == sorted(["zone_name_1", "zone_name_2"])
552+
assert sorted(sample.get_zone_names(base_name, unique=True)) == sorted(
553+
["zone_name_1", "zone_name_2"]
554+
)
553555
assert sample.get_zone_names(base_name, full_path=True) == [
554556
f"{base_name}/zone_name_1",
555557
f"{base_name}/zone_name_2",

0 commit comments

Comments
 (0)