Remove __VOID_POINTER type and move vtable module to lowering folder

The `__VOID_POINTER` type isn't really neccessary hence removed. Also the `vtable.rs` file was previously in the root direct but has now been moved to `lowering/vtable.rs`. With the former change some tests needed to be updated.

Author: volsa

compiler/plc_driver/src/pipelines.rs

@@ -24,15 +24,16 @@ use plc::{
     codegen::{CodegenContext, GeneratedModule},
     index::{indexer, FxIndexSet, Index},
     linker::LinkerType,
-    lowering::{calls::AggregateTypeLowerer, property::PropertyLowerer, InitVisitor},
+    lowering::{
+        calls::AggregateTypeLowerer, property::PropertyLowerer, vtable::VTableGenerator, InitVisitor,
+    },
     output::FormatOption,
     parser::parse_file,
     resolver::{
         const_evaluator::UnresolvableConstant, AnnotationMapImpl, AstAnnotations, Dependency, StringLiterals,
         TypeAnnotator,
     },
     validation::Validator,
-    vtable::VTableGenerator,
     ConfigFormat, ErrorFormat, OnlineChange, Target, Threads,
 };
 use plc_diagnostics::{

compiler/plc_driver/src/pipelines/participant.rs

@@ -13,8 +13,10 @@ use std::{
 
 use ast::provider::IdProvider;
 use plc::{
-    codegen::GeneratedModule, lowering::calls::AggregateTypeLowerer, output::FormatOption,
-    vtable::VTableGenerator, ConfigFormat, OnlineChange, Target,
+    codegen::GeneratedModule,
+    lowering::{calls::AggregateTypeLowerer, vtable::VTableGenerator},
+    output::FormatOption,
+    ConfigFormat, OnlineChange, Target,
 };
 use plc_diagnostics::diagnostics::Diagnostic;
 use plc_lowering::inheritance::InheritanceLowerer;

compiler/plc_driver/src/tests/.multi_files.rs.pending-snap

@@ -224,7 +224,7 @@ fn forward_declared_constant_is_also_marked_constant() {
     !11 = !DIFile(filename: "external_file2.st", directory: "")
     !12 = !{!13, !16}
     !13 = !DIDerivedType(tag: DW_TAG_member, name: "__vtable", scope: !11, file: !11, baseType: !14, size: 64, align: 64, flags: DIFlagPublic)
-    !14 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__VOID_POINTER", baseType: !15, size: 64, align: 64, dwarfAddressSpace: 1)
+    !14 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__foo___vtable", baseType: !15, size: 64, align: 64, dwarfAddressSpace: 1)
     !15 = !DIBasicType(name: "__VOID", encoding: DW_ATE_unsigned, flags: DIFlagPublic)
     !16 = !DIDerivedType(tag: DW_TAG_member, name: "something_to_initialize", scope: !11, file: !11, line: 14, baseType: !17, size: 16, align: 16, offset: 64, flags: DIFlagPublic)
     !17 = !DIBasicType(name: "INT", size: 16, encoding: DW_ATE_signed, flags: DIFlagPublic)
@@ -297,7 +297,7 @@ fn forward_declared_constant_is_also_marked_constant() {
     !13 = !DICompositeType(tag: DW_TAG_structure_type, name: "foo", scope: !2, file: !2, line: 12, size: 128, align: 64, flags: DIFlagPublic, elements: !14, identifier: "foo")
     !14 = !{!15, !18}
     !15 = !DIDerivedType(tag: DW_TAG_member, name: "__vtable", scope: !2, file: !2, baseType: !16, size: 64, align: 64, flags: DIFlagPublic)
-    !16 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__VOID_POINTER", baseType: !17, size: 64, align: 64, dwarfAddressSpace: 1)
+    !16 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__foo___vtable", baseType: !17, size: 64, align: 64, dwarfAddressSpace: 1)
     !17 = !DIBasicType(name: "__VOID", encoding: DW_ATE_unsigned, flags: DIFlagPublic)
     !18 = !DIDerivedType(tag: DW_TAG_member, name: "something_to_initialize", scope: !2, file: !2, line: 14, baseType: !4, size: 16, align: 16, offset: 64, flags: DIFlagPublic)
     !19 = !{i32 2, !"Dwarf Version", i32 5}

compiler/plc_driver/src/tests/multi_files.rs

@@ -436,7 +436,7 @@ fn dbg_declare_has_valid_metadata_references_for_methods() {
     !4 = !DICompositeType(tag: DW_TAG_structure_type, name: "fb", scope: !2, file: !2, line: 2, size: 64, align: 64, flags: DIFlagPublic, elements: !5, identifier: "fb")
     !5 = !{!6}
     !6 = !DIDerivedType(tag: DW_TAG_member, name: "__vtable", scope: !2, file: !2, baseType: !7, size: 64, align: 64, flags: DIFlagPublic)
-    !7 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__VOID_POINTER", baseType: !8, size: 64, align: 64, dwarfAddressSpace: 1)
+    !7 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__fb___vtable", baseType: !8, size: 64, align: 64, dwarfAddressSpace: 1)
     !8 = !DIBasicType(name: "__VOID", encoding: DW_ATE_unsigned, flags: DIFlagPublic)
     !9 = !{i32 2, !"Dwarf Version", i32 5}
     !10 = !{i32 2, !"Debug Info Version", i32 3}

src/codegen/tests/debug_tests.rs

@@ -56,7 +56,7 @@ attributes #0 = { nofree nosync nounwind readnone speculatable willreturn }
 !8 = !DICompositeType(tag: DW_TAG_structure_type, name: "myFb", scope: !2, file: !2, line: 6, size: 64, align: 64, flags: DIFlagPublic, elements: !9, identifier: "myFb")
 !9 = !{!10}
 !10 = !DIDerivedType(tag: DW_TAG_member, name: "__vtable", scope: !2, file: !2, baseType: !11, size: 64, align: 64, flags: DIFlagPublic)
-!11 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__VOID_POINTER", baseType: !12, size: 64, align: 64, dwarfAddressSpace: 1)
+!11 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__myFb___vtable", baseType: !12, size: 64, align: 64, dwarfAddressSpace: 1)
 !12 = !DIBasicType(name: "__VOID", encoding: DW_ATE_unsigned, flags: DIFlagPublic)
 !13 = !{i32 2, !"Dwarf Version", i32 5}
 !14 = !{i32 2, !"Debug Info Version", i32 3}

src/codegen/tests/debug_tests/snapshots/rusty__codegen__tests__debug_tests__expression_debugging__implementation_added_as_subroutine.snap

@@ -57,7 +57,7 @@ attributes #0 = { nofree nosync nounwind readnone speculatable willreturn }
 !10 = !DICompositeType(tag: DW_TAG_structure_type, name: "fb", scope: !2, file: !2, line: 9, size: 128, align: 64, flags: DIFlagPublic, elements: !11, identifier: "fb")
 !11 = !{!12, !15}
 !12 = !DIDerivedType(tag: DW_TAG_member, name: "__vtable", scope: !2, file: !2, baseType: !13, size: 64, align: 64, flags: DIFlagPublic)
-!13 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__VOID_POINTER", baseType: !14, size: 64, align: 64, dwarfAddressSpace: 1)
+!13 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__fb___vtable", baseType: !14, size: 64, align: 64, dwarfAddressSpace: 1)
 !14 = !DIBasicType(name: "__VOID", encoding: DW_ATE_unsigned, flags: DIFlagPublic)
 !15 = !DIDerivedType(tag: DW_TAG_member, name: "x", scope: !2, file: !2, line: 11, baseType: !6, size: 32, align: 32, offset: 64, flags: DIFlagPublic)
 !16 = !{i32 2, !"Dwarf Version", i32 5}

src/codegen/tests/debug_tests/snapshots/rusty__codegen__tests__debug_tests__expression_debugging__non_function_pous_have_struct_as_param.snap

@@ -83,7 +83,7 @@ attributes #0 = { nofree nosync nounwind readnone speculatable willreturn }
 !8 = !DICompositeType(tag: DW_TAG_structure_type, name: "myFb", scope: !2, file: !2, line: 8, size: 64, align: 64, flags: DIFlagPublic, elements: !9, identifier: "myFb")
 !9 = !{!10}
 !10 = !DIDerivedType(tag: DW_TAG_member, name: "__vtable", scope: !2, file: !2, baseType: !11, size: 64, align: 64, flags: DIFlagPublic)
-!11 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__VOID_POINTER", baseType: !12, size: 64, align: 64, dwarfAddressSpace: 1)
+!11 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__myFb___vtable", baseType: !12, size: 64, align: 64, dwarfAddressSpace: 1)
 !12 = !DIBasicType(name: "__VOID", encoding: DW_ATE_unsigned, flags: DIFlagPublic)
 !13 = !{i32 2, !"Dwarf Version", i32 5}
 !14 = !{i32 2, !"Debug Info Version", i32 3}