fix: internal filemarker (#1294)

Author: mhasel

compiler/plc_ast/src/pre_processor.rs

@@ -189,7 +189,7 @@ fn process_global_variables(unit: &mut CompilationUnit, id_provider: &mut IdProv
                     data_type_declaration: ref_ty.unwrap_or(global_var.data_type_declaration.clone()),
                     initializer: None,
                     address: None,
-                    location: SourceLocation::internal(),
+                    location: global_var.location.clone(),
                 };
                 mangled_globals.push(internal_mangled_var);
             }

compiler/plc_source/src/source_location.rs

@@ -331,6 +331,14 @@ impl SourceLocation {
         SourceLocation { span: CodeSpan::None, file: FileMarker::Internal }
     }
 
+    /// creates an internal SymbolLocation but specifies the CompilationUnit/File it was encountered in.
+    /// This can be necessary when checking if dependencies are located within the same unit as the internally generated
+    /// element
+    pub fn internal_in_unit(unit: Option<&'static str>) -> Self {
+        let Some(unit) = unit else { return Self::internal() };
+        SourceLocation { span: CodeSpan::None, file: FileMarker::File(unit) }
+    }
+
     pub fn is_internal(&self) -> bool {
         self.file.is_internal() && self.span == CodeSpan::None
     }

src/index/tests/index_tests.rs

@@ -1795,7 +1795,17 @@ fn aliased_hardware_access_variable_creates_global_var_for_address() {
         linkage: Internal,
         binding: None,
         source_location: SourceLocation {
-            span: None,
+            span: Range(
+                TextLocation {
+                    line: 2,
+                    column: 12,
+                    offset: 36,
+                }..TextLocation {
+                    line: 2,
+                    column: 15,
+                    offset: 39,
+                },
+            ),
         },
         varargs: None,
     }
@@ -1936,7 +1946,17 @@ fn address_used_in_2_aliases_only_created_once() {
             linkage: Internal,
             binding: None,
             source_location: SourceLocation {
-                span: None,
+                span: Range(
+                    TextLocation {
+                        line: 2,
+                        column: 12,
+                        offset: 36,
+                    }..TextLocation {
+                        line: 2,
+                        column: 15,
+                        offset: 39,
+                    },
+                ),
             },
             varargs: None,
         },
@@ -1975,7 +1995,17 @@ fn aliased_variable_with_in_or_out_directions_create_the_same_variable() {
             linkage: Internal,
             binding: None,
             source_location: SourceLocation {
-                span: None,
+                span: Range(
+                    TextLocation {
+                        line: 2,
+                        column: 12,
+                        offset: 36,
+                    }..TextLocation {
+                        line: 2,
+                        column: 15,
+                        offset: 39,
+                    },
+                ),
             },
             varargs: None,
         },
@@ -1996,7 +2026,17 @@ fn aliased_variable_with_in_or_out_directions_create_the_same_variable() {
             linkage: Internal,
             binding: None,
             source_location: SourceLocation {
-                span: None,
+                span: Range(
+                    TextLocation {
+                        line: 4,
+                        column: 12,
+                        offset: 112,
+                    }..TextLocation {
+                        line: 4,
+                        column: 16,
+                        offset: 116,
+                    },
+                ),
             },
             varargs: None,
         },
@@ -2033,7 +2073,17 @@ fn if_two_aliased_var_of_different_types_use_the_same_address_the_first_wins() {
             linkage: Internal,
             binding: None,
             source_location: SourceLocation {
-                span: None,
+                span: Range(
+                    TextLocation {
+                        line: 2,
+                        column: 12,
+                        offset: 36,
+                    }..TextLocation {
+                        line: 2,
+                        column: 15,
+                        offset: 39,
+                    },
+                ),
             },
             varargs: None,
         },