fix: build script for macOS development #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build script compatibility issues for macOS development, specifically addressing platform-specific linker flags and arguments for creating shared libraries. The changes ensure that build.sh --lit and build.sh --package commands work properly on macOS ARM systems.
Key changes:
- Introduces platform-specific linker flags for macOS vs Linux when creating shared libraries
- Refactors shared library creation logic into a dedicated function
- Improves shell script best practices with proper variable quoting and scoping
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ghaith
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.sh --litas well asbuild.sh --packageshould now work with this PR on MacOS (ARM)