fix: alias subrange-type debuginfo with start & end range and backing type #1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1551 +/- ##
=======================================
Coverage 95.00% 95.01%
=======================================
Files 175 175
Lines 56038 56127 +89
=======================================
+ Hits 53239 53327 +88
- Misses 2799 2800 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances subrange type handling by storing range bounds as resolved constant expressions (TypeSize) instead of raw AST nodes, enabling proper debug info generation with computed range values.
Key Changes
SubRangestorage fromBox<Range<AstNode>>toRange<TypeSize>-> Range bounds are now stored as either literal integers or const expression references
TypeSize::to_ast_node()to convert back to AST nodes when needed for range check calls-> format:
__SUBRANGE_{start}_{end}__{backing_type}(e.g.,__SUBRANGE_0_100__DINT)DINT(ZERO..(100+3)))are now properly resolved to their propagated values in debug info