feat: improve error handling

Author: paul-fresquet

src/ByteSync.Functions/Helpers/Middlewares/ErrorHandlingMiddleware.cs

@@ -2,6 +2,7 @@
 using ByteSync.ServerCommon.Exceptions;
 using Microsoft.ApplicationInsights;
 using Microsoft.Azure.Functions.Worker;
+using Microsoft.Azure.Functions.Worker.Http;
 using Microsoft.Azure.Functions.Worker.Middleware;
 using Microsoft.Extensions.Logging;
 
@@ -24,6 +25,20 @@ public async Task Invoke(FunctionContext context, FunctionExecutionDelegate next
         {
             await next(context);
         }
+        catch (BadRequestException ex)
+        {
+            _telemetryClient.TrackException(ex);
+            _logger.LogWarning(ex, "An error occurred in function {FunctionName}", context.FunctionDefinition.Name);
+            
+            var httpRequest = await context.GetHttpRequestDataAsync();
+            if (httpRequest != null)
+            {
+                PrepareResponse(context, httpRequest, HttpStatusCode.BadRequest);
+                
+                return;
+            }
+            throw;
+        }
         catch (Exception ex)
         {
             _telemetryClient.TrackException(ex);
@@ -32,22 +47,18 @@ public async Task Invoke(FunctionContext context, FunctionExecutionDelegate next
             var httpRequest = await context.GetHttpRequestDataAsync();
             if (httpRequest != null)
             {
-                var response = httpRequest.CreateResponse();
+                PrepareResponse(context, httpRequest, HttpStatusCode.InternalServerError);
 
-                if (ex is BadRequestException)
-                {
-                    response.StatusCode = HttpStatusCode.BadRequest;
-                }
-                else
-                {
-                    response.StatusCode = HttpStatusCode.InternalServerError;
-                }
-                
-                context.GetInvocationResult().Value = response;
-                
                 return;
             }
             throw;
         }
     }
+
+    private static void PrepareResponse(FunctionContext context, HttpRequestData httpRequest, HttpStatusCode statusCode)
+    {
+        var response = httpRequest.CreateResponse();
+        response.StatusCode = statusCode;
+        context.GetInvocationResult().Value = response;
+    }
 }