feat: improve SessionSettingsEditViewModel

refactor: cleanup

Author: paul-fresquet

src/ByteSync.Client/ViewModels/Sessions/Managing/SessionSettingsEditViewModel.cs

@@ -8,7 +8,6 @@
 using ByteSync.Interfaces.Services.Sessions;
 using ReactiveUI;
 using ReactiveUI.Fody.Helpers;
-using Serilog;
 
 namespace ByteSync.ViewModels.Sessions.Managing;
 
@@ -20,6 +19,7 @@ public class SessionSettingsEditViewModel : ActivatableViewModelBase
     private readonly IAnalysisModeViewModelFactory _analysisModeViewModelFactory;
     private readonly IDataTypeViewModelFactory _dataTypeViewModelFactory;
     private readonly ILinkingKeyViewModelFactory _linkingKeyViewModelFactory;
+    private readonly ILogger<SessionSettingsEditViewModel> _logger;
 
 #if DEBUG
     public SessionSettingsEditViewModel()
@@ -30,14 +30,15 @@ public SessionSettingsEditViewModel()
 
     public SessionSettingsEditViewModel(ISessionService sessionService, ILocalizationService localizationService, IDataInventoryStarter dataInventoryStarter,
         IAnalysisModeViewModelFactory analysisModeViewModelFactory, IDataTypeViewModelFactory dataTypeViewModelFactory, 
-        ILinkingKeyViewModelFactory linkingKeyViewModelFactory, SessionSettings? sessionSettings)
+        ILinkingKeyViewModelFactory linkingKeyViewModelFactory, SessionSettings? sessionSettings, ILogger<SessionSettingsEditViewModel> logger)
     {
         _sessionService = sessionService;
         _localizationService = localizationService;
         _dataInventoryStarter = dataInventoryStarter;
         _analysisModeViewModelFactory = analysisModeViewModelFactory ?? throw new ArgumentNullException(nameof(analysisModeViewModelFactory));
         _dataTypeViewModelFactory = dataTypeViewModelFactory;
         _linkingKeyViewModelFactory = linkingKeyViewModelFactory;
+        _logger = logger;
 
         AvailableAnalysisModes =
         [
@@ -90,6 +91,7 @@ public SessionSettingsEditViewModel(ISessionService sessionService, ILocalizatio
                     x => x.DataType,
                     x => x.AnalysisMode, x => x.Extensions)
                 .Skip(1)
+                // .Throttle(TimeSpan.FromMilliseconds(250), RxApp.MainThreadScheduler)
                 .Subscribe(_ => SendUpdate());
         });
     }
@@ -173,11 +175,11 @@ private async void SendUpdate()
             try
             {
                 var sessionSettings = ExportSettings();
-                await _sessionService.SetSessionSettings(sessionSettings);
+                await _sessionService.SetSessionSettings(sessionSettings, true);
             }
             catch (Exception ex)
             {
-                Log.Error(ex, "SendUpdate");
+                _logger.LogError(ex, "SendUpdate");
             }
         }
     }

tests/ByteSync.ServerCommon.Tests/Commands/CloudSessions/QuitSessionCommandHandlerTests.cs

@@ -222,23 +222,4 @@ public async Task QuitSession_SessionMemberNotExists_()
         A.CallTo(() => _mockSessionMemberMapper.Convert(A<SessionMemberData>.Ignored))
             .MustNotHaveHappened();
     }
-
-    // private UpdateEntityResult<T> BuildUpdateResult<T>(bool funcResult, T element, bool isTransaction)
-    // {
-    //     if (funcResult)
-    //     {
-    //         if (isTransaction)
-    //         {
-    //             return new UpdateEntityResult<T>(element, UpdateEntityStatus.WaitingForTransaction);
-    //         }
-    //         else
-    //         {
-    //             return new UpdateEntityResult<T>(element, UpdateEntityStatus.Saved);
-    //         }
-    //     }
-    //     else
-    //     {
-    //         return new UpdateEntityResult<T>(element, UpdateEntityStatus.NotFound);
-    //     }
-    // }
 }