feat: improve CancellationToken usage

Author: paul-fresquet

src/ByteSync.Client/Repositories/CloudSessionConnectionRepository.cs

@@ -127,6 +127,8 @@ public void SetCreateSessionError(CreateSessionError createSessionError)
 
     public void SetJoinSessionError(JoinSessionError joinSessionError)
     {
+        CancellationTokenSource.Cancel();
+        
         _joinSessionError.OnNext(joinSessionError);
     }
 

src/ByteSync.Client/Services/Sessions/Connecting/Joining/CloudSessionPasswordExchangeKeyGivenService.cs

@@ -80,7 +80,8 @@ public async Task Process(GiveCloudSessionPasswordExchangeKeyParameters request)
                 else
                 {
                     await _cloudSessionConnectionRepository.WaitOrThrowAsync(request.SessionId, 
-                        data => data.WaitForJoinSessionEvent, data => data.WaitTimeSpan, "Join session failed");
+                        data => data.WaitForJoinSessionEvent, data => data.WaitTimeSpan, "Join session failed",
+                        _cloudSessionConnectionRepository.CancellationToken);
                 }
             }
             else

src/ByteSync.Common/Controls/BaseRepository.cs

@@ -186,7 +186,8 @@ public bool Wait(string dataId, Func<T, EventWaitHandle> func, Func<T, TimeSpan?
         CheckAndRun(dataId, myFunc);
 
         timeout ??= new TimeSpan(-1);
-        List<WaitHandle> waitHandles = new List<WaitHandle> {waitHandle!};
+        List<WaitHandle> waitHandles = [waitHandle!];
+        
         if (endEvent != null)
         {
             waitHandles.Add(endEvent);
@@ -202,16 +203,20 @@ public bool Wait(string dataId, Func<T, EventWaitHandle> func, Func<T, TimeSpan?
         {
             return true;
         }
-        if (index == 1)
+        if (waitHandles[index] == endEvent)
         {
             Log.Error("Wait: Process has ended");
             return false;
         }
-        else
+        if (waitHandles[index] == cancellationToken.WaitHandle)
         {
-            Log.Error("Wait: timeout has occured");
-            return false;
+            if (cancellationToken.IsCancellationRequested)
+            {
+                return true;
+            }
         }
+        Log.Error("Wait: timeout has occured");
+        return false;
     }
 
     private void CheckAndRun(string? dataId, Action<T> func)