feat: add log

refactor: cleanup

Author: paul-fresquet

src/ByteSync.ServerCommon/Services/Clients/ClientsGroupsHubService.cs

@@ -72,6 +72,8 @@ public async Task AddClientGroup(string connectionId, Client client)
 
         foreach (var subscribedGroup in client.SubscribedGroups)
         {
+            _logger.LogInformation("Adding client {clientInstanceId} to subscribed group {subscribedGroup}", client.ClientInstanceId, subscribedGroup);
+            
             await _hubContext.Groups.AddToGroupAsync(connectionId, subscribedGroup).ConfigureAwait(false);
         }
     }

tests/ByteSync.ServerCommon.Tests/Commands/CloudSessions/CreateSessionCommandHandlerTests.cs

@@ -77,7 +77,7 @@ public async Task Handle_ValidRequest_CreatesSession()
                     A<CloudSessionData>.Ignored,
                     A<Func<string>>.Ignored,
                     A<ITransaction>.Ignored))
-                .Invokes((CloudSessionData session, Func<string> generateId, ITransaction _) =>
+                .Invokes((CloudSessionData session, Func<string> _, ITransaction _) =>
                 {
                     addedCloudSession = session;
                     session.SessionId = sessionId;

tests/ByteSync.ServerCommon.Tests/Commands/CloudSessions/FinalizeJoinCloudSessionCommandHandlerTests.cs

@@ -95,7 +95,7 @@ public async Task Handle_SuccessfulFinalization_ReturnsSuccess()
                 A<string>.That.IsEqualTo(sessionId),
                 A<Func<CloudSessionData, bool>>.Ignored,
                 A<ITransaction>.That.IsEqualTo(_mockTransaction), A<IRedLock>.Ignored))
-            .Invokes((string id, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
+            .Invokes((string _, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
             {
                 funcResult = updateAction(cloudSession);
                 isTransaction = transaction != null;
@@ -158,7 +158,7 @@ public async Task Handle_SessionNotFound_ReturnsSessionNotFoundStatus()
                 A<string>.That.IsEqualTo(sessionId),
                 A<Func<CloudSessionData, bool>>.Ignored,
                 A<ITransaction>.That.IsEqualTo(_mockTransaction), A<IRedLock>.Ignored))
-            .Invokes((string id, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
+            .Invokes((string _, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
             {
                 funcResult = updateAction(cloudSessionData);
                 isTransaction = transaction != null;
@@ -187,7 +187,7 @@ public async Task Handle_SessionAlreadyActivated_ReturnsSessionAlreadyActivatedS
                 A<string>.That.IsEqualTo(sessionId),
                 A<Func<CloudSessionData, bool>>.Ignored,
                 A<ITransaction>.That.IsEqualTo(_mockTransaction), A<IRedLock>.Ignored))
-            .Invokes((string id, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
+            .Invokes((string _, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
             {
                 funcResult = updateAction(cloudSessionData);
                 isTransaction = transaction != null;
@@ -218,7 +218,7 @@ public async Task Handle_AuthNotChecked_ReturnsAuthNotCheckedStatus()
                 A<string>.That.IsEqualTo(sessionId),
                 A<Func<CloudSessionData, bool>>.Ignored,
                 A<ITransaction>.That.IsEqualTo(_mockTransaction), A<IRedLock>.Ignored))
-            .Invokes((string id, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
+            .Invokes((string _, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
             {
                 funcResult = updateAction(cloudSessionData);
                 isTransaction = transaction != null;
@@ -250,7 +250,7 @@ public async Task Handle_PrememberNotFound_ReturnsPrememberNotFoundStatus()
                 A<string>.That.IsEqualTo(sessionId),
                 A<Func<CloudSessionData, bool>>.Ignored,
                 A<ITransaction>.That.IsEqualTo(_mockTransaction), A<IRedLock>.Ignored))
-            .Invokes((string id, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
+            .Invokes((string _, Func<CloudSessionData, bool> updateAction, ITransaction? transaction, IRedLock _) =>
             {
                 funcResult = updateAction(cloudSessionData);
                 isTransaction = transaction != null;