[feature] Add protocol version check in session connection (#246)

Author: paul-fresquet

AGENTS.md

@@ -42,6 +42,11 @@ Examples:
 - `[feature] Add user registration`
 - `[bugfix] Fix memory leak in sync module`
 
+### PR Descriptions
+
+- PR descriptions must be written in English.
+- Include a summary of the changes, main modifications, and implementation approach when relevant.
+
 ### Notes for Agents
 - Never propose changes directly on `master`.
 - Always create a branch using the proper prefix.

src/ByteSync.Client/Assets/Resources/Resources.Designer.cs

@@ -1559,6 +1559,9 @@ Voulez-vous enregistrer ce nouveau Profil de Session avec ce nom ?</value>
 	<data name="JoinCloudSession_CanceledByUser" xml:space="preserve">
 		<value>Opération annulée par l'utilisateur.</value>
 	</data>
+	<data name="JoinCloudSession_IncompatibleProtocolVersion" xml:space="preserve">
+		<value>La version de votre application est incompatible avec cette session. Veuillez mettre à jour ByteSync pour rejoindre cette session.</value>
+	</data>
 	<data name="CreateCloudSession_CanceledByUser" xml:space="preserve">
 		<value>Opération annulée par l'utilisateur.</value>
 	</data>

src/ByteSync.Client/Assets/Resources/Resources.fr.resx

@@ -1601,6 +1601,9 @@ Do you want to save this new Session Profile with this name?</value>
 	<data name="JoinCloudSession_CanceledByUser" xml:space="preserve">
 		<value>Operation canceled by the user.</value>
 	</data>
+	<data name="JoinCloudSession_IncompatibleProtocolVersion" xml:space="preserve">
+		<value>Your application version is incompatible with this session. Please update ByteSync to join this session.</value>
+	</data>
 	<data name="CreateCloudSession_CanceledByUser" xml:space="preserve">
 		<value>Operation canceled by the user.</value>
 	</data>

src/ByteSync.Client/Assets/Resources/Resources.resx

@@ -3,7 +3,7 @@
 using System.Text;
 using ByteSync.Business.Communications;
 using ByteSync.Common.Business.EndPoints;
-using ByteSync.Common.Helpers;
+using ByteSync.Common.Business.Versions;
 using ByteSync.Interfaces;
 using ByteSync.Interfaces.Controls.Communications;
 using ByteSync.Interfaces.Services.Communications;
@@ -16,56 +16,57 @@ public class PublicKeysManager : IPublicKeysManager
     private readonly IApplicationSettingsRepository _applicationSettingsRepository;
     private readonly IConnectionService _connectionService;
     private readonly ILogger<PublicKeysManager> _logger;
-
+    
     public PublicKeysManager(IApplicationSettingsRepository applicationSettingsManager, IConnectionService connectionService,
         ILogger<PublicKeysManager> logger)
     {
         _applicationSettingsRepository = applicationSettingsManager;
         _connectionService = connectionService;
         _logger = logger;
     }
-
+    
     public PublicKeyInfo GetMyPublicKeyInfo()
     {
         var applicationSettings = _applicationSettingsRepository.GetCurrentApplicationSettings();
-
+        
         var myPublicKeyInfo = new PublicKeyInfo
         {
             ClientId = applicationSettings.ClientId,
             PublicKey = applicationSettings.DecodedRsaPublicKey!,
+            ProtocolVersion = ProtocolVersion.CURRENT,
         };
-
+        
         return myPublicKeyInfo;
     }
-
+    
     public PublicKeyCheckData BuildJoinerPublicKeyCheckData(PublicKeyCheckData memberPublicKeyCheckData)
     {
         var joinerPublicKeyCheckData =
             BuildPublicKeyCheckData(memberPublicKeyCheckData.IssuerPublicKeyInfo, null, memberPublicKeyCheckData.Salt);
-
+        
         return joinerPublicKeyCheckData;
     }
-
+    
     public PublicKeyCheckData BuildMemberPublicKeyCheckData(PublicKeyInfo joinerPublicKeyInfo, bool isTrustedByMember)
     {
         var joinerPublicKeyCheckData =
             BuildPublicKeyCheckData(joinerPublicKeyInfo, isTrustedByMember, null);
-
+        
         return joinerPublicKeyCheckData;
     }
-
+    
     private PublicKeyCheckData BuildPublicKeyCheckData(PublicKeyInfo? otherPartyPublicKeyInfo, bool? checkResponse, string? salt)
     {
         var publicKeyCheckData = new PublicKeyCheckData();
 
         publicKeyCheckData.IssuerPublicKeyInfo = GetMyPublicKeyInfo();
         publicKeyCheckData.IssuerClientInstanceId = _connectionService.ClientInstanceId!;
-
+        
         publicKeyCheckData.OtherPartyPublicKeyInfo = otherPartyPublicKeyInfo;
 
         var publicKeyFormatter = new PublicKeyFormatter();
         publicKeyCheckData.IssuerPublicKeyHash = publicKeyFormatter.Format(publicKeyCheckData);
-
+        
         if (salt != null)
         {
             publicKeyCheckData.Salt = salt;
@@ -80,84 +81,86 @@ private PublicKeyCheckData BuildPublicKeyCheckData(PublicKeyInfo? otherPartyPubl
             // C'est supérieur à une recommandation "pseudo standard"
             publicKeyCheckData.Salt = RandomUtils.GetRandomLetters(12, null);
         }
-
+        
         publicKeyCheckData.OtherPartyCheckResponse = checkResponse;
-
+        
+        publicKeyCheckData.ProtocolVersion = ProtocolVersion.CURRENT;
+        
         return publicKeyCheckData;
     }
-
+    
     public bool IsTrusted(PublicKeyCheckData publicKeyCheckData)
     {
         return IsTrusted(publicKeyCheckData.IssuerPublicKeyInfo);
     }
-
+    
     public bool IsTrusted(PublicKeyInfo publicKeyInfo)
     {
         var applicationSettings = _applicationSettingsRepository.GetCurrentApplicationSettings();
 
         var trustedKey = applicationSettings.DecodedTrustedPublicKeys!
             .Where(tk => Equals(tk.ClientId, publicKeyInfo.ClientId))
             .MaxBy(tk => tk.ValidationDate);
-
+        
         var result = false;
         if (trustedKey != null)
         {
             result = trustedKey.PublicKey.SequenceEqual(publicKeyInfo.PublicKey);
         }
-
+        
         if (!result)
         {
             _logger.LogWarning("Public Key {@publicKeyInfo} is not trusted", publicKeyInfo);
         }
-
+        
         return result;
     }
-
+    
     public ReadOnlyCollection<TrustedPublicKey>? GetTrustedPublicKeys()
     {
         return _applicationSettingsRepository.GetCurrentApplicationSettings().DecodedTrustedPublicKeys;
     }
-
+    
     public TrustedPublicKey BuildTrustedPublicKey(PublicKeyCheckData publicKeyCheckData)
     {
         var trustedPublicKey = new TrustedPublicKey();
         trustedPublicKey.ClientId = publicKeyCheckData.IssuerPublicKeyInfo.ClientId;
         trustedPublicKey.PublicKey = publicKeyCheckData.IssuerPublicKeyInfo.PublicKey;
         trustedPublicKey.ValidationDate = DateTimeOffset.Now;
-
+        
         var publicKeyFormatter = new PublicKeyFormatter();
         trustedPublicKey.PublicKeyHash = publicKeyFormatter.Format(trustedPublicKey.PublicKey);
-
+        
         var sha256PublicKeys = new List<string>();
         sha256PublicKeys.Add(CryptographyUtils.ComputeSHA256(publicKeyCheckData.IssuerPublicKeyInfo.PublicKey));
         sha256PublicKeys.Add(CryptographyUtils.ComputeSHA256(GetMyPublicKeyInfo().PublicKey));
         sha256PublicKeys.Sort();
-
+        
         var precomputed = sha256PublicKeys[0] + "_" + sha256PublicKeys[1] + "_" + publicKeyCheckData.Salt;
-
+        
         var md5 = CryptographyUtils.ComputeMD5FromText(precomputed);
-
+        
         trustedPublicKey.SafetyKey = md5;
-
+        
         return trustedPublicKey;
     }
-
+    
     public void Trust(TrustedPublicKey trustedPublicKey)
     {
-        _applicationSettingsRepository.UpdateCurrentApplicationSettings(settings => 
+        _applicationSettingsRepository.UpdateCurrentApplicationSettings(settings =>
             settings.AddTrustedKey(trustedPublicKey));
 
         _logger.LogInformation("Added Trusted Public Key {@publicKey}", trustedPublicKey);
     }
-
+    
     public void Delete(TrustedPublicKey trustedPublicKey)
     {
-        _applicationSettingsRepository.UpdateCurrentApplicationSettings(settings => 
+        _applicationSettingsRepository.UpdateCurrentApplicationSettings(settings =>
             settings.RemoveTrustedKey(trustedPublicKey));
 
         _logger.LogInformation("Removed Trusted Public Key {@publicKey}", trustedPublicKey);
     }
-
+    
     public void InitializeRsaAndTrustedPublicKeys()
     {
         var updatedSettings = _applicationSettingsRepository.UpdateCurrentApplicationSettings(settings =>
@@ -169,31 +172,31 @@ public void InitializeRsaAndTrustedPublicKeys()
         _logger.LogInformation("Initialized Local RSA Keys and removed all Trusted Public Keys");
         _logger.LogInformation("ClientId is now {@clientId}", updatedSettings.ClientId);
     }
-
+    
     public byte[] DecryptBytes(byte[] messageToDecrypt)
     {
         // On décrypte avec la clé privée
         var privateRsa = _applicationSettingsRepository.GetCurrentApplicationSettings()
             .PrivateRsa;
 
         var decryptedBytes = privateRsa.Decrypt(messageToDecrypt, RSAEncryptionPadding.Pkcs1);
-
+        
         return decryptedBytes;
     }
-
+    
     public string DecryptString(byte[] messageToDecrypt)
     {
         // On décrypte avec la clé privée
         var privateRsa = _applicationSettingsRepository.GetCurrentApplicationSettings()
             .PrivateRsa;
-
+        
         var decryptedBytes = privateRsa.Decrypt(messageToDecrypt, RSAEncryptionPadding.Pkcs1);
-
+        
         var decryptedMessage = Encoding.UTF8.GetString(decryptedBytes);
-
+        
         return decryptedMessage;
     }
-
+    
     public byte[] EncryptString(PublicKeyInfo publicKeyInfo, string messageToEncrypt)
     {
         var bytes = Encoding.UTF8.GetBytes(messageToEncrypt);
@@ -203,10 +206,10 @@ public byte[] EncryptString(PublicKeyInfo publicKeyInfo, string messageToEncrypt
 
         // On encrypte avec la clé de la tierce partie
         var result = rsa.Encrypt(bytes, RSAEncryptionPadding.Pkcs1);
-
+        
         return result;
     }
-
+    
     public byte[] SignData(string dataToEncrypt)
     {
         var bytes = Encoding.UTF8.GetBytes(dataToEncrypt);
@@ -218,7 +221,7 @@ public byte[] SignData(string dataToEncrypt)
 
         // On encrypte avec la clé de la tierce partie
         var result = rsa.SignData(bytes, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1);
-
+        
         return result;
     }
 
@@ -232,21 +235,21 @@ public bool VerifyData(PublicKeyInfo publicKeyInfo, byte[] dataToVerify, string
 
         var rsa = RSA.Create();
         rsa.ImportRSAPublicKey(publicKeyInfo.PublicKey, out _);
-
+        
         // bool result = rsa.VerifyData(dataToVerify, signatureBytes, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1);
         var result = rsa.VerifyData(signatureBytes, dataToVerify, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1);
-
+        
         return result;
     }
-
+    
     public byte[] EncryptBytes(PublicKeyInfo publicKeyInfo, byte[] messageToEncrypt)
     {
         var rsa = RSA.Create();
         rsa.ImportRSAPublicKey(publicKeyInfo.PublicKey, out _);
 
         // On encrypte avec la clé de la tierce partie
         var result = rsa.Encrypt(messageToEncrypt, RSAEncryptionPadding.Pkcs1);
-
+        
         return result;
     }
 }