Skip to content

Commit 9504047

Browse files
committed
disable msvc warnings as error, add python cibuildwheel for macos
1 parent 223f450 commit 9504047

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

cpp/cmake/CompilerOptions.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ function(set_global_target_properties target)
2727
${target}
2828
PRIVATE # MSVC
2929
$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:/W4>
30-
$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:/WX>
3130
# Clang/AppleClang
3231
$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-fcolor-diagnostics>
3332
$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wall>

cpp/map_closures/AlignRansac2D.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ std::pair<Eigen::Isometry2d, int> RansacAlignment2D(const std::vector<PointPair>
113113
std::transform(optimal_inlier_indices.cbegin(), optimal_inlier_indices.cend(),
114114
inlier_keypoint_pairs.begin(),
115115
[&](const auto index) { return keypoint_pairs[index]; });
116-
auto T = KabschUmeyamaAlignment2D(inlier_keypoint_pairs);
116+
Eigen::Isometry2d T = KabschUmeyamaAlignment2D(inlier_keypoint_pairs);
117117
return {T, num_inliers};
118118
}
119119
} // namespace map_closures

python/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,7 @@ max-line-length = "100"
6363
[tool.cibuildwheel]
6464
archs = ["auto64"]
6565
skip = ["*-musllinux*", "pp*", "cp36-*"]
66+
67+
[tool.cibuildwheel.macos]
68+
environment = "MACOSX_DEPLOYMENT_TARGET=10.14"
69+
archs = ["auto64", "arm64"]

0 commit comments

Comments
 (0)