Open
Conversation
Add compile and run scripts for sharded ocean climate simulation using a
tripolar grid with the coupled ocean-atmosphere model. This tests sharding
with a different grid topology (tripolar vs lat-lon) and atmosphere coupling.
Changes:
- New sharding/sharded_ocean_climate_simulation_{run,compile}.jl scripts
- Refactor data_free_ocean_climate_model_init to accept (arch, Nx, Ny, Nz)
for explicit grid sizing needed by sharding tests
- Add grid_type option (:gaussian_islands, :simple_tripolar) and
set_initial_conditions flag to data_free_ocean_climate_model_init
- Add simple_tripolar_grid helper in model_utils.jl
- Update Compile.yml and Run.yml workflows to include sharded ocean climate
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
Collaborator
|
OOMs again, should we diminish the problem size like in #258 ? |
Collaborator
Author
I think so. Also baroclinic instability -- hm! |
Match the smaller defaults (64×64) used in PR #258 for the sharded baroclinic instability test to avoid out-of-memory on CI runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Switch sharded ocean climate default grid from simple_tripolar to simple_lat_lon to match the serial ocean climate simulation. Keep set_initial_conditions=false since set!(field, function) cannot compile through Reactant's LLVM on any distributed architecture. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sharding/sharded_ocean_climate_simulation_{run,compile}.jl)data_free_ocean_climate_model_initto accept(arch, Nx, Ny, Nz)withgrid_type,halo,Δt, andset_initial_conditionskwargssimple_tripolar_gridhelper inmodel_utils.jlCompile.ymlandRun.ymlworkflows to includesharded_ocean_climatein the sharded test matricesThis tests sharding with a different grid topology (tripolar vs lat-lon) and atmosphere coupling, complementing the existing
sharded_baroclinic_instabilitytest which only uses a simple lat-lon grid.Known issues
The test currently surfaces three Reactant/Oceananigans limitations with distributed TripolarGrid:
set!(field, function)on distributed TripolarGrid fails (unsupported dynamic function invocationin LLVM) — worked around withset_initial_conditions=falseImmersedBoundaryGridconstruction fails for distributed TripolarGrid — worked around withgrid_type=:simple_tripolarllvm.call op operand type mismatchinraise_triton_custom_callpass) — needs upstream Reactant fixTest plan
🤖 Generated with Claude Code