feat: check msrv by the configure script and refactoring (#311)

Author: eitsupi

LICENSE.note

@@ -484,31 +484,31 @@ License:     Apache-2.0 OR BSL-1.0
 -------------------------------------------------------------
 
 Name:        savvy
-Version:     0.6.7
+Version:     0.6.8
 Repository:  https://github.com/yutannihilation/savvy/
 Authors:     Hiroaki Yutani
 License:     MIT
 
 -------------------------------------------------------------
 
 Name:        savvy-bindgen
-Version:     0.6.7
+Version:     0.6.8
 Repository:  https://github.com/yutannihilation/savvy/
 Authors:     Hiroaki Yutani
 License:     MIT
 
 -------------------------------------------------------------
 
 Name:        savvy-ffi
-Version:     0.6.7
+Version:     0.6.8
 Repository:  https://github.com/yutannihilation/savvy/
 Authors:     Hiroaki Yutani
 License:     MIT
 
 -------------------------------------------------------------
 
 Name:        savvy-macro
-Version:     0.6.7
+Version:     0.6.8
 Repository:  https://github.com/yutannihilation/savvy/
 Authors:     Hiroaki Yutani
 License:     MIT

NEWS.md

@@ -7,6 +7,8 @@
 ## Miscellaneous
 
 - On R-universe, installing with pre-built binaries is now default. (#305)
+- The configure script now compares the package's MSRV and the rustc version,
+  and if the rustc version is less than the MSRV, an warning message is displayed. (#311)
 
 # prqlr 0.8.1
 

configure

@@ -14,7 +14,7 @@ export PATH="$PATH:$HOME/.cargo/bin"
 
 check_cargo() {
   if [ ! "$(command -v cargo)" ]; then
-  cat <<EOF
+    cat <<EOF
 ------------------------- [RUST NOT FOUND] -------------------------
 The 'cargo' command was not found on the PATH. Please install rustc
 from: https://www.rust-lang.org/tools/install
@@ -27,7 +27,7 @@ Alternatively, you may install cargo from your OS package manager:
 EOF
     exit 1
   else
-cat <<EOF
+    cat <<EOF
 --------------------------- [RUST FOUND] ---------------------------
 $(cargo -V)
 
@@ -44,7 +44,7 @@ check_bin_lib() {
 
   # On R-universe, we try to download the pre-built binary from GitHub releases.
   if [ -n "${MY_UNIVERSE}" ] && [ -z "${LIBPRQLR_BUILD}" ]; then
-cat <<EOF
+    cat <<EOF
 --------------------- [SETTING FOR R-UNIVERSE] ---------------------
 It seems that this is on R-universe <${MY_UNIVERSE}>.
 Trying to download pre-built binary.
@@ -53,46 +53,39 @@ EOF
     LIBPRQLR_BUILD="false"
   fi
 
-  if [ "${LIBPRQLR_BUILD}" = "false" ] && [ -f "tools/lib-sums.tsv" ] && [ ! -f "${LIBPRQLR_PATH}" ]; then
-cat <<EOF
+  if [ "${LIBPRQLR_BUILD}" = "false" ]; then
+    if [ -f "tools/lib-sums.tsv" ] && [ ! -f "${LIBPRQLR_PATH}" ]; then
+      cat <<EOF
 --------------- [TRY TO DOWNLOAD PRE-BUILT BINARY] ---------------
+The library was not found at <${LIBPRQLR_PATH}>.
+Trying to download pre-built binary from the Internet.
 $("${R_HOME}/bin${R_ARCH_BIN}/Rscript" "tools/prep-lib.R" || echo "Failed to download pre-built binary.")
 ------------------------------------------------------------------
 EOF
-  fi
-
-  if [ "${LIBPRQLR_BUILD}" = "false" ] && [ -f "${LIBPRQLR_PATH}" ]; then
-cat <<EOF
----------------------- [LIBRARY BINARY FOUND] ----------------------
-The library was found at <${LIBPRQLR_PATH}>. No need to build it.
+    fi
 
-Note: rustc version: $(command -v rustc >/dev/null && rustc -V || echo "Not found")
---------------------------------------------------------------------
-EOF
-    sed -e "s|@RUST_TARGET@||" src/Makevars.in >src/Makevars
-    if [ "${LIBPRQLR_PATH}" != "${LIBPRQLR_DEFAULT_PATH}" ]; then
-cat <<EOF
+    if [ -f "${LIBPRQLR_PATH}" ] && [ "${LIBPRQLR_PATH}" != "${LIBPRQLR_DEFAULT_PATH}" ]; then
+      cat <<EOF
 ------------------------ [COPYING BINARY] ------------------------
 Copying <${LIBPRQLR_PATH}> to <${LIBPRQLR_DEFAULT_PATH}>.
 $(mkdir -p "$(dirname "${LIBPRQLR_DEFAULT_PATH}")")
 $(cp "${LIBPRQLR_PATH}" "${LIBPRQLR_DEFAULT_PATH}" || echo "Failed to copy binary.")
 ------------------------------------------------------------------
 EOF
     fi
-    exit 0
-  elif [ "${LIBPRQLR_BUILD}" = "false" ] && [ -f "${LIBPRQLR_DEFAULT_PATH}" ]; then
-cat <<EOF
+
+    if [ -f "${LIBPRQLR_DEFAULT_PATH}" ]; then
+      cat <<EOF
 ---------------------- [LIBRARY BINARY FOUND] ----------------------
-The library was not found at <${LIBPRQLR_PATH}>,
-but was found at <${LIBPRQLR_DEFAULT_PATH}>. No need to build it.
+The library was found at <${LIBPRQLR_DEFAULT_PATH}>. No need to build it.
 
 Note: rustc version: $(command -v rustc >/dev/null && rustc -V || echo "Not found")
 --------------------------------------------------------------------
 EOF
-    sed -e "s|@RUST_TARGET@||" src/Makevars.in >src/Makevars
-    exit 0
-  elif [ "${LIBPRQLR_BUILD}" = "false" ]; then
-cat <<EOF
+      sed -e "s|@RUST_TARGET@||" src/Makevars.in >src/Makevars
+      exit 0
+    fi
+    cat <<EOF
 -------------------- [LIBRARY BINARY NOT FOUND] --------------------
 The library was not found at <${LIBPRQLR_PATH}>.
 Falling back to building from source.
@@ -106,7 +99,7 @@ detect_target_option() {
     case "${option}" in
     --host=*)
       specified_target="$(echo "${option}" | sed -e 's/--host=//' | sed -E 's/([0-9]+\.)*[0-9]+$//')"
-cat <<EOF
+      cat <<EOF
 ------------------------- [DETECTED TARGET] -------------------------
 The target was specified as <${specified_target}> via the '--host' option.
 ---------------------------------------------------------------------
@@ -119,9 +112,37 @@ EOF
   done
 }
 
+check_msrv() {
+  rustc_version="$(rustc -V | grep -o '[0-9]\+\(\.[0-9]\+\)\+')"
+  package_rust_version="$(
+    cargo metadata --manifest-path src/rust/Cargo.toml --no-deps --format-version 1 |
+      grep -o '"rust_version"\s*:\s*"[0-9]\+\(\.[0-9]\+\)\+"' |
+      grep -o '[0-9]\+\(\.[0-9]\+\)\+'
+  )"
+  lower_version="$(echo "${rustc_version} ${package_rust_version}" | tr ' ' '\n' | sort -V | head -n1)"
+
+  if [ "${rustc_version}" != "${package_rust_version}" ] && [ "${rustc_version}" = "${lower_version}" ]; then
+    cat <<EOF
+------------------- [NOT SUPPORTED RUST VERSION] -------------------
+The MSRV of this package is '${package_rust_version}',
+so this installation may fail with the current rustc version '${rustc_version}'.
+If this happens, please install the newer version of rustc
+from: https://www.rust-lang.org/tools/install
+--------------------------------------------------------------------
+EOF
+  else
+    cat <<EOF
+----------------- [MINIMUM SUPPORTED RUST VERSION] -----------------
+The MSRV of this package is '${package_rust_version}'.
+--------------------------------------------------------------------
+EOF
+  fi
+}
+
 detect_target_option "$@"
 check_bin_lib
 check_cargo
+check_msrv
 
 # cf. https://github.com/r-wasm/rwasm/issues/18#issuecomment-1910198843
 if [ "$(uname)" = "Emscripten" ]; then