Skip to content

Commit b3bf603

Browse files
author
Konstantin Wolff
committed
added bugfix to more sensors. Bug could lead to sensor processes basically hanging up
1 parent d80203b commit b3bf603

File tree

12 files changed

+25
-2
lines changed

12 files changed

+25
-2
lines changed

miniprobe/sensors/adns.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ def get_data(data, out_queue):
133133
"message": "DNS sensor failed. See log for details"
134134
}
135135
out_queue.put(data_r)
136+
return 1
136137
dns_channel = adns.get_dns(int(timed*1000))
137138
addressdata = []
138139
for element in dns_channel:
@@ -153,6 +154,7 @@ def get_data(data, out_queue):
153154
del result
154155
gc.collect()
155156
out_queue.put(data)
157+
return 0
156158

157159
@staticmethod
158160
def get_dns(time):

miniprobe/sensors/apt.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ def get_data(data, out_queue):
117117
"message": "APT failed. %s" % e
118118
}
119119
out_queue.put(data_r)
120+
return 1
120121
del apt
121122
gc.collect()
122123
out_queue.put(data_r)
124+
return 0

miniprobe/sensors/cpuload.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def get_data(data, out_queue):
6767
"message": "CPU load sensor failed. See log for details"
6868
}
6969
out_queue.put(data)
70+
return 1
7071
cpudata = []
7172
for element in cpu:
7273
cpudata.append(element)
@@ -78,6 +79,7 @@ def get_data(data, out_queue):
7879
del cpuload
7980
gc.collect()
8081
out_queue.put(data)
82+
return 0
8183

8284
@staticmethod
8385
def read_cpu(path):

miniprobe/sensors/cputemp.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ def get_data(data, out_queue):
8888
"code": 1,
8989
"message": "CPUTemp sensor failed. See log for details"
9090
}
91-
return out_queue.put(data)
91+
out_queue.put(data)
92+
return 1
9293
tempdata = []
9394
for element in temp:
9495
tempdata.append(element)
@@ -100,6 +101,7 @@ def get_data(data, out_queue):
100101
del temperature
101102
gc.collect()
102103
out_queue.put(data)
104+
return 1
103105

104106
@staticmethod
105107
def read_temp(config):

miniprobe/sensors/diskspace.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ def get_data(data, out_queue):
6868
"message": "Disk Space Sensor failed. See log for details"
6969
}
7070
out_queue.put(data)
71+
return 1
7172
channels = disk
7273
data = {
7374
"sensorid": int(data['sensorid']),
@@ -77,6 +78,7 @@ def get_data(data, out_queue):
7778
del diskspace
7879
gc.collect()
7980
out_queue.put(data)
81+
return 0
8082

8183
def read_disk(self):
8284
disks = []

miniprobe/sensors/ds18b20.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ def get_data(data, out_queue):
9595
"message": "DS18B20 sensor failed. See log for details"
9696
}
9797
out_queue.put(data)
98+
return 1
9899
tempdata = []
99100
for element in temp:
100101
tempdata.append(element)
@@ -106,6 +107,7 @@ def get_data(data, out_queue):
106107
del temperature
107108
gc.collect()
108109
out_queue.put(data)
110+
return 0
109111

110112
@staticmethod
111113
def read_temp(config):

miniprobe/sensors/external_ip.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ def get_data(data, out_queue):
7373
"message": "External IP sensor failed. See log for details"
7474
}
7575
out_queue.put(data)
76+
return 1
7677
addressdata = []
7778
for element in address:
7879
addressdata.append(element)
@@ -84,6 +85,7 @@ def get_data(data, out_queue):
8485
del address
8586
gc.collect()
8687
out_queue.put(data)
88+
return 0
8789

8890
@staticmethod
8991
def get_ip(url):

miniprobe/sensors/http.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ def get_data(data, out_queue):
190190
"message": "HTTP Request failed. See log for details"
191191
}
192192
out_queue.put(data)
193+
return 1
193194

194195
data = {
195196
"sensorid": int(data['sensorid']),
@@ -205,3 +206,4 @@ def get_data(data, out_queue):
205206
del http
206207
gc.collect()
207208
out_queue.put(data)
209+
return 0

miniprobe/sensors/memory.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def get_data(data, out_queue):
6767
"message": "Memory sensor failed. See log for details"
6868
}
6969
out_queue.put(data)
70+
return 1
7071
memorydata = []
7172
for element in mem:
7273
memorydata.append(element)
@@ -78,6 +79,7 @@ def get_data(data, out_queue):
7879
del memory
7980
gc.collect()
8081
out_queue.put(data)
82+
return 0
8183

8284
def read_memory(self, path):
8385
mem = open(path, "r")

miniprobe/sensors/nmap.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def get_data(data, out_queue):
124124
"message": "Port check failed or ports closed. See log for details"
125125
}
126126
out_queue.put(sensor_data)
127-
return
127+
return 1
128128
sensor_data = {
129129
"sensorid": int(data['sensorid']),
130130
"message": alive_str[:-2],
@@ -133,6 +133,7 @@ def get_data(data, out_queue):
133133
del nmap
134134
gc.collect()
135135
out_queue.put(sensor_data)
136+
return 0
136137

137138
def ip2bin(self,ip):
138139
b = ""

0 commit comments

Comments
 (0)