Resolve public feed while connecting Apple shows

Author: svevang

app/models/apple/show.rb

@@ -15,7 +15,21 @@ def self.apple_episode_json(api, show_id)
     end
 
     def self.connect_existing(apple_show_id, delegated_delivery_config)
-      if (sl = SyncLog.apple.find_by(feeder_id: delegated_delivery_config.public_feed.id, feeder_type: :feeds))
+      public_feed = delegated_delivery_config.public_feed
+
+      # TODO: remove guard against transitional data
+      unless public_feed.present?
+        Rails.logger.warn(
+          "Apple::DelegatedDeliveryConfig#public_feed is empty; using legacy public feed",
+          apple_config_id: delegated_delivery_config.id,
+          podcast_id: delegated_delivery_config.podcast_id
+        )
+        public_feed = delegated_delivery_config.legacy_public_feed
+      end
+
+      raise "Missing Apple public feed" unless public_feed
+
+      if (sl = SyncLog.apple.find_by(feeder_id: public_feed.id, feeder_type: :feeds))
         if apple_show_id.blank?
           return sl.destroy!
         elsif sl.external_id != apple_show_id
@@ -24,7 +38,7 @@ def self.connect_existing(apple_show_id, delegated_delivery_config)
       else
         SyncLog.log!(
           integration: :apple,
-          feeder_id: delegated_delivery_config.public_feed.id,
+          feeder_id: public_feed.id,
           feeder_type: :feeds,
           sync_completed_at: Time.now.utc,
           external_id: apple_show_id
@@ -33,7 +47,7 @@ def self.connect_existing(apple_show_id, delegated_delivery_config)
 
       api = Apple::Api.from_delegated_delivery_config(delegated_delivery_config)
       new(api: api,
-        public_feed: delegated_delivery_config.public_feed,
+        public_feed: public_feed,
         private_feed: delegated_delivery_config.delivery_feed)
     end
 

test/models/apple/show_test.rb

@@ -256,6 +256,15 @@
   describe ".connect_existing" do
     let(:apple_config) { create(:apple_config, feed: private_feed) }
 
+    it "uses the legacy public feed to connect an unbound config under binding routing" do
+      with_show_feed_binding_routing do
+        apple_show = Apple::Show.connect_existing("some_apple_id", apple_config)
+
+        assert_equal public_feed, apple_show.public_feed
+        assert_equal "some_apple_id", public_feed.reload.apple_sync_log.external_id
+      end
+    end
+
     it "should take in the apple show id an apple credentials object" do
       apple_config.save!
       apple_show = Apple::Show.connect_existing("some_apple_id", apple_config)