Merge pull request #1537 from PRX/fix/stream_recording_errors

Handle stream recording errors

Author: cavis

app/helpers/stream_recordings_helper.rb

@@ -46,7 +46,7 @@ def stream_status_class(resource)
       "warning"
     elsif resource.status_complete?
       "info"
-    elsif resource.recording?
+    elsif resource.recording? || resource.status_error?
       "danger"
     else
       "primary"

app/models/stream_resource.rb

@@ -16,9 +16,9 @@ class StreamResource < ApplicationRecord
 
   validates :start_at, presence: true
   validates :end_at, presence: true, comparison: {greater_than: :start_at}
-  validates :actual_start_at, presence: true, if: :done_recording?
-  validates :actual_end_at, presence: true, comparison: {greater_than: :actual_start_at}, if: :done_recording?
-  validates :original_url, presence: true, if: :done_recording?
+  validates :actual_start_at, presence: true, if: :has_recording?
+  validates :actual_end_at, presence: true, comparison: {greater_than: :actual_start_at}, if: :has_recording?
+  validates :original_url, presence: true, if: :has_recording?
 
   after_initialize :set_defaults
   before_validation :set_defaults
@@ -43,15 +43,15 @@ def copy_media(force = false)
   def needs_copy?
     if status_complete?
       false
-    elsif done_recording? && copy_task
+    elsif has_recording? && copy_task
       false
     else
-      done_recording?
+      has_recording?
     end
   end
 
-  def done_recording?
-    %w[created started recording].exclude?(status)
+  def has_recording?
+    %w[created started recording error].exclude?(status)
   end
 
   def file_name

app/models/tasks/record_stream_task.rb

@@ -67,6 +67,9 @@ def update_owner
       stream_resource.tasks.fix_media.update_all(status: :cancelled)
       stream_resource.copy_media
     end
+  rescue => err
+    Rails.logger.error("RecordStreamTask update_owner error", error: err)
+    NewRelic::Agent.notice_error(err)
   end
 
   # parsing data from the job_id

test/models/tasks/record_stream_task_test.rb

@@ -166,6 +166,37 @@
         end
       end
     end
+
+    it "handles recording errors" do
+      new_res = StreamResource.new(start_at: "2026-09-09T10:00:00Z", end_at: "2026-09-09T11:00:00Z")
+      task.owner = new_res
+      task.update(status: "error")
+
+      assert new_res.persisted?
+      assert_equal new_res.status, "error"
+      assert_nil new_res.actual_start_at
+      assert_nil new_res.actual_end_at
+    end
+
+    it "logs validation errors" do
+      mock_log = Minitest::Mock.new.expect(:call, nil) { true }
+      mock_notice = Minitest::Mock.new.expect(:call, nil) { true }
+
+      Rails.logger.stub(:error, mock_log) do
+        NewRelic::Agent.stub(:notice_error, mock_notice) do
+          new_res = StreamResource.new(start_at: "2026-09-09T10:00:00Z", end_at: nil)
+          task.owner = new_res
+          task.update(status: "error")
+
+          assert_equal "error", task.status
+          refute task.changed?
+          refute new_res.persisted?
+        end
+      end
+
+      mock_log.verify
+      mock_notice.verify
+    end
   end
 
   describe "#job_id_parts" do