Merge pull request #1459 from PRX/rename-aud-env-var

Rename AUD env var

Author: kookster

app/models/apple/api.rb

@@ -34,7 +34,7 @@ def self.api_base
     end
 
     def self.api_aud_name
-      ENV["APPLE_PODCASTS_CONNECT_AUD_NAME"]
+      ENV["APPLE_PODCASTS_CONNECT_API_AUD_NAME"]
     end
 
     def self.from_key(apple_key)

test/models/apple/api_test.rb

@@ -25,13 +25,19 @@
     payload = decoded.first
 
     assert_equal payload["iss"], provider_id
+    assert_equal payload["aud"], "aardvark"
     assert Time.at(payload["exp"]).utc.to_datetime > Time.now.utc + 14.minutes
 
     algo = decoded.second
 
     assert_equal algo, "typ" => "JWT", "alg" => "ES256", "kid" => key_id
   end
 
+  it "includes the aud from the environment variable" do
+    assert_equal "aardvark", Apple::Api.api_aud_name
+    assert_equal ENV["APPLE_PODCASTS_CONNECT_API_AUD_NAME"], Apple::Api.api_aud_name
+  end
+
   describe "#local_api_retry_errors" do
     it "local api attempts exhausts retries until failure" do
       attempts = 0

test/test_helper.rb

@@ -24,6 +24,7 @@
 ENV["ACTIVE_RECORD_ENCRYPTION_KEY_DERIVATION_SALT"] = "maybeyouarefeelingsaltyaboutthis"
 ENV["PODPING_AUTH_TOKEN"] = "test_token"
 ENV["APPLE_PODCASTS_CONNECT_API_URL"] = "https://aardvark.prx.org/"
+ENV["APPLE_PODCASTS_CONNECT_API_AUD_NAME"] = "aardvark"
 
 ENV["RAILS_ENV"] ||= "test"
 require_relative "../config/environment"