🩹 [Patch]: Refactor GitHub connection logging to improve clarity and reduce output noise

MariusStorhaug · MariusStorhaug · commit b425329bf67c · 2025-01-04T22:44:55.000+01:00
diff --git a/scripts/main.ps1 b/scripts/main.ps1
@@ -63,13 +63,13 @@ LogGroup 'GitHub-Script - Installed modules' {
 }
 
 if ($providedClientID -and $providedPrivateKey) {
-    LogGroup "$(Connect-GitHub -ClientID $env:GITHUB_ACTION_INPUT_ClientID -PrivateKey $env:GITHUB_ACTION_INPUT_PrivateKey)" {
-        Write-Host 'GitHub-Script - Connected using provided GitHub App'
+    LogGroup 'GitHub-Script - Connected using provided GitHub App' {
+        Connect-GitHub -ClientID $env:GITHUB_ACTION_INPUT_ClientID -PrivateKey $env:GITHUB_ACTION_INPUT_PrivateKey -Silent
         Get-GitHubContext | Select-Object -Property * | Format-List
     }
 } elseif ($providedToken) {
-    LogGroup "$(Connect-GitHub -Token $env:GITHUB_ACTION_INPUT_Token)" {
-        Write-Host 'GitHub-Script - Connected using provided token'
+    LogGroup 'GitHub-Script - Connected using provided token' {
+        Connect-GitHub -Token $env:GITHUB_ACTION_INPUT_Token -Silent
         Get-GitHubContext | Select-Object -Property * | Format-List
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -63,13 +63,13 @@ LogGroup 'GitHub-Script - Installed modules' {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`if ($providedClientID -and $providedPrivateKey) {`
`66`		`- LogGroup "$(Connect-GitHub -ClientID $env:GITHUB_ACTION_INPUT_ClientID -PrivateKey $env:GITHUB_ACTION_INPUT_PrivateKey)" {`
`67`		`- Write-Host 'GitHub-Script - Connected using provided GitHub App'`
	`66`	`+ LogGroup 'GitHub-Script - Connected using provided GitHub App' {`
	`67`	`+ Connect-GitHub -ClientID $env:GITHUB_ACTION_INPUT_ClientID -PrivateKey $env:GITHUB_ACTION_INPUT_PrivateKey -Silent`
`68`	`68`	`Get-GitHubContext \| Select-Object -Property * \| Format-List`
`69`	`69`	`}`
`70`	`70`	`} elseif ($providedToken) {`
`71`		`- LogGroup "$(Connect-GitHub -Token $env:GITHUB_ACTION_INPUT_Token)" {`
`72`		`- Write-Host 'GitHub-Script - Connected using provided token'`
	`71`	`+ LogGroup 'GitHub-Script - Connected using provided token' {`
	`72`	`+ Connect-GitHub -Token $env:GITHUB_ACTION_INPUT_Token -Silent`
`73`	`73`	`Get-GitHubContext \| Select-Object -Property * \| Format-List`
`74`	`74`	`}`
`75`	`75`	`}`