Commit 5bde93c
authored
## Description
This pull request removes the `AppID` property from the `GitHubApp`
class and eliminates its usage throughout the codebase. The changes help
simplify the class structure and ensure consistency in object
construction.
Class structure simplification:
* Removed the `AppID` property from the `GitHubApp` class definition in
`src/classes/public/App/GitHubApp.ps1`.
* Removed assignment of `AppID` in the `GitHubApp` constructor in
`src/classes/public/App/GitHubApp.ps1`.
Object construction consistency:
* Removed the `app_id` property when creating `GitHubApp` objects in
both constructors of the `GitHubAppInstallation` class in
`src/classes/public/App/GitHubAppInstallation.ps1`.
[[1]](diffhunk://#diff-c1442a9fa3e51d2f0bf378039e97400122a24423d72d534112ca6f7c06a5ffaeL54)
[[2]](diffhunk://#diff-c1442a9fa3e51d2f0bf378039e97400122a24423d72d534112ca6f7c06a5ffaeL94)
## Type of change
<!-- Use the check-boxes [x] on the options that are relevant. -->
- [ ] 📖 [Docs]
- [ ] 🪲 [Fix]
- [ ] 🩹 [Patch]
- [ ] ⚠️ [Security fix]
- [x] 🚀 [Feature]
- [ ] 🌟 [Breaking change]
## Checklist
<!-- Use the check-boxes [x] on the options that are relevant. -->
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
1 parent e66d934 commit 5bde93c
File tree
2 files changed
+0
-6
lines changed- src/classes/public/App
2 files changed
+0
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | 8 | | |
12 | 9 | | |
13 | 10 | | |
| |||
49 | 46 | | |
50 | 47 | | |
51 | 48 | | |
52 | | - | |
53 | 49 | | |
54 | 50 | | |
55 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
91 | 90 | | |
92 | 91 | | |
93 | 92 | | |
94 | | - | |
95 | 93 | | |
96 | 94 | | |
97 | 95 | | |
| |||
0 commit comments