Improve error handling (#84)

radazzouz · web-flow · commit 9b22bef40908 · 2019-07-10T11:15:37.000-04:00
* Improve error handling

* Always console.log the error

* Update package version to 1.3.1
diff --git a/CordovaDemo/platforms/ios/www/plugins/pspdfkit-cordova-ios/PSPDFKitPlugin/pspdfkit.js b/CordovaDemo/platforms/ios/www/plugins/pspdfkit-cordova-ios/PSPDFKitPlugin/pspdfkit.js
@@ -33,9 +33,10 @@ var PSPDFKitPlugin = new function() {
                         }
                     }
                     cordova.exec(function (result) {
-                        if (callback) callback(result);
+                        if (callback) callback(result, null);
                     }, function (error) {
-                        alert(error);
+                        console.log(error);
+                        if (callback) callback(null, error);
                     }, 'PSPDFKitPlugin', methodName, argArray);
                 }
             })();
diff --git a/PSPDFKitPlugin/pspdfkit.js b/PSPDFKitPlugin/pspdfkit.js
@@ -32,9 +32,10 @@ var PSPDFKitPlugin = new function() {
                         }
                     }
                     cordova.exec(function (result) {
-                        if (callback) callback(result);
+                        if (callback) callback(result, null);
                     }, function (error) {
-                        alert(error);
+                        console.log(error);
+                        if (callback) callback(null, error);
                     }, 'PSPDFKitPlugin', methodName, argArray);
                 }
             })();
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pspdfkit-cordova-ios",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "PSPDFKit Cordova Plugin for iOS",
   "cordova": {
     "id": "pspdfkit-cordova-ios",
diff --git a/plugin.xml b/plugin.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<plugin id="pspdfkit-cordova-ios" version="1.3.0" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
+<plugin id="pspdfkit-cordova-ios" version="1.3.1" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
 	<engines>
 		<engine name="cordova" version=">=6.3.1"/>
 	</engines>

Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,10 @@ var PSPDFKitPlugin = new function() {`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`cordova.exec(function (result) {`
`36`		`- if (callback) callback(result);`
	`36`	`+ if (callback) callback(result, null);`
`37`	`37`	`}, function (error) {`
`38`		`- alert(error);`
	`38`	`+ console.log(error);`
	`39`	`+ if (callback) callback(null, error);`
`39`	`40`	`}, 'PSPDFKitPlugin', methodName, argArray);`
`40`	`41`	`}`
`41`	`42`	`})();`
Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,10 @@ var PSPDFKitPlugin = new function() {`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`cordova.exec(function (result) {`
`35`		`- if (callback) callback(result);`
	`35`	`+ if (callback) callback(result, null);`
`36`	`36`	`}, function (error) {`
`37`		`- alert(error);`
	`37`	`+ console.log(error);`
	`38`	`+ if (callback) callback(null, error);`
`38`	`39`	`}, 'PSPDFKitPlugin', methodName, argArray);`
`39`	`40`	`}`
`40`	`41`	`})();`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "pspdfkit-cordova-ios",`
`3`		`- "version": "1.3.0",`
	`3`	`+ "version": "1.3.1",`
`4`	`4`	`"description": "PSPDFKit Cordova Plugin for iOS",`
`5`	`5`	`"cordova": {`
`6`	`6`	`"id": "pspdfkit-cordova-ios",`