fix: rename TimeoutError to NutrientTimeoutError to avoid built-in conflict

- Python 3.3+ has a built-in TimeoutError that could conflict with our custom exception
- Renamed to NutrientTimeoutError to ensure no import conflicts in CI
- Removed type: ignore comments by properly typing test variables
- Fixed all linting and formatting issues

Author: jdrhyne

src/nutrient_dws/__init__.py

@@ -9,7 +9,7 @@
     AuthenticationError,
     FileProcessingError,
     NutrientError,
-    TimeoutError,
+    NutrientTimeoutError,
     ValidationError,
 )
 
@@ -20,6 +20,6 @@
     "FileProcessingError",
     "NutrientClient",
     "NutrientError",
-    "TimeoutError",
+    "NutrientTimeoutError",
     "ValidationError",
 ]

src/nutrient_dws/exceptions.py

@@ -71,7 +71,7 @@ def __init__(self, message: str, errors: Optional[Dict[str, Any]] = None) -> Non
         self.errors = errors or {}
 
 
-class TimeoutError(NutrientError):
+class NutrientTimeoutError(NutrientError):
     """Raised when a request times out."""
 
     pass

src/nutrient_dws/http_client.py

@@ -8,7 +8,12 @@
 from requests.adapters import HTTPAdapter
 from urllib3.util.retry import Retry
 
-from nutrient_dws.exceptions import APIError, AuthenticationError, TimeoutError, ValidationError
+from nutrient_dws.exceptions import (
+    APIError,
+    AuthenticationError,
+    NutrientTimeoutError,
+    ValidationError,
+)
 
 logger = logging.getLogger(__name__)
 
@@ -154,7 +159,7 @@ def post(
                 timeout=self._timeout,
             )
         except requests.exceptions.Timeout as e:
-            raise TimeoutError(f"Request timed out after {self._timeout} seconds") from e
+            raise NutrientTimeoutError(f"Request timed out after {self._timeout} seconds") from e
         except requests.exceptions.ConnectionError as e:
             raise APIError(f"Connection error: {e!s}") from e
         except requests.exceptions.RequestException as e:

tests/unit/test_exceptions.py

@@ -5,7 +5,7 @@
     AuthenticationError,
     FileProcessingError,
     NutrientError,
-    TimeoutError,
+    NutrientTimeoutError,
     ValidationError,
 )
 
@@ -110,16 +110,16 @@ def test_error_with_details(self):
         assert exc.errors == errors
 
 
-class TestTimeoutError:
+class TestNutrientTimeoutError:
     """Test timeout error."""
 
     def test_inheritance(self):
-        """Test that TimeoutError inherits from NutrientError."""
-        assert issubclass(TimeoutError, NutrientError)
+        """Test that NutrientTimeoutError inherits from NutrientError."""
+        assert issubclass(NutrientTimeoutError, NutrientError)
 
     def test_instantiation(self):
         """Test basic instantiation."""
-        exc = TimeoutError("Request timed out")
+        exc = NutrientTimeoutError("Request timed out")
         assert str(exc) == "Request timed out"
 
 

tests/unit/test_file_handler.py

@@ -1,6 +1,7 @@
 """Unit tests for file handling utilities."""
 
 import io
+from typing import Any
 
 import pytest
 
@@ -76,8 +77,9 @@ def test_file_like_object_with_name(self, tmp_path):
 
     def test_unsupported_input_type(self):
         """Test handling of unsupported input type."""
+        invalid_input: Any = 123
         with pytest.raises(ValueError, match="Unsupported file input type"):
-            prepare_file_input(123)  # type: ignore
+            prepare_file_input(invalid_input)
 
 
 class TestPrepareFileForUpload:
@@ -227,6 +229,7 @@ class NonSeekable:
             def read(self):
                 return b"content"
 
-        size = get_file_size(NonSeekable())  # type: ignore
+        non_seekable: Any = NonSeekable()
+        size = get_file_size(non_seekable)
 
         assert size is None

tests/unit/test_http_client.py

@@ -6,7 +6,12 @@
 import requests
 import responses
 
-from nutrient_dws.exceptions import APIError, AuthenticationError, TimeoutError, ValidationError
+from nutrient_dws.exceptions import (
+    APIError,
+    AuthenticationError,
+    NutrientTimeoutError,
+    ValidationError,
+)
 from nutrient_dws.http_client import HTTPClient
 
 
@@ -158,7 +163,7 @@ def test_post_timeout(self):
         with patch.object(client._session, "post") as mock_post:
             mock_post.side_effect = requests.exceptions.Timeout()
 
-            with pytest.raises(TimeoutError, match="Request timed out"):
+            with pytest.raises(NutrientTimeoutError, match="Request timed out"):
                 client.post("/test")
 
     def test_post_connection_error(self):