Skip to content

Commit a6b4b20

Browse files
author
Rad Azzouz
committed
Address feedback on PR
1 parent 9f3deb2 commit a6b4b20

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

example/lib/main.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ class _MyAppState extends State<MyApp> {
146146
iOSSettingsMenuItems:['scrollDirection', 'pageTransition', 'appearance', 'brightness', 'pageMode', 'spreadFitting'],
147147
showActionNavigationButtons: false,
148148
iOSShowActionNavigationButtonLabels: false,
149-
pageLayoutMode: 'automatic',
150-
iOSIsFirstPageAlwaysSingle: false
149+
pageLayoutMode: 'double',
150+
isFirstPageAlwaysSingle: false
151151
});
152152
} on PlatformException catch (e) {
153153
print("Failed to present document: '${e.message}'.");

ios/Classes/PspdfkitPlugin.m

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ - (PSPDFConfiguration *)configuration:(NSDictionary *)dictionary isImageDocument
135135
if (dictionary[@"isFirstPageAlwaysSingle"]) {
136136
builder.firstPageAlwaysSingle = [dictionary[@"isFirstPageAlwaysSingle"] boolValue];
137137
}
138-
if (dictionary[@"settingsMenuItems"]) {
139-
builder.settingsOptions = [self settingsOptions:dictionary[@"settingsMenuItems"]];
138+
if (dictionary[@"iOSSettingsMenuItems"]) {
139+
builder.settingsOptions = [self settingsOptions:dictionary[@"iOSSettingsMenuItems"]];
140140
}
141141
}];
142142
}
@@ -340,7 +340,6 @@ - (PSPDFSettingsOptions)settingsOptions:(nullable NSArray <NSString *> *)options
340340
}
341341

342342
PSPDFSettingsOptions finalOptions = 0;
343-
344343
for (NSString *option in options) {
345344
if ([option isEqualToString:@"scrollDirection"]) {
346345
finalOptions |= PSPDFSettingsOptionScrollDirection;
@@ -354,9 +353,12 @@ - (PSPDFSettingsOptions)settingsOptions:(nullable NSArray <NSString *> *)options
354353
finalOptions |= PSPDFSettingsOptionPageMode;
355354
} else if ([option isEqualToString:@"spreadFitting"]) {
356355
finalOptions |= PSPDFSettingsOptionSpreadFitting;
356+
} else {
357+
NSLog(@"WARNING: '%@' is an invalid settings option. It will be ignored.", option);
357358
}
358359
}
359360

361+
// If no options were passed, we use the default setting options.
360362
if (finalOptions == 0) {
361363
finalOptions = PSPDFSettingsOptionDefault;
362364
}

lib/configuration_options.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const String iOSAllowToolbarTitleChange = "allowToolbarTitleChange";
8989
const String toolbarTitle = "toolbarTitle";
9090

9191
const String androidSettingsMenuItems = "settingsMenuItems";
92-
const String iOSSettingsMenuItems = "settingsMenuItems";
92+
const String iOSSettingsMenuItems = "iOSSettingsMenuItems";
9393

9494
const String showActionNavigationButtons = "showActionNavigationButtons";
9595
const String iOSShowActionNavigationButtonLabels = "iOSShowActionNavigationButtonLabels";
@@ -98,4 +98,4 @@ const String pageLayoutMode = "pageLayoutMode";
9898
const String pageLayoutModeAutomatic = "automatic";
9999
const String pageLayoutModeSingle = "single";
100100
const String pageLayoutModeDouble = "double";
101-
const String iOSIsFirstPageAlwaysSingle = "isFirstPageAlwaysSingle";
101+
const String isFirstPageAlwaysSingle = "isFirstPageAlwaysSingle";

0 commit comments

Comments
 (0)