Add a promise to Present File. (#172)

Fix : https://github.com/PSPDFKit/react-native/issues/170

There was previously no way of knowing if a present operation was successful or not. Now we have a promise. This may alleviate issues like https://github.com/PSPDFKit/react-native/issues/158

Author: nickwinder

samples/Catalog/Catalog.windows.js

@@ -26,9 +26,9 @@ var RNFS = require("react-native-fs");
 
 import { YellowBox } from "react-native";
 YellowBox.ignoreWarnings([
-    "Warning: isMounted(...) is deprecated", // React Native bug that hopefully will be fixed soon: https://github.com/facebook/react-native/issues/18868
-    "Warning: Invalid argument supplied to oneOf" // React native windows bug. 
-    ]);
+  "Warning: isMounted(...) is deprecated", // React Native bug that hopefully will be fixed soon: https://github.com/facebook/react-native/issues/18868
+  "Warning: Invalid argument supplied to oneOf" // React native windows bug. 
+]);
 
 
 const complexSearchConfiguration = {
@@ -66,7 +66,9 @@ var examples = [
       // Present can only take files loaded in the Visual studio Project's Assets. Please use RNFS.
       // See https://docs.microsoft.com/en-us/windows/uwp/files/file-access-permissions
       var path = RNFS.MainBundlePath + "\\Assets\\pdf\\Business Report.pdf";
-      PSPDFKit.Present(path);
+      PSPDFKit.Present(path)
+        .then(() => { alert("File Opened successfully"); })
+        .catch(error => { alert(error); });
     }
   },
   {
@@ -95,8 +97,8 @@ var examples = [
       await PSPDFKitLibrary.EnqueueDocumentsInFolderPicker("MyLibrary");
       alert(
         'Searching Library for "' +
-          simpleSearch.searchString +
-          '". Please wait.'
+        simpleSearch.searchString +
+        '". Please wait.'
       );
       PSPDFKitLibrary.SearchLibrary("MyLibrary", simpleSearch)
         .then(result => {
@@ -116,8 +118,8 @@ var examples = [
       await PSPDFKitLibrary.EnqueueDocumentsInFolder("AssetsLibrary", path);
       alert(
         'Searching Library for "' +
-          complexSearchConfiguration.searchString +
-          '". Please wait.'
+        complexSearchConfiguration.searchString +
+        '". Please wait.'
       );
       PSPDFKitLibrary.SearchLibrary("AssetsLibrary", complexSearchConfiguration)
         .then(result => {
@@ -163,18 +165,18 @@ class CatalogScreen extends Component<{}> {
   }
 
   _renderRow = ({ item, separators }) => {
-        return (
-        <TouchableHighlight
-          onPress={() => {
-            item.action(this);
-          }}
-          onShowUnderlay={separators.highlight}
-          onHideUnderlay={separators.unhighlight}>
-          <View style={styles.rowContent}>
-            <Text style={styles.name}>{item.name}</Text>
-            <Text style={styles.description}>{item.description}</Text>
-          </View>
-        </TouchableHighlight>
+    return (
+      <TouchableHighlight
+        onPress={() => {
+          item.action(this);
+        }}
+        onShowUnderlay={separators.highlight}
+        onHideUnderlay={separators.unhighlight}>
+        <View style={styles.rowContent}>
+          <Text style={styles.name}>{item.name}</Text>
+          <Text style={styles.description}>{item.description}</Text>
+        </View>
+      </TouchableHighlight>
     )
   };
 }

windows/ReactNativePSPDFKit/ReactNativePSPDFKit/LibraryModule.cs

@@ -89,9 +89,9 @@ public async void EnqueueDocumentsInFolder(string libraryName, string path, IPro
 
             try
             {
-                var storageFolder = await StorageFolder.GetFolderFromPathAsync(path).AsTask().ConfigureAwait(false); ;
+                var storageFolder = await StorageFolder.GetFolderFromPathAsync(path).AsTask().ConfigureAwait(false);
                 // Queue up the PDFs in the folder for indexing.
-                await EnqueueDocuments(_libraries[libraryName], storageFolder).ConfigureAwait(false); ;
+                await EnqueueDocuments(_libraries[libraryName], storageFolder).ConfigureAwait(false);
 
                 promise.Resolve(null);
             }
@@ -131,7 +131,7 @@ await CoreApplication.MainView.Dispatcher.AwaitableRunAsync(async () => {
                 }).ConfigureAwait(false); ;
 
                 // Queue up the PDFs in the folder for indexing.
-                await EnqueueDocuments(_libraries[libraryName], folder).ConfigureAwait(false); ;
+                await EnqueueDocuments(_libraries[libraryName], folder).ConfigureAwait(false);
 
                 promise.Resolve(null);
             }

windows/ReactNativePSPDFKit/ReactNativePSPDFKit/PSPDFKitModule.cs

@@ -14,7 +14,6 @@
 using System.Reflection;
 using System.Threading.Tasks;
 using Windows.Storage;
-using Windows.UI.Popups;
 
 namespace ReactNativePSPDFKit
 {
@@ -51,9 +50,13 @@ public void OpenFilePicker()
         /// Open a file from a path presented from javascript.
         /// Files loaded in the Visual studio Project's Assets.
         /// See https://docs.microsoft.com/en-us/windows/uwp/files/file-access-permissions
+        ///
+        /// Promise will resolve is the file opened correctly. Errors will also be propagated
+        /// to the promise.
+        /// 
         /// </summary>
         [ReactMethod]
-        public void Present(string assetPath)
+        public void Present(string assetPath, IPromise promise)
         {
             DispatcherHelpers.RunOnDispatcher(async () =>
             {
@@ -62,11 +65,12 @@ public void Present(string assetPath)
                     var file = await StorageFile.GetFileFromPathAsync(assetPath);
 
                     await LoadFileAsync(file);
+
+                    promise.Resolve(null);
                 }
                 catch (Exception e)
                 {
-                    var dialog = new MessageDialog("Unable to open the file specified.");
-                    await dialog.ShowAsync();
+                    promise.Reject(e);
                 }
             });
         }
@@ -75,7 +79,7 @@ public void Present(string assetPath)
         /// Opens the native file picker.
         /// </summary>
         /// <returns>The file chosen in the file picker.</returns>
-        private static async Task<Windows.Storage.StorageFile> PickPDF()
+        private static async Task<StorageFile> PickPDF()
         {
             var picker = new Windows.Storage.Pickers.FileOpenPicker
             {
@@ -91,7 +95,7 @@ public void Present(string assetPath)
         /// Call to the PDFView to open a file. Fails if file is null.
         /// </summary>
         /// <param name="file">File to open</param>
-        private async Task LoadFileAsync(Windows.Storage.StorageFile file)
+        private async Task LoadFileAsync(StorageFile file)
         {
             if (file == null) return;
 

windows/ReactNativePSPDFKit/ReactNativePSPDFKit/PSPDFKitViewManager.cs

@@ -9,13 +9,11 @@
 
 using System;
 using System.Collections.Generic;
-using System.Threading.Tasks;
 using Windows.Data.Json;
 using ReactNative.UIManager;
 using ReactNative.UIManager.Annotations;
 using Windows.Storage;
 using Newtonsoft.Json.Linq;
-using PSPDFKit.Pdf;
 using PSPDFKit.Pdf.Annotation;
 using PSPDFKit.UI;
 using ReactNativePSPDFKit.Events;
@@ -44,7 +42,7 @@ protected override PDFViewPage CreateViewInstance(ThemedReactContext reactContex
         public override string Name => "RCTPSPDFKitView";
 
         [ReactProp("document")]
-        public async void SetDocumentAsync(PDFViewPage view, String document)
+        public async void SetDocumentAsync(PDFViewPage view, string document)
         {
             var storagefile = await StorageFile.GetFileFromApplicationUriAsync(new Uri(document));
             await view.SetDefaultDocument(storagefile);