Add return values for remaining methods

enterAnnotationCreationMode, exitCurrentlyActiveMode, and saveCurrentDocument

Author: RadAzzouz

index.js

@@ -97,7 +97,7 @@ class PSPDFKitView extends React.Component {
         []
       );
     } else if (Platform.OS === "ios") {
-      NativeModules.PSPDFKitViewManager.enterAnnotationCreationMode(
+      return NativeModules.PSPDFKitViewManager.enterAnnotationCreationMode(
         findNodeHandle(this.refs.pdfView)
       );
     }
@@ -114,7 +114,7 @@ class PSPDFKitView extends React.Component {
         []
       );
     } else if (Platform.OS === "ios") {
-      NativeModules.PSPDFKitViewManager.exitCurrentlyActiveMode(
+      return NativeModules.PSPDFKitViewManager.exitCurrentlyActiveMode(
         findNodeHandle(this.refs.pdfView)
       );
     }
@@ -131,7 +131,7 @@ class PSPDFKitView extends React.Component {
         []
       );
     } else if (Platform.OS === "ios") {
-      NativeModules.PSPDFKitViewManager.saveCurrentDocument(
+      return NativeModules.PSPDFKitViewManager.saveCurrentDocument(
         findNodeHandle(this.refs.pdfView)
       );
     }

ios/RCTPSPDFKit/RCTPSPDFKitView.h

@@ -29,11 +29,11 @@
 @property (nonatomic, copy) RCTBubblingEventBlock onStateChanged;
 
 /// Annotation Toolbar
-- (void)enterAnnotationCreationMode;
-- (void)exitCurrentlyActiveMode;
+- (BOOL)enterAnnotationCreationMode;
+- (BOOL)exitCurrentlyActiveMode;
 
 /// Document
-- (void)saveCurrentDocument;
+- (BOOL)saveCurrentDocument;
 
 /// Anotations
 - (NSDictionary<NSString *, NSArray<NSDictionary *> *> *)getAnnotations:(PSPDFPageIndex)pageIndex type:(PSPDFAnnotationType)type;

ios/RCTPSPDFKit/RCTPSPDFKitView.m

@@ -105,18 +105,18 @@ - (UIViewController *)pspdf_parentViewController {
   return nil;
 }
 
-- (void)enterAnnotationCreationMode {
+- (BOOL)enterAnnotationCreationMode {
   [self.pdfController setViewMode:PSPDFViewModeDocument animated:YES];
   [self.pdfController.annotationToolbarController updateHostView:nil container:nil viewController:self.pdfController];
-  [self.pdfController.annotationToolbarController showToolbarAnimated:YES];
+  return [self.pdfController.annotationToolbarController showToolbarAnimated:YES];
 }
 
-- (void)exitCurrentlyActiveMode {
-  [self.pdfController.annotationToolbarController hideToolbarAnimated:YES];
+- (BOOL)exitCurrentlyActiveMode {
+  return [self.pdfController.annotationToolbarController hideToolbarAnimated:YES];
 }
 
-- (void)saveCurrentDocument {
-  [self.pdfController.document saveWithOptions:nil error:NULL];
+- (BOOL)saveCurrentDocument {
+  return [self.pdfController.document saveWithOptions:nil error:NULL];
 }
 
 #pragma mark - PSPDFDocumentDelegate
@@ -249,7 +249,7 @@ - (BOOL)addAnnotations:(id)jsonAnnotations {
   if ([jsonAnnotations isKindOfClass:NSString.class]) {
     data = [jsonAnnotations dataUsingEncoding:NSUTF8StringEncoding];
   } else if ([jsonAnnotations isKindOfClass:NSDictionary.class])  {
-    data = [NSJSONSerialization dataWithJSONObject:jsonAnnotations options:0 error:nil];;
+    data = [NSJSONSerialization dataWithJSONObject:jsonAnnotations options:0 error:nil];
   } else {
     NSLog(@"Invalid JSON Annotations.");
     return NO;

ios/RCTPSPDFKit/RCTPSPDFKitViewManager.m

@@ -76,24 +76,39 @@ @implementation RCTPSPDFKitViewManager
 
 RCT_EXPORT_VIEW_PROPERTY(onStateChanged, RCTBubblingEventBlock)
 
-RCT_EXPORT_METHOD(enterAnnotationCreationMode:(nonnull NSNumber *)reactTag) {
+RCT_EXPORT_METHOD(enterAnnotationCreationMode:(nonnull NSNumber *)reactTag resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
   dispatch_async(dispatch_get_main_queue(), ^{
     RCTPSPDFKitView *component = (RCTPSPDFKitView *)[self.bridge.uiManager viewForReactTag:reactTag];
-    [component enterAnnotationCreationMode];
+    BOOL success = [component enterAnnotationCreationMode];
+    if (success) {
+      resolve(@(success));
+    } else {
+      reject(@"error", @"Failed to enter annotation creation mode.", nil);
+    }
   });
 }
 
-RCT_EXPORT_METHOD(exitCurrentlyActiveMode:(nonnull NSNumber *)reactTag) {
+RCT_EXPORT_METHOD(exitCurrentlyActiveMode:(nonnull NSNumber *)reactTag resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
   dispatch_async(dispatch_get_main_queue(), ^{
     RCTPSPDFKitView *component = (RCTPSPDFKitView *)[self.bridge.uiManager viewForReactTag:reactTag];
-    [component exitCurrentlyActiveMode];
+    BOOL success = [component exitCurrentlyActiveMode];
+    if (success) {
+      resolve(@(success));
+    } else {
+      reject(@"error", @"Failed to exit annotation creation mode.", nil);
+    }
   });
 }
 
-RCT_EXPORT_METHOD(saveCurrentDocument:(nonnull NSNumber *)reactTag) {
+RCT_EXPORT_METHOD(saveCurrentDocument:(nonnull NSNumber *)reactTag resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
   dispatch_async(dispatch_get_main_queue(), ^{
     RCTPSPDFKitView *component = (RCTPSPDFKitView *)[self.bridge.uiManager viewForReactTag:reactTag];
-    [component saveCurrentDocument];
+    BOOL success = [component saveCurrentDocument];
+    if (success) {
+      resolve(@(success));
+    } else {
+      reject(@"error", @"Failed to save document.", nil);
+    }
   });
 }