Skip to content

Commit 6587a25

Browse files
authored
Merge pull request #131 from PSPDFKit/ios-8.0
Update for PSPDFKit 8 for iOS
2 parents 14023e5 + 6ae5e06 commit 6587a25

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ The [PSPDFKit SDK](https://pspdfkit.com/) is a framework that allows you to view
2222

2323
#### Requirements
2424

25-
- Xcode 9.4.1
26-
- PSPDFKit 7.6.1 for iOS or later
25+
- Xcode 10
26+
- PSPDFKit 8.0 for iOS or later
2727
- react-native >= 0.55.4
2828

2929
#### Getting Started

ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFConfiguration.m

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ + (PSPDFConfiguration *)PSPDFConfiguration:(id)json {
170170
PSPDFAnnotationString const PSPDFAnnotationStringWatermark = @"Watermark";
171171
PSPDFAnnotationString const PSPDFAnnotationStringTrapNet = @"TrapNet";
172172
PSPDFAnnotationString const PSPDFAnnotationString3D = @"3D";
173-
PSPDFAnnotationString const PSPDFAnnotationStringRedact = @"Redact";
173+
PSPDFAnnotationString const PSPDFAnnotationStringRedaction = @"Redact";
174174
*/
175175

176176
RCT_MULTI_ENUM_CONVERTER(PSPDFAnnotationType,
@@ -200,7 +200,7 @@ + (PSPDFConfiguration *)PSPDFConfiguration:(id)json {
200200
PSPDFAnnotationStringWatermark : @(PSPDFAnnotationTypeWatermark),
201201
PSPDFAnnotationStringTrapNet : @(PSPDFAnnotationTypeTrapNet),
202202
PSPDFAnnotationString3D : @(PSPDFAnnotationTypeThreeDimensional),
203-
PSPDFAnnotationStringRedact : @(PSPDFAnnotationTypeRedact),
203+
PSPDFAnnotationStringRedaction : @(PSPDFAnnotationTypeRedaction),
204204
@"all" : @(PSPDFAnnotationTypeAll)}),
205205
PSPDFAnnotationTypeNone,
206206
unsignedIntegerValue)
@@ -223,20 +223,20 @@ + (PSPDFConfiguration *)PSPDFConfiguration:(id)json {
223223
PSPDFAppearanceModeDefault,
224224
unsignedIntegerValue)
225225

226-
RCT_MULTI_ENUM_CONVERTER(PSPDFDocumentSharingOptions,
227-
(@{@"none" : @(PSPDFDocumentSharingOptionNone),
228-
@"currentPageOnly" : @(PSPDFDocumentSharingOptionCurrentPageOnly),
229-
@"pageRange" : @(PSPDFDocumentSharingOptionPageRange),
230-
@"allPages" : @(PSPDFDocumentSharingOptionAllPages),
231-
@"annotatedPages" : @(PSPDFDocumentSharingOptionAnnotatedPages),
232-
@"embedAnnotations" : @(PSPDFDocumentSharingOptionEmbedAnnotations),
233-
@"flattenAnnotations" : @(PSPDFDocumentSharingOptionFlattenAnnotations),
234-
@"annotationsSummary" : @(PSPDFDocumentSharingOptionAnnotationsSummary),
235-
@"removeAnnotations" : @(PSPDFDocumentSharingOptionRemoveAnnotations),
236-
@"originalFile" : @(PSPDFDocumentSharingOptionOriginalFile),
237-
@"image" : @(PSPDFDocumentSharingOptionImage)}),
238-
PSPDFDocumentSharingOptionNone,
239-
unsignedIntegerValue)
226+
//RCT_MULTI_ENUM_CONVERTER(PSPDFDocumentSharingOptions,
227+
// (@{@"none" : @(PSPDFDocumentSharingOptionNone),
228+
// @"currentPageOnly" : @(PSPDFDocumentSharingOptionCurrentPageOnly),
229+
// @"pageRange" : @(PSPDFDocumentSharingOptionPageRange),
230+
// @"allPages" : @(PSPDFDocumentSharingOptionAllPages),
231+
// @"annotatedPages" : @(PSPDFDocumentSharingOptionAnnotatedPages),
232+
// @"embedAnnotations" : @(PSPDFDocumentSharingOptionEmbedAnnotations),
233+
// @"flattenAnnotations" : @(PSPDFDocumentSharingOptionFlattenAnnotations),
234+
// @"annotationsSummary" : @(PSPDFDocumentSharingOptionAnnotationsSummary),
235+
// @"removeAnnotations" : @(PSPDFDocumentSharingOptionRemoveAnnotations),
236+
// @"originalFile" : @(PSPDFDocumentSharingOptionOriginalFile),
237+
// @"image" : @(PSPDFDocumentSharingOptionImage)}),
238+
// PSPDFDocumentSharingOptionNone,
239+
// unsignedIntegerValue)
240240

241241
RCT_MULTI_ENUM_CONVERTER(PSPDFSettingsOptions,
242242
(@{@"none" : @(PSPDFSettingsOptionNone),
@@ -336,10 +336,10 @@ - (void)setupFromJSON:(id)json {
336336
SET(showForwardActionButton, BOOL)
337337
SET(showBackForwardActionButtonLabels, BOOL)
338338
// currently unsupported: SET(*applicationActivities, NSArray)
339-
SET(printSharingOptions, PSPDFDocumentSharingOptions)
340-
SET(openInSharingOptions, PSPDFDocumentSharingOptions)
341-
SET(mailSharingOptions, PSPDFDocumentSharingOptions)
342-
SET(messageSharingOptions, PSPDFDocumentSharingOptions)
339+
// SET(printSharingOptions, PSPDFDocumentSharingOptions)
340+
// SET(openInSharingOptions, PSPDFDocumentSharingOptions)
341+
// SET(mailSharingOptions, PSPDFDocumentSharingOptions)
342+
// SET(messageSharingOptions, PSPDFDocumentSharingOptions)
343343
SET(settingsOptions, PSPDFSettingsOptions)
344344
SET(editableAnnotationTypes, NSSet)
345345
}

ios/cocoapods.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
### CocoaPods integration
44

55
#### Requirements
6-
- Xcode 9.4.1
7-
- PSPDFKit 7.6.1 for iOS or later
6+
- Xcode 10
7+
- PSPDFKit 8.0 for iOS or later
88
- react-native >= 0.55.4
99
- CocoaPods >= 1.5.3
1010

0 commit comments

Comments
 (0)