Skip to content

Commit 9585e22

Browse files
authored
Merge pull request #16 from PSPDFKit/simone/issue/upgrade-react-native-0.45.1
Upgrade Android to React Native 0.45.1
2 parents dc437ac + 111029d commit 9585e22

File tree

18 files changed

+750
-317
lines changed

18 files changed

+750
-317
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ PSPDFKit.present('document.pdf', {
111111
- Android SDK
112112
- Android Build Tools 23.0.1 (React Native)
113113
- Android Build Tools 25.0.2 (PSPDFKit module)
114-
- PSPDFKit >= 3.0.0
115-
- react-native >= 0.41.2
114+
- PSPDFKit >= 3.2.0
115+
- react-native >= 0.45.1
116116

117117
#### Getting Started
118118

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Contains gradle configuration constants
33
*/
44
ext {
5-
PSPDFKIT_VERSION = '3.0.0'
5+
PSPDFKIT_VERSION = '3.2.0'
66
}
77

88
buildscript {

android/src/main/AndroidManifest.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
3+
~ AndroidManifest.xml
4+
~
5+
~ PSPDFKit
6+
~
7+
~ Copyright © 2017 PSPDFKit GmbH. All rights reserved.
8+
~
9+
~ THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
10+
~ AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.
11+
~ UNAUTHORIZED REPRODUCTION OR DISTRIBUTION IS SUBJECT TO CIVIL AND CRIMINAL PENALTIES.
12+
~ This notice may not be removed from this file.
13+
-->
14+
115
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
216
package="com.pspdfkit.react"
317
android:versionCode="1"

android/src/main/java/com/pspdfkit/react/ConfigurationAdapter.java

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/*
2-
* ConfigurationAdapter.java
2+
* ConfigurationAdapter.java
3+
*
34
* PSPDFKit
45
*
5-
* Copyright (c) 2014-2016 PSPDFKit GmbH. All rights reserved.
6+
* Copyright © 2017 PSPDFKit GmbH. All rights reserved.
67
*
78
* THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
89
* AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.
@@ -20,7 +21,7 @@
2021
import com.facebook.react.bridge.ReadableMapKeySetIterator;
2122
import com.pspdfkit.configuration.activity.HudViewMode;
2223
import com.pspdfkit.configuration.activity.PdfActivityConfiguration;
23-
import com.pspdfkit.configuration.annotations.AnnotationEditingConfiguration;
24+
import com.pspdfkit.configuration.activity.ThumbnailBarMode;
2425
import com.pspdfkit.configuration.page.PageFitMode;
2526
import com.pspdfkit.configuration.page.PageScrollDirection;
2627
import com.pspdfkit.configuration.page.PageScrollMode;
@@ -40,6 +41,9 @@ public class ConfigurationAdapter {
4041
private static final String SHOW_SEARCH_ACTION = "showSearchAction";
4142
private static final String INLINE_SEARCH = "inlineSearch";
4243
private static final String SHOW_THUMBNAIL_BAR = "showThumbnailBar";
44+
private static final String SHOW_THUMBNAIL_BAR_DEFAULT = "default";
45+
private static final String SHOW_THUMBNAIL_BAR_SCROLLABLE = "scrollable";
46+
private static final String SHOW_THUMBNAIL_BAR_NONE = "none";
4347
private static final String SHOW_THUMBNAIL_GRID_ACTION = "showThumbnailGridAction";
4448
private static final String SHOW_OUTLINE_ACTION = "showOutlineAction";
4549
private static final String SHOW_ANNOTATION_LIST_ACTION = "showAnnotationListAction";
@@ -91,9 +95,6 @@ public ConfigurationAdapter(@NonNull Activity activity, ReadableMap configuratio
9195
if (configuration.hasKey(IMMERSIVE_MODE)) {
9296
configureImmersiveMode(configuration.getBoolean(IMMERSIVE_MODE));
9397
}
94-
if (configuration.hasKey(SHOW_THUMBNAIL_BAR)) {
95-
configureShowThumbnailBar(configuration.getBoolean(SHOW_THUMBNAIL_BAR));
96-
}
9798
if (configuration.hasKey(SHOW_THUMBNAIL_GRID_ACTION)) {
9899
configureShowThumbnailGridAction(configuration.getBoolean(SHOW_THUMBNAIL_GRID_ACTION));
99100
}
@@ -127,6 +128,9 @@ public ConfigurationAdapter(@NonNull Activity activity, ReadableMap configuratio
127128
if (configuration.hasKey(ENABLE_TEXT_SELECTION)) {
128129
configureEnableTextSelection(configuration.getBoolean(ENABLE_TEXT_SELECTION));
129130
}
131+
if (configuration.hasKey(SHOW_THUMBNAIL_BAR)) {
132+
configureShowThumbnailBar(configuration.getString(SHOW_THUMBNAIL_BAR));
133+
}
130134
}
131135
}
132136

@@ -191,12 +195,16 @@ private void configureImmersiveMode(boolean immersiveMode) {
191195
configuration.useImmersiveMode(immersiveMode);
192196
}
193197

194-
private void configureShowThumbnailBar(boolean showThumbnailBar) {
195-
if (showThumbnailBar) {
196-
configuration.showThumbnailBar();
197-
} else {
198-
configuration.hideThumbnailBar();
198+
private void configureShowThumbnailBar(String showThumbnailBar) {
199+
ThumbnailBarMode thumbnailBarMode = ThumbnailBarMode.THUMBNAIL_BAR_MODE_DEFAULT;
200+
if (showThumbnailBar.equals(SHOW_THUMBNAIL_BAR_DEFAULT)) {
201+
thumbnailBarMode = ThumbnailBarMode.THUMBNAIL_BAR_MODE_DEFAULT;
202+
} else if (showThumbnailBar.equals(SHOW_THUMBNAIL_BAR_SCROLLABLE)) {
203+
thumbnailBarMode = ThumbnailBarMode.THUMBNAIL_BAR_MODE_SCROLLABLE;
204+
} else if (showThumbnailBar.equals(SHOW_THUMBNAIL_BAR_NONE)) {
205+
thumbnailBarMode = ThumbnailBarMode.THUMBNAIL_BAR_MODE_NONE;
199206
}
207+
configuration.setThumbnailBarMode(thumbnailBarMode);
200208
}
201209

202210
private void configureShowThumbnailGridAction(boolean showThumbnailGridAction) {
@@ -240,13 +248,11 @@ private void configureInvertColors(boolean invertColors) {
240248
}
241249

242250
private void configureEnableAnnotationEditing(boolean enableAnnotationEditing) {
243-
AnnotationEditingConfiguration.Builder annotationEditingConfiguration = new AnnotationEditingConfiguration.Builder(activity);
244251
if (enableAnnotationEditing) {
245-
annotationEditingConfiguration.enableAnnotationEditing();
252+
configuration.enableAnnotationEditing();
246253
} else {
247-
annotationEditingConfiguration.disableAnnotationEditing();
254+
configuration.disableAnnotationEditing();
248255
}
249-
configuration.annotationEditingConfiguration(annotationEditingConfiguration.build());
250256
}
251257

252258
private void configureShowShareAction(boolean showShareAction) {
@@ -280,6 +286,7 @@ public static PdfActivityConfiguration.Builder getDefaultConfiguration(Context c
280286
final PageFitMode pageFitMode = PageFitMode.FIT_TO_WIDTH;
281287
final int searchType = PdfActivityConfiguration.SEARCH_INLINE;
282288
final HudViewMode hudViewMode = HudViewMode.HUD_VIEW_MODE_AUTOMATIC;
289+
final ThumbnailBarMode thumbnailBarMode = ThumbnailBarMode.THUMBNAIL_BAR_MODE_DEFAULT;
283290
int startPage = 0;
284291

285292
PdfActivityConfiguration.Builder configuration = new PdfActivityConfiguration.Builder(context)
@@ -288,10 +295,9 @@ public static PdfActivityConfiguration.Builder getDefaultConfiguration(Context c
288295
.fitMode(pageFitMode)
289296
.setHudViewMode(hudViewMode)
290297
.setSearchType(searchType)
298+
.setThumbnailBarMode(thumbnailBarMode)
291299
.page(startPage);
292300

293-
AnnotationEditingConfiguration.Builder annotationEditingConfiguration = new AnnotationEditingConfiguration.Builder(context);
294-
configuration.annotationEditingConfiguration(annotationEditingConfiguration.build());
295301
return configuration;
296302
}
297303
}

android/src/main/java/com/pspdfkit/react/MainActivity.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/*
2-
* MainActivity.java
2+
* MainActivity.java
3+
*
34
* PSPDFKit
45
*
5-
* Copyright (c) 2014-2016 PSPDFKit GmbH. All rights reserved.
6+
* Copyright © 2017 PSPDFKit GmbH. All rights reserved.
67
*
78
* THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
89
* AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.

android/src/main/java/com/pspdfkit/react/MainApplication.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/*
2-
* MainApplication.java
2+
* MainApplication.java
3+
*
34
* PSPDFKit
45
*
5-
* Copyright (c) 2014-2016 PSPDFKit GmbH. All rights reserved.
6+
* Copyright © 2017 PSPDFKit GmbH. All rights reserved.
67
*
78
* THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
89
* AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.

android/src/main/java/com/pspdfkit/react/PSPDFKitModule.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/*
2-
* PSPDFKitModule.java
2+
* PSPDFKitModule.java
3+
*
34
* PSPDFKit
45
*
5-
* Copyright (c) 2014-2016 PSPDFKit GmbH. All rights reserved.
6+
* Copyright © 2017 PSPDFKit GmbH. All rights reserved.
67
*
78
* THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
89
* AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.

android/src/main/java/com/pspdfkit/react/PSPDFKitPackage.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/*
2-
* PSPDFKitPackage.java
2+
* PSPDFKitPackage.java
3+
*
34
* PSPDFKit
45
*
5-
* Copyright (c) 2014-2016 PSPDFKit GmbH. All rights reserved.
6+
* Copyright © 2017 PSPDFKit GmbH. All rights reserved.
67
*
78
* THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
89
* AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.

package.json

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
11
{
22
"name": "react-native-pspdfkit",
3-
"version": "1.1.0",
3+
"version": "1.2.0",
44
"description": "A React Native module for the PSPDFKit library.",
5-
"keywords": ["react native", "pspdfkit", "pdf"],
5+
"keywords": [
6+
"react native",
7+
"pspdfkit",
8+
"pdf"
9+
],
610
"homepage": "https://github.com/PSPDFKit/react-native",
711
"bugs": {
8-
"url" : "https://github.com/PSPDFKit/react-native/issues",
9-
"email" : "[email protected]"
12+
"url": "https://github.com/PSPDFKit/react-native/issues",
13+
"email": "[email protected]"
1014
},
11-
"license" : "SEE LICENSE IN LICENSE",
15+
"license": "SEE LICENSE IN LICENSE",
1216
"main": "js/index.js",
1317
"repository": {
1418
"type": "git",
@@ -18,7 +22,7 @@
1822
"start": "node node_modules/react-native/local-cli/cli.js start"
1923
},
2024
"dependencies": {
21-
"react": ">=15.4.2",
22-
"react-native": ">=0.41.2"
25+
"react": "^16.0.0-alpha.12",
26+
"react-native": "^0.45.1"
2327
}
2428
}

samples/Catalog/android/app/src/main/AndroidManifest.xml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
3+
~ AndroidManifest.xml
4+
~
5+
~ PSPDFKit
6+
~
7+
~ Copyright © 2017 PSPDFKit GmbH. All rights reserved.
8+
~
9+
~ THIS SOURCE CODE AND ANY ACCOMPANYING DOCUMENTATION ARE PROTECTED BY INTERNATIONAL COPYRIGHT LAW
10+
~ AND MAY NOT BE RESOLD OR REDISTRIBUTED. USAGE IS BOUND TO THE PSPDFKIT LICENSE AGREEMENT.
11+
~ UNAUTHORIZED REPRODUCTION OR DISTRIBUTION IS SUBJECT TO CIVIL AND CRIMINAL PENALTIES.
12+
~ This notice may not be removed from this file.
13+
-->
14+
115
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
216
package="com.pspdfkit.react.catalog"
317
android:versionCode="1"
@@ -14,12 +28,12 @@
1428
android:name=".MainApplication"
1529
android:allowBackup="true"
1630
android:icon="@mipmap/ic_launcher"
17-
android:label="@string/app_name"
18-
android:theme="@style/PSPDFCatalog.Theme.Light">
31+
android:label="@string/app_name">
1932
<activity
2033
android:name=".MainActivity"
2134
android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
22-
android:label="@string/app_name">
35+
android:label="@string/app_name"
36+
android:theme="@style/PSPDFCatalog.Theme.Light">
2337
<intent-filter>
2438
<action android:name="android.intent.action.MAIN" />
2539
<category android:name="android.intent.category.LAUNCHER" />

0 commit comments

Comments
 (0)