Merge pull request #72 from PSPDFKit/simone/issue/upgrade-react-native-0.55.4

Upgrade to React Native 0.55.4

Author: simoarpe

README.md

@@ -247,8 +247,8 @@ editableAnnotationTypes: ['Ink', 'Highlight']
 - Android SDK
 - Android Build Tools 23.0.1 (React Native)
 - Android Build Tools 26.0.1 (PSPDFKit module)
-- PSPDFKit >= 4.4.1
-- react-native >= 0.54.2
+- PSPDFKit >= 4.6.0
+- react-native >= 0.55.4
 
 #### Getting Started
 
@@ -257,9 +257,10 @@ Let's create a simple app that integrates PSPDFKit and uses the react-native-psp
 1. Make sure `react-native-cli` is installed: `yarn global add react-native-cli`
 2. Create the app with `react-native init YourApp`.
 3. Step into your newly created app folder: `cd YourApp`.
-4. Install `react-native-pspdfkit` from GitHub: `yarn add github:PSPDFKit/react-native`.
-5. Link module `react-native-pspdfkit`: `react-native link react-native-pspdfkit`.
-6. <a id="step-6"></a>Add PSPDFKit and Google repository to `YourApp/android/build.gradle` so PSPDFKit library and Android dependencies can be downloaded:
+4. Add `react-native-pspdfkit` module from GitHub: `yarn add github:PSPDFKit/react-native`.
+5. Install all the dependencies for the project: `yarn install`. (Because of a [bug](https://github.com/yarnpkg/yarn/issues/2165) you may need to clean `yarn`'s cache with `yarn cache clean` before.)
+6. Link module `react-native-pspdfkit`: `react-native link react-native-pspdfkit`.
+7. <a id="step-6"></a>Add PSPDFKit and Google repository to `YourApp/android/build.gradle` so PSPDFKit library and Android dependencies can be downloaded:
 
   ```diff
     allprojects {
@@ -285,7 +286,7 @@ Let's create a simple app that integrates PSPDFKit and uses the react-native-psp
     }
   ```
 
-7. PSPDFKit targets modern platforms, so you'll have to update `compileSdkVersion` and `targetSdkVersion` to at least API 26 and enable MultiDex. In `YourApp/android/app/build.gradle` (note **five** places to edit):
+8. PSPDFKit targets modern platforms, so you'll have to update `compileSdkVersion` and `targetSdkVersion` to at least API 26 and enable MultiDex. In `YourApp/android/app/build.gradle` (note **five** places to edit):
 
    ```diff
    ...
@@ -311,7 +312,7 @@ Let's create a simple app that integrates PSPDFKit and uses the react-native-psp
    ...
    ```
      
-8. <a id="step-8"></a>Enter your PSPDFKit license key into `YourApp/android/app/src/main/AndroidManifest.xml` file: 
+9. <a id="step-8"></a>Enter your PSPDFKit license key into `YourApp/android/app/src/main/AndroidManifest.xml` file: 
 
   ```diff
      <application>
@@ -324,15 +325,15 @@ Let's create a simple app that integrates PSPDFKit and uses the react-native-psp
      </application> 
   ```
 
-9. Set primary color. In `YourApp/android/app/src/main/res/values/styles.xml` replace
+10. Set primary color. In `YourApp/android/app/src/main/res/values/styles.xml` replace
   ```xml    
 <!-- Customize your theme here. -->
   ```
 with
   ```xml    
 <item name="colorPrimary">#3C97C9</item>
   ```     
-10. <a id="step-10"></a>Replace the default component from `YourApp/App.js` with a simple touch area to present a PDF document from the local device filesystem:
+11. <a id="step-10"></a>Replace the default component from `YourApp/App.js` with a simple touch area to present a PDF document from the local device filesystem:
 
    ```javascript
    import React, { Component } from 'react';
@@ -403,13 +404,13 @@ with
      }
    });
    ```  
-11. Before launching the app you need to copy a PDF document onto your development device or emulator.
+12. Before launching the app you need to copy a PDF document onto your development device or emulator.
 
 	```bash
 	adb push /path/to/your/document.pdf /sdcard/document.pdf
 	```
 
-12. Your app is now ready to launch.  From `YourApp` directory run `react-native run-android`.
+13. Your app is now ready to launch.  From `YourApp` directory run `react-native run-android`.
 
 	```bash
 	react-native run-android

android/build.gradle

@@ -2,7 +2,7 @@
 *   Contains gradle configuration constants
 */
 ext {
-    PSPDFKIT_VERSION = '4.4.1'
+    PSPDFKIT_VERSION = '4.6.0'
 }
 
 buildscript {
@@ -11,7 +11,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.3.0'
+        classpath 'com.android.tools.build:gradle:2.3.1'
     }
 }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.10.0",
+  "version": "1.11.0",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",

samples/Catalog/.flowconfig

@@ -46,4 +46,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 
 [version]
-^0.65.0
+^0.67.0

samples/Catalog/.gitignore

@@ -42,3 +42,16 @@ buck-out/
 android/app/libs
 *.keystore
 
+# fastlane
+#
+# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
+# screenshots whenever they are needed.
+# For more information about the recommended setup visit:
+# https://docs.fastlane.tools/best-practices/source-control/
+
+*/fastlane/report.xml
+*/fastlane/Preview.html
+*/fastlane/screenshots
+
+# Bundle artifact
+*.jsbundle

samples/Catalog/Catalog.android.js

@@ -25,6 +25,11 @@ import { StackNavigator } from "react-navigation";
 
 import PSPDFKitView from "react-native-pspdfkit";
 
+// React Native bug that hopefully will be fixed soon:
+// https://github.com/facebook/react-native/issues/18868
+import { YellowBox } from 'react-native'
+YellowBox.ignoreWarnings(['Warning: isMounted(...) is deprecated'])
+
 var PSPDFKit = NativeModules.PSPDFKit;
 
 const pspdfkitColor = "#267AD4";

samples/Catalog/android/build.gradle

@@ -5,7 +5,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.3.0'
+        classpath 'com.android.tools.build:gradle:2.3.1'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files