Skip to content

Commit d8c1ca8

Browse files
author
irgendeinich
committed
Address review remarks
1 parent 9dbdb4b commit d8c1ca8

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

android/src/main/java/com/pspdfkit/react/ConfigurationAdapter.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@
1313

1414
package com.pspdfkit.react;
1515

16-
import android.app.Activity;
1716
import android.content.Context;
1817
import android.support.annotation.NonNull;
18+
import android.support.annotation.Nullable;
1919

2020
import com.facebook.react.bridge.ReadableMap;
2121
import com.facebook.react.bridge.ReadableMapKeySetIterator;
22-
import com.pspdfkit.configuration.activity.UserInterfaceViewMode;
2322
import com.pspdfkit.configuration.activity.PdfActivityConfiguration;
2423
import com.pspdfkit.configuration.activity.ThumbnailBarMode;
24+
import com.pspdfkit.configuration.activity.UserInterfaceViewMode;
2525
import com.pspdfkit.configuration.page.PageFitMode;
2626
import com.pspdfkit.configuration.page.PageLayoutMode;
2727
import com.pspdfkit.configuration.page.PageScrollDirection;
@@ -305,9 +305,10 @@ private void configureShowDocumentTitleOverlay(boolean showDocumentTitleOverlay)
305305
}
306306
}
307307

308-
private void configurePageMode(String pageMode) {
308+
private void configurePageMode(@Nullable final String pageMode) {
309309
PageLayoutMode pageLayoutMode = PageLayoutMode.AUTO;
310-
if (pageMode.equalsIgnoreCase(PAGE_MODE_AUTO)) {
310+
if (pageMode == null ||
311+
pageMode.equalsIgnoreCase(PAGE_MODE_AUTO)) {
311312
pageLayoutMode = PageLayoutMode.AUTO;
312313
} else if (pageMode.equalsIgnoreCase(PAGE_MODE_SINGLE)) {
313314
pageLayoutMode = PageLayoutMode.SINGLE;
@@ -317,7 +318,7 @@ private void configurePageMode(String pageMode) {
317318
configuration.layoutMode(pageLayoutMode);
318319
}
319320

320-
private void configureFirstPageAlwaysSingle(boolean firstPageAlwaysSingle) {
321+
private void configureFirstPageAlwaysSingle(final boolean firstPageAlwaysSingle) {
321322
configuration.firstPageAlwaysSingle(firstPageAlwaysSingle);
322323
}
323324

0 commit comments

Comments
 (0)