Merge pull request #280 from PSPDFKit/rad/dismiss-when-the-view-component-is-unmounted

radazzouz · web-flow · commit eb2a80fc87d1 · 2019-08-28T07:39:44.000-04:00
Dismiss the PDF view controller when the view component is unmounted to avoid orphan popovers
diff --git a/ios/RCTPSPDFKit/RCTPSPDFKitView.m b/ios/RCTPSPDFKit/RCTPSPDFKitView.m
@@ -38,6 +38,11 @@ - (instancetype)initWithFrame:(CGRect)frame {
   return self;
 }
 
+- (void)removeFromSuperview {
+  [self.pdfController dismissViewControllerAnimated:NO completion:NULL];
+  [super removeFromSuperview];
+}
+
 - (void)dealloc {
   [self destroyViewControllerRelationship];
   [NSNotificationCenter.defaultCenter removeObserver:self];
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.25.4",
+  "version": "1.25.5",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",
diff --git a/samples/Catalog/package.json b/samples/Catalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Catalog",
-  "version": "1.25.4",
+  "version": "1.25.5",
   "private": true,
   "scripts": {
     "start": "react-native start",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-native-pspdfkit",`
`3`		`- "version": "1.25.4",`
	`3`	`+ "version": "1.25.5",`
`4`	`4`	`"description": "A React Native module for the PSPDFKit library.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react native",`