Skip to content

Commit fab1cdd

Browse files
authored
Catalog prop-types issue (#115)
It seems that windows has an issue referencing local nodes. For now we can get round this by referencing the git repo. There are some other minor cleanups also.
1 parent 784e0ab commit fab1cdd

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -717,17 +717,18 @@ to navigate the file system.
717717
1. Clone the repository. `git clone https://github.com/PSPDFKit/react-native.git`.
718718
2. From the command promt `cd react-native\samples\Catalog`.
719719
3. Make sure `react-native-cli` is installed: `npm install -g react-native-cli`.
720-
4. Edit `package.json` to change the version of `react-native` to `0.53.0`
720+
4. Edit `package.json` to change the version of `react-native` to `0.53.0` and refernce the react-native
721+
pspdfkit repo online.
721722
```diff
722723
"dependencies": {
723724
"react": "16.3.1",
724725
-"react-native": "0.55.4",
725726
+"react-native": "0.53.0",
726727
"react-native-fs": "2.10.14",
727-
"react-native-pspdfkit": "file:../../",
728+
-"react-native-pspdfkit": "file:../../",
729+
+"react-native-pspdfkit": "github:PSPDFKit/react-native",
728730
"react-native-windows": "0.53.0",
729-
"react-navigation": "^1.0.3",
730-
"rnpm-plugin-windows": "0.2.8"
731+
"react-navigation": "^1.0.3"
731732
}
732733
```
733734
5. run `npm install`.

samples/Catalog/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"react-native-fs": "2.10.14",
1212
"react-native-pspdfkit": "file:../../",
1313
"react-native-windows": "0.53.0",
14-
"react-navigation": "^1.0.3",
14+
"react-navigation": "^1.0.3"
15+
},
16+
"devDependencies": {
1517
"rnpm-plugin-windows": "0.2.8"
1618
}
1719
}
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
{
2-
"dependencies": {
3-
"Microsoft.NETCore.UniversalWindowsPlatform": "6.1.5"
4-
},
2+
"dependencies": {},
53
"frameworks": {
6-
"uap10.0.14393": {}
4+
"uap10.0.10586": {}
75
},
86
"runtimes": {
97
"win10-arm": {},
@@ -13,4 +11,4 @@
1311
"win10-x64": {},
1412
"win10-x64-aot": {}
1513
}
16-
}
14+
}

0 commit comments

Comments
 (0)