fix(advTags): Validated that root of path was correct and present

Author: rlabbeptc

kepconfig/adv_tags/__init__.py

@@ -8,6 +8,7 @@
 specific objects within the Kepware Configuration API
 """
 
+from ..error import KepError
 from . import adv_tag_group, average_tags, derived_tags, complex_tags, cumulative_tags, min_tags, max_tags, link_tags
 ADV_TAGS_ROOT = '/project/_advancedtags'
 
@@ -28,6 +29,9 @@ def _adv_tag_path_split(path: str, *, isItem=False) -> dict:
     return = {'adv_tag_root': '_advancedtags', 'tag_path': ['ch1','dev1']}
     '''
     path_list = path.split('.', 2)
+    if path_list[0] != '_advancedtags':
+        raise KepError('Error: Invalid advanced tag path - Must start with "_advancedtags"')
+     
     path_obj = {}
     for x in range(0, len(path_list)):
         if x == 0:

tests/adv_tags_test.py

@@ -222,7 +222,7 @@ def test_adv_tag_group_get(server):
     assert type(adv_tags.adv_tag_group.get_tag_group(server, adv_tag_child_group_path)) == dict
 
     # Get all advanced tag groups at root
-    assert type(adv_tags.adv_tag_group.get_all_tag_groups(server, '')) == list
+    assert type(adv_tags.adv_tag_group.get_all_tag_groups(server, '_advancedtags')) == list
 
     # Get all advanced tag groups under a parent
     result = adv_tags.adv_tag_group.get_all_tag_groups(server, f'_advancedtags.{adv_tag_group_name}')
@@ -232,6 +232,11 @@ def test_adv_tag_group_get(server):
     assert type(result) == list
     assert len(result) == 0
 
+def test_adv_tag_bad_root_in_path(server):
+    # Test bad advanced tag path
+    with pytest.raises(error.KepError):
+        adv_tags.adv_tag_group.get_tag_group(server, '_wrongroot.AdvTagGroup1')
+
 def test_adv_tag_group_modify(server):
     # Modify advanced tag group
     tag_group_data = {