From bbf5dc9f4408b14660d948900170ebb35a389940 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Wed, 13 Nov 2024 17:04:16 +0100 Subject: [PATCH 01/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index e022ca6..cbdba69 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -39,14 +39,6 @@ jobs: with: tool_versions: ${{ ENV.TOOL_VERSIONS }} - - name: Setup Java environment vars - working-directory: code - run: | - JAVA_HOME="$(asdf where java)" - echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV - echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV - echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV - - name: Maven / Verify artifact with coverage if: ${{ !(contains(github.event.pull_request.labels.*.name, 'autopublish/snapshot-binaries')) }} working-directory: code @@ -127,15 +119,6 @@ jobs: asdf local nodejs 20.10.0 asdf local maven 3.9.4 - - name: Setup Java environment vars - if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} - working-directory: code - run: | - JAVA_HOME="$(asdf where java)" - echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV - echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV - echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV - - name: SonarCloud / Run Maven Sonar goal if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} env: From 78b030cec4b6ad3e88ffb580b1c7f82e684cfd18 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Wed, 13 Nov 2024 17:08:44 +0100 Subject: [PATCH 02/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index cbdba69..e022ca6 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -39,6 +39,14 @@ jobs: with: tool_versions: ${{ ENV.TOOL_VERSIONS }} + - name: Setup Java environment vars + working-directory: code + run: | + JAVA_HOME="$(asdf where java)" + echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV + echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV + echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV + - name: Maven / Verify artifact with coverage if: ${{ !(contains(github.event.pull_request.labels.*.name, 'autopublish/snapshot-binaries')) }} working-directory: code @@ -119,6 +127,15 @@ jobs: asdf local nodejs 20.10.0 asdf local maven 3.9.4 + - name: Setup Java environment vars + if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} + working-directory: code + run: | + JAVA_HOME="$(asdf where java)" + echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV + echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV + echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV + - name: SonarCloud / Run Maven Sonar goal if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} env: From 20f6eb65fef4599bc0e139a97ca66b9dc728a63a Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Wed, 13 Nov 2024 17:09:46 +0100 Subject: [PATCH 03/10] chore: empty commit to retrigger PR verify From 9e2a31bc45d2bf09e87b4dc1f389b7d329b8b17f Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Wed, 13 Nov 2024 17:11:10 +0100 Subject: [PATCH 04/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index e022ca6..14aa6f2 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -46,6 +46,7 @@ jobs: echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV + - name: Maven / Verify artifact with coverage if: ${{ !(contains(github.event.pull_request.labels.*.name, 'autopublish/snapshot-binaries')) }} From a28a770334b003695e798ce30f1d4da8a7625ee0 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Wed, 13 Nov 2024 17:11:10 +0100 Subject: [PATCH 05/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index e022ca6..cbdba69 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -39,14 +39,6 @@ jobs: with: tool_versions: ${{ ENV.TOOL_VERSIONS }} - - name: Setup Java environment vars - working-directory: code - run: | - JAVA_HOME="$(asdf where java)" - echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV - echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV - echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV - - name: Maven / Verify artifact with coverage if: ${{ !(contains(github.event.pull_request.labels.*.name, 'autopublish/snapshot-binaries')) }} working-directory: code @@ -127,15 +119,6 @@ jobs: asdf local nodejs 20.10.0 asdf local maven 3.9.4 - - name: Setup Java environment vars - if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} - working-directory: code - run: | - JAVA_HOME="$(asdf where java)" - echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV - echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV - echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV - - name: SonarCloud / Run Maven Sonar goal if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} env: From 047c690d07aae17bb74ff4f93df360ef0e4df643 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Thu, 14 Nov 2024 14:17:43 +0100 Subject: [PATCH 06/10] test --- .../workflows/code-maven_java-PR_verify.yml | 57 ++++++++++++++----- .../code-maven_java-sonarcloud-analysis.yml | 40 ++++++++----- 2 files changed, 71 insertions(+), 26 deletions(-) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index cbdba69..a77eb56 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -26,6 +26,24 @@ jobs: fetch-depth: 0 ref: ${{ github.event.pull_request.head.sha }} + - name: Setup Maven Cache + uses: actions/cache@v4 + continue-on-error: true + with: + path: ~/.m2/repository + key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} + restore-keys: | + ${{ runner.os }}-maven- + + - name: Setup asdf Cache + uses: actions/cache@v4 + continue-on-error: true + with: + path: ~/.asdf/data + key: ${{ runner.os }}-asdf-${{ hashFiles('**/.tool-versions') }} + restore-keys: | + ${{ runner.os }}-asdf- + - name: Save tool-versions content run: | { @@ -34,10 +52,23 @@ jobs: echo "EOF" } >> "$GITHUB_ENV" - - name: Setup IVM environment + - name: Maven / Setup IVM environment uses: asdf-vm/actions/install@v3 with: - tool_versions: ${{ ENV.TOOL_VERSIONS }} + tool_versions: ${{ env.TOOL_VERSIONS }} + + - name: Setup Java environment vars + working-directory: code + run: | + JAVA_HOME="$(asdf where java)" + echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV + + - name: Store project version + if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} + id: version + run: | + echo "app-version=$(yq -oy '.project.version' code/pom.xml)" >> "$GITHUB_OUTPUT" + echo "app-name=$(yq -oy '.project.artifactId' code/pom.xml)" >> "$GITHUB_OUTPUT" - name: Maven / Verify artifact with coverage if: ${{ !(contains(github.event.pull_request.labels.*.name, 'autopublish/snapshot-binaries')) }} @@ -95,14 +126,7 @@ jobs: create_check: false check_name: "Code / Verify" - - name: Store project version - if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} - id: version - run: | - echo "app-version=$(yq -oy '.project.version' code/pom.xml)" >> "$GITHUB_OUTPUT" - echo "app-name=$(yq -oy '.project.artifactId' code/pom.xml)" >> "$GITHUB_OUTPUT" - - - name: Setup IVM environment + - name: SonarCloud / Setup asdf tools if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} uses: asdf-vm/actions/install@v3 with: @@ -111,7 +135,7 @@ jobs: nodejs 20.10.0 maven 3.9.4 - - name: Set asdf versions for SonarCloud + - name: SonarCloud / Set asdf versions if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} working-directory: code run: | @@ -119,6 +143,13 @@ jobs: asdf local nodejs 20.10.0 asdf local maven 3.9.4 + - name: Setup Java environment vars + if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} + working-directory: code + run: | + JAVA_HOME="$(asdf where java)" + echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV + - name: SonarCloud / Run Maven Sonar goal if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} env: @@ -128,11 +159,11 @@ jobs: working-directory: code run: | mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \ - -Dsonar.projectKey=PabloCollazoCollarte_"${{ steps.version.outputs.app-name }}" \ + -Dsonar.projectKey=InditexTech_"${{ steps.version.outputs.app-name }}" \ -Dsonar.projectName="${{ steps.version.outputs.app-name }}" \ -Dsonar.projectVersion="${{ steps.version.outputs.app-version }}" \ -Dsonar.host.url="https://sonarcloud.io/" \ - -Dsonar.organization=pablocollazocollarte \ + -Dsonar.organization=inditextech \ -Dsonar.token="${LOGIN}" \ -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} \ -Dsonar.pullrequest.branch="$PR_HEAD_REF" \ diff --git a/.github/workflows/code-maven_java-sonarcloud-analysis.yml b/.github/workflows/code-maven_java-sonarcloud-analysis.yml index 329790f..d409994 100644 --- a/.github/workflows/code-maven_java-sonarcloud-analysis.yml +++ b/.github/workflows/code-maven_java-sonarcloud-analysis.yml @@ -31,7 +31,25 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 - + + - name: Setup Maven Cache + uses: actions/cache@v4 + continue-on-error: true + with: + path: ~/.m2/repository + key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} + restore-keys: | + ${{ runner.os }}-maven- + + - name: Setup asdf Cache + uses: actions/cache@v4 + continue-on-error: true + with: + path: ~/.asdf/data + key: ${{ runner.os }}-asdf-${{ hashFiles('**/.tool-versions') }} + restore-keys: | + ${{ runner.os }}-asdf- + - name: Save tool-versions content run: | { @@ -40,26 +58,24 @@ jobs: echo "EOF" } >> "$GITHUB_ENV" - - name: Setup IVM environment + - name: Maven / Setup asdf tools uses: asdf-vm/actions/install@v3 with: - tool_versions: ${{ ENV.TOOL_VERSIONS }} + tool_versions: ${{ env.TOOL_VERSIONS }} - name: Setup Java environment vars working-directory: code run: | JAVA_HOME="$(asdf where java)" echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV - echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV - echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV - - name: Run unit tests with release event + - name: Maven / Run unit tests with release event if: github.event_name == 'release' working-directory: code run: | mvn -B clean verify -DskipEnforceSnapshots -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false - - name: Run unit tests + - name: Maven / Run unit tests if: github.event_name != 'release' working-directory: code run: | @@ -71,7 +87,7 @@ jobs: echo "app-version=$(yq -oy '.project.version' code/pom.xml)" >> "$GITHUB_OUTPUT" echo "app-name=$(yq -oy '.project.artifactId' code/pom.xml)" >> "$GITHUB_OUTPUT" - - name: Setup IVM environment + - name: SonarCloud / Setup asdf tools uses: asdf-vm/actions/install@v3 with: tool_versions: | @@ -79,7 +95,7 @@ jobs: nodejs 20.10.0 maven 3.9.4 - - name: Set asdf versions for SonarCloud + - name: SonarCloud / Set asdf versions working-directory: code run: | asdf local java temurin-17.0.8+7 @@ -91,8 +107,6 @@ jobs: run: | JAVA_HOME="$(asdf where java)" echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV - echo "JAVA_CACERTS_PATH=$JAVA_HOME/lib/security" >> $GITHUB_ENV - echo "JAVA_CACERTS=$JAVA_HOME/lib/security/cacerts" >> $GITHUB_ENV - name: SonarCloud / Run Maven Sonar goal with release event env: @@ -102,12 +116,12 @@ jobs: working-directory: code run: | mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \ - -Dsonar.projectKey=InditexTech_"${{ steps.version.outputs.app-name }}" \ + -Dsonar.projectKey=PabloCollazoCollarte_"${{ steps.version.outputs.app-name }}" \ -Dsonar.projectName="${{ steps.version.outputs.app-name }}" \ -Dsonar.projectVersion="${{ github.event.release.tag_name }}" \ -Dsonar.branch.name="release/${{ github.event.release.tag_name }}" \ -Dsonar.host.url="https://sonarcloud.io/" \ - -Dsonar.organization=inditextech \ + -Dsonar.organization=pablocollazocollarte \ -Dsonar.token="${LOGIN}" - name: SonarCloud / Run Maven Sonar goal From 0edc05759b773c708d7e506be80215e70e720b57 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Mon, 18 Nov 2024 17:26:01 +0100 Subject: [PATCH 07/10] test --- code/jacoco-report-aggregate/pom.xml | 87 ++++++++++++++++++++++++++++ code/pom.xml | 41 ++++++++++++- 2 files changed, 127 insertions(+), 1 deletion(-) create mode 100644 code/jacoco-report-aggregate/pom.xml diff --git a/code/jacoco-report-aggregate/pom.xml b/code/jacoco-report-aggregate/pom.xml new file mode 100644 index 0000000..6f273c4 --- /dev/null +++ b/code/jacoco-report-aggregate/pom.xml @@ -0,0 +1,87 @@ + + + 4.0.0 + + + com.sivalabs + spring-boot-microservices-series + 0.0.1-SNAPSHOT + .. + + + jacoco-report-aggregate + pom + + ${project.groupId}:${project.artifactId} + InditexTech Karate Tools - Jacoco Report Aggregate + + + + ${project.groupId} + config-server + ${project.version} + + + ${project.groupId} + oauth2-server + ${project.version} + + + ${project.groupId} + service-registry + ${project.version} + + + ${project.groupId} + hystrix-dashboard + ${project.version} + + + ${project.groupId} + inventory-service + ${project.version} + + + ${project.groupId} + order-service + ${project.version} + + + ${project.groupId} + shoppingcart-ui + ${project.version} + + + ${project.groupId} + zipkin-server + ${project.version} + + + + + ${project.artifactId}-${project.version} + + + org.jacoco + jacoco-maven-plugin + + + quality-metric-jacoco-report-aggregate + prepare-package + + report-aggregate + + + ${project.parent.artifactId} +
Code Coverage Report for ${project.parent.artifactId} ${project.version}
+ + **/*.class + + ${jacoco.outputDirectory} + + + + + + + diff --git a/code/pom.xml b/code/pom.xml index f059cfd..781d175 100644 --- a/code/pom.xml +++ b/code/pom.xml @@ -20,10 +20,15 @@ catalog-service inventory-service order-service - shoppingcart-ui + shoppingcart-ui zipkin-server + jacoco-report-aggregate + + true + + @@ -42,8 +47,42 @@ + + org.jacoco + jacoco-maven-plugin + 0.8.8 + + + + org.jacoco + jacoco-maven-plugin + + + quality-metric-jacoco-prepare-ut + initialize + + prepare-agent + + + + quality-metric-jacoco-prepare-it + initialize + + prepare-agent-integration + + + + quality-metric-jacoco-report + prepare-package + + report + + + + + From d52da6820aad830260a9b9b838ecbb89c22b9955 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Tue, 19 Nov 2024 08:41:41 +0100 Subject: [PATCH 08/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index a77eb56..4c4e08a 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -77,7 +77,7 @@ jobs: mvn -B clean verify -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false - name: Prepare committer information and set GPG key - if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} + if: ${{ vars.IS_INDITEXTECH_REPO != 'true' }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SCM_COMMITTER_PGP_KEY: ${{ secrets.CI_GPG_SECRET_KEY }} @@ -158,12 +158,13 @@ jobs: SONAR_SCANNER_OPTS: '' working-directory: code run: | + JACOCO_REPORT_PATH="$GITHUB_WORKSPACE/code/jacoco-report-aggregate/target/site/jacoco-aggregate/jacoco.xml" mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \ - -Dsonar.projectKey=InditexTech_"${{ steps.version.outputs.app-name }}" \ + -Dsonar.projectKey=PabloCollazoCollarte_"${{ steps.version.outputs.app-name }}" \ -Dsonar.projectName="${{ steps.version.outputs.app-name }}" \ -Dsonar.projectVersion="${{ steps.version.outputs.app-version }}" \ -Dsonar.host.url="https://sonarcloud.io/" \ - -Dsonar.organization=inditextech \ + -Dsonar.organization=pablocollazocollarte \ -Dsonar.token="${LOGIN}" \ -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} \ -Dsonar.pullrequest.branch="$PR_HEAD_REF" \ @@ -173,4 +174,5 @@ jobs: -Dsonar.qualitygate.timeout=300 \ -Dsonar.pullrequest.provider=GitHub \ -Dsonar.pullrequest.github.repository="${{ github.repository }}" \ - -Dsonar.pullrequest.github.summary_comment=true + -Dsonar.pullrequest.github.summary_comment=true \ + -Dsonar.coverage.jacoco.xmlReportPaths="$JACOCO_REPORT_PATH" From 51bc9dc897e0f67c3d560e04b8ffee7a6e9d08a6 Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Tue, 19 Nov 2024 08:55:07 +0100 Subject: [PATCH 09/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 9 ++++++--- .../code-maven_java-sonarcloud-analysis.yml | 15 +++++++++++---- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index 4c4e08a..1b9f450 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -11,6 +11,9 @@ on: - 'code/**' - '.github/workflows/code*' +env: + MAVEN_OPTS: "-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn" + jobs: unit-tests: name: Code / Verify @@ -74,10 +77,10 @@ jobs: if: ${{ !(contains(github.event.pull_request.labels.*.name, 'autopublish/snapshot-binaries')) }} working-directory: code run: | - mvn -B clean verify -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false + mvn -B clean verify -Djacoco.skip=false -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false - name: Prepare committer information and set GPG key - if: ${{ vars.IS_INDITEXTECH_REPO != 'true' }} + if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SCM_COMMITTER_PGP_KEY: ${{ secrets.CI_GPG_SECRET_KEY }} @@ -103,7 +106,7 @@ jobs: mvn -B build-helper:parse-version versions:set \ -DnewVersion="\${parsedVersion.majorVersion}.\${parsedVersion.minorVersion}.\${parsedVersion.incrementalVersion}+PR${{ github.event.pull_request.number }}-SNAPSHOT" - mvn -B clean install gpg:sign org.sonatype.central:central-publishing-maven-plugin:publish -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false -Dbuild.type=snapshot --settings=.mvn/settings.xml + mvn -B clean install gpg:sign org.sonatype.central:central-publishing-maven-plugin:publish -Djacoco.skip=false -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false -Dbuild.type=snapshot --settings=.mvn/settings.xml VERSION=${{ steps.version.outputs.app-version }} VERSION=${VERSION/-SNAPSHOT}+PR${{ github.event.pull_request.number }}-SNAPSHOT diff --git a/.github/workflows/code-maven_java-sonarcloud-analysis.yml b/.github/workflows/code-maven_java-sonarcloud-analysis.yml index d409994..425f991 100644 --- a/.github/workflows/code-maven_java-sonarcloud-analysis.yml +++ b/.github/workflows/code-maven_java-sonarcloud-analysis.yml @@ -16,6 +16,9 @@ on: types: - published +env: + MAVEN_OPTS: "-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn" + jobs: unit-tests: name: SonarCloud / Unit Tests @@ -73,13 +76,13 @@ jobs: if: github.event_name == 'release' working-directory: code run: | - mvn -B clean verify -DskipEnforceSnapshots -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false + mvn -B clean verify -Djacoco.skip=false -DskipEnforceSnapshots -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false - name: Maven / Run unit tests if: github.event_name != 'release' working-directory: code run: | - mvn -B clean verify -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false + mvn -B clean verify -Djacoco.skip=false -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false - name: Store project version id: version @@ -115,6 +118,7 @@ jobs: if: ${{ github.event_name == 'release' }} working-directory: code run: | + JACOCO_REPORT_PATH="$GITHUB_WORKSPACE/code/jacoco-report-aggregate/target/site/jacoco-aggregate/jacoco.xml" mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \ -Dsonar.projectKey=PabloCollazoCollarte_"${{ steps.version.outputs.app-name }}" \ -Dsonar.projectName="${{ steps.version.outputs.app-name }}" \ @@ -122,7 +126,8 @@ jobs: -Dsonar.branch.name="release/${{ github.event.release.tag_name }}" \ -Dsonar.host.url="https://sonarcloud.io/" \ -Dsonar.organization=pablocollazocollarte \ - -Dsonar.token="${LOGIN}" + -Dsonar.token="${LOGIN}" \ + -Dsonar.coverage.jacoco.xmlReportPaths="$JACOCO_REPORT_PATH" - name: SonarCloud / Run Maven Sonar goal env: @@ -131,6 +136,7 @@ jobs: if: ${{ github.event_name != 'release' }} working-directory: code run: | + JACOCO_REPORT_PATH="$GITHUB_WORKSPACE/code/jacoco-report-aggregate/target/site/jacoco-aggregate/jacoco.xml" mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \ -Dsonar.projectKey=PabloCollazoCollarte_"${{ steps.version.outputs.app-name }}" \ -Dsonar.projectName="${{ steps.version.outputs.app-name }}" \ @@ -138,4 +144,5 @@ jobs: -Dsonar.branch.name="${{ github.base_ref || github.ref_name }}" \ -Dsonar.host.url="https://sonarcloud.io/" \ -Dsonar.organization=pablocollazocollarte \ - -Dsonar.token="${LOGIN}" + -Dsonar.token="${LOGIN}" \ + -Dsonar.coverage.jacoco.xmlReportPaths="$JACOCO_REPORT_PATH" From ca126aa50af749a261a9af49573910f264f3847b Mon Sep 17 00:00:00 2001 From: Pablo Collazo Collarte Date: Tue, 19 Nov 2024 08:58:00 +0100 Subject: [PATCH 10/10] test --- .github/workflows/code-maven_java-PR_verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-maven_java-PR_verify.yml b/.github/workflows/code-maven_java-PR_verify.yml index 1b9f450..74634d6 100644 --- a/.github/workflows/code-maven_java-PR_verify.yml +++ b/.github/workflows/code-maven_java-PR_verify.yml @@ -80,7 +80,7 @@ jobs: mvn -B clean verify -Djacoco.skip=false -DskipITs -DfailIfNoTests=false -Dmaven.test.failure.ignore=false - name: Prepare committer information and set GPG key - if: ${{ vars.IS_INDITEXTECH_REPO == 'true' }} + if: ${{ vars.IS_INDITEXTECH_REPO != 'true' }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SCM_COMMITTER_PGP_KEY: ${{ secrets.CI_GPG_SECRET_KEY }}