WIP: TASK remove unneeded EnumMemberType::memberBackedValueType

Author: mhsdesign

src/TypeSystem/Type/EnumType/EnumMemberType.php

@@ -28,8 +28,7 @@ final class EnumMemberType implements TypeInterface
 {
     public function __construct(
         public readonly EnumInstanceType|EnumStaticType $enumType,
-        public readonly string $memberName,
-        public readonly ?TypeInterface $memberBackedValueType
+        public readonly string $memberName
     ) {
     }
 

src/TypeSystem/Type/EnumType/EnumStaticType.php

@@ -30,6 +30,6 @@ final class EnumStaticType implements TypeInterface
 
     public function toEnumInstanceType(): EnumInstanceType
     {
-        return new EnumInstanceType($this->moduleId, $this->enumName, $this->membersWithType);
+        return new EnumInstanceType($this->moduleId, $this->enumName, $this->memberNameHashMap);
     }
 }

src/TypeSystem/Type/EnumType/EnumTrait.php

@@ -24,59 +24,44 @@
 
 use PackageFactory\ComponentEngine\Module\ModuleId;
 use PackageFactory\ComponentEngine\Parser\Ast\EnumDeclarationNode;
-use PackageFactory\ComponentEngine\Parser\Ast\NumberLiteralNode;
-use PackageFactory\ComponentEngine\Parser\Ast\StringLiteralNode;
-use PackageFactory\ComponentEngine\TypeSystem\Resolver\NumberLiteral\NumberLiteralTypeResolver;
-use PackageFactory\ComponentEngine\TypeSystem\Resolver\StringLiteral\StringLiteralTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\TypeInterface;
 
 trait EnumTrait
 {
     public function __construct(
         public readonly ?ModuleId $moduleId,
         public readonly string $enumName,
-        private readonly array $membersWithType,
+        private readonly array $memberNameHashMap,
     ) {
     }
 
     public static function fromModuleIdAndDeclaration(ModuleId $moduleId, EnumDeclarationNode $enumDeclarationNode): self
     {
-        $membersWithType = [];
-
+        $memberNameHashMap = [];
         foreach ($enumDeclarationNode->memberDeclarations->items as $memberDeclarationNode) {
-            $membersWithType[$memberDeclarationNode->name] = match ($memberDeclarationNode->value
-                ? $memberDeclarationNode->value::class
-                : null
-            ) {
-                NumberLiteralNode::class => (new NumberLiteralTypeResolver())
-                    ->resolveTypeOf($memberDeclarationNode->value),
-                StringLiteralNode::class => (new StringLiteralTypeResolver())
-                    ->resolveTypeOf($memberDeclarationNode->value),
-                null => null
-            };
+            $memberNameHashMap[$memberDeclarationNode->name] = true;
         }
 
         return new self(
             moduleId: $moduleId,
             enumName: $enumDeclarationNode->enumName,
-            membersWithType: $membersWithType
+            memberNameHashMap: $memberNameHashMap
         );
     }
 
     public function getMemberNames(): array
     {
-        return array_keys($this->membersWithType);
+        return array_keys($this->memberNameHashMap);
     }
 
     public function getMemberType(string $memberName): EnumMemberType
     {
-        if (!array_key_exists($memberName, $this->membersWithType)) {
+        if (!array_key_exists($memberName, $this->memberNameHashMap)) {
             throw new \Exception('@TODO cannot access member ' . $memberName . ' of enum ' . $this->enumName);
         }
         return new EnumMemberType(
             $this,
-            $memberName,
-            $this->membersWithType[$memberName]
+            $memberName
         );
     }
 

test/Unit/TypeSystem/Resolver/Access/AccessTypeResolverTest.php

@@ -91,8 +91,6 @@ public function access(): void
         $this->assertTrue($accessType->enumType->is($someEnum));
 
         $this->assertEquals("A", $accessType->memberName);
-
-        $this->assertTrue($accessType->memberBackedValueType?->is(StringType::get()));
     }
 
     /**

test/Unit/TypeSystem/Type/EnumType/EnumInstanceTypeTest.php

@@ -25,6 +25,7 @@
 use PackageFactory\ComponentEngine\Module\ModuleId;
 use PackageFactory\ComponentEngine\Parser\Ast\EnumDeclarationNode;
 use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumInstanceType;
+use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumMemberType;
 use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumStaticType;
 use PHPUnit\Framework\TestCase;
 
@@ -69,14 +70,33 @@ public function providesNameOfTheEnum(): void
      */
     public function providesMemberNames(): void
     {
-        $enumStaticType = EnumStaticType::fromModuleIdAndDeclaration(
+        $enumInstanceType = EnumInstanceType::fromModuleIdAndDeclaration(
+            ModuleId::fromString("module-a"),
+            EnumDeclarationNode::fromString(
+                'enum SomeEnum { A B C }'
+            )
+        );
+
+        $this->assertSame(["A", "B", "C"], $enumInstanceType->getMemberNames());
+    }
+
+    /**
+     * @test
+     */
+    public function providesMemberType(): void
+    {
+        $enumInstanceType = EnumInstanceType::fromModuleIdAndDeclaration(
             ModuleId::fromString("module-a"),
             EnumDeclarationNode::fromString(
                 'enum SomeEnum { A B C }'
             )
         );
 
-        $this->assertSame(["A", "B", "C"], $enumStaticType->getMemberNames());
+        $enumMemberType = $enumInstanceType->getMemberType('A');
+        $this->assertInstanceOf(EnumMemberType::class, $enumMemberType);
+
+        $this->assertSame($enumInstanceType, $enumMemberType->enumType);
+        $this->assertSame('A', $enumMemberType->memberName);
     }
 
     /**

test/Unit/TypeSystem/Type/EnumType/EnumStaticTypeTest.php

@@ -25,6 +25,7 @@
 use PackageFactory\ComponentEngine\Module\ModuleId;
 use PackageFactory\ComponentEngine\Parser\Ast\EnumDeclarationNode;
 use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumInstanceType;
+use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumMemberType;
 use PackageFactory\ComponentEngine\TypeSystem\Type\EnumType\EnumStaticType;
 use PHPUnit\Framework\TestCase;
 
@@ -79,6 +80,25 @@ public function providesMemberNames(): void
         $this->assertSame(["A", "B", "C"], $enumStaticType->getMemberNames());
     }
 
+    /**
+     * @test
+     */
+    public function providesMemberType(): void
+    {
+        $enumStaticType = EnumStaticType::fromModuleIdAndDeclaration(
+            ModuleId::fromString("module-a"),
+            EnumDeclarationNode::fromString(
+                'enum SomeEnum { A B C }'
+            )
+        );
+
+        $enumMemberType = $enumStaticType->getMemberType('A');
+        $this->assertInstanceOf(EnumMemberType::class, $enumMemberType);
+
+        $this->assertSame($enumStaticType, $enumMemberType->enumType);
+        $this->assertSame('A', $enumMemberType->memberName);
+    }
+
     /**
      * @test
      * @return void