!!!TASK: Rename IdentifierTypeResolver -> ValueReferenceTypeResolver

Author: grebaldi

src/TypeSystem/Resolver/Expression/ExpressionTypeResolver.php

@@ -37,7 +37,7 @@
 use PackageFactory\ComponentEngine\TypeSystem\Resolver\Access\AccessTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\Resolver\BinaryOperation\BinaryOperationTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\Resolver\BooleanLiteral\BooleanLiteralTypeResolver;
-use PackageFactory\ComponentEngine\TypeSystem\Resolver\Identifier\IdentifierTypeResolver;
+use PackageFactory\ComponentEngine\TypeSystem\Resolver\ValueReference\ValueReferenceTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\Resolver\Match\MatchTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\Resolver\NullLiteral\NullLiteralTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\Resolver\IntegerLiteral\IntegerLiteralTypeResolver;
@@ -64,7 +64,7 @@ public function resolveTypeOf(ExpressionNode $expressionNode): TypeInterface
             ))->resolveTypeOf($rootNode),
             BooleanLiteralNode::class => (new BooleanLiteralTypeResolver())
                 ->resolveTypeOf($rootNode),
-            ValueReferenceNode::class => (new IdentifierTypeResolver(
+            ValueReferenceNode::class => (new ValueReferenceTypeResolver(
                 scope: $this->scope
             ))->resolveTypeOf($rootNode),
             MatchNode::class => (new MatchTypeResolver(

…er/Identifier/IdentifierTypeResolver.php …Reference/ValueReferenceTypeResolver.phpsrc/TypeSystem/Resolver/Identifier/IdentifierTypeResolver.php renamed to src/TypeSystem/Resolver/ValueReference/ValueReferenceTypeResolver.php src/TypeSystem/Resolver/Identifier/IdentifierTypeResolver.php renamed to src/TypeSystem/Resolver/ValueReference/ValueReferenceTypeResolver.php

@@ -20,13 +20,13 @@
 
 declare(strict_types=1);
 
-namespace PackageFactory\ComponentEngine\TypeSystem\Resolver\Identifier;
+namespace PackageFactory\ComponentEngine\TypeSystem\Resolver\ValueReference;
 
 use PackageFactory\ComponentEngine\Language\AST\Node\ValueReference\ValueReferenceNode;
 use PackageFactory\ComponentEngine\TypeSystem\ScopeInterface;
 use PackageFactory\ComponentEngine\TypeSystem\TypeInterface;
 
-final class IdentifierTypeResolver
+final class ValueReferenceTypeResolver
 {
     public function __construct(private readonly ScopeInterface $scope)
     {

…dentifier/IdentifierTypeResolverTest.php …rence/ValueReferenceTypeResolverTest.phptest/Unit/TypeSystem/Resolver/Identifier/IdentifierTypeResolverTest.php renamed to test/Unit/TypeSystem/Resolver/ValueReference/ValueReferenceTypeResolverTest.php test/Unit/TypeSystem/Resolver/Identifier/IdentifierTypeResolverTest.php renamed to test/Unit/TypeSystem/Resolver/ValueReference/ValueReferenceTypeResolverTest.php

@@ -20,27 +20,24 @@
 
 declare(strict_types=1);
 
-namespace PackageFactory\ComponentEngine\Test\Unit\TypeSystem\Resolver\Identifier;
+namespace PackageFactory\ComponentEngine\Test\Unit\TypeSystem\Resolver\ValueReference;
 
-use PackageFactory\ComponentEngine\Domain\TypeName\TypeName;
-use PackageFactory\ComponentEngine\Domain\TypeName\TypeNames;
 use PackageFactory\ComponentEngine\Test\Unit\Language\ASTNodeFixtures;
 use PackageFactory\ComponentEngine\Test\Unit\TypeSystem\Scope\Fixtures\DummyScope;
-use PackageFactory\ComponentEngine\TypeSystem\Resolver\Identifier\IdentifierTypeResolver;
+use PackageFactory\ComponentEngine\TypeSystem\Resolver\ValueReference\ValueReferenceTypeResolver;
 use PackageFactory\ComponentEngine\TypeSystem\Type\StringType\StringType;
-use PackageFactory\ComponentEngine\TypeSystem\TypeReference;
 use PHPUnit\Framework\TestCase;
 
-final class IdentifierTypeResolverTest extends TestCase
+final class ValueReferenceTypeResolverTest extends TestCase
 {
     /**
      * @test
      * @return void
      */
-    public function resolvesKnownIdentifierToItsType(): void
+    public function resolvesKnownValueReferenceToItsType(): void
     {
         $scope = new DummyScope([StringType::get()], ['foo' => StringType::get()]);
-        $identifierTypeResolver = new IdentifierTypeResolver(scope: $scope);
+        $identifierTypeResolver = new ValueReferenceTypeResolver(scope: $scope);
         $identifierNode = ASTNodeFixtures::ValueReference('foo');
 
         $expectedType = StringType::get();
@@ -56,10 +53,10 @@ public function resolvesKnownIdentifierToItsType(): void
      * @test
      * @return void
      */
-    public function throwsIfGivenIdentifierIsUnknown(): void
+    public function throwsIfGivenValueReferenceIsUnknown(): void
     {
         $scope = new DummyScope();
-        $identifierTypeResolver = new IdentifierTypeResolver(scope: $scope);
+        $identifierTypeResolver = new ValueReferenceTypeResolver(scope: $scope);
         $identifierNode = ASTNodeFixtures::ValueReference('foo');
 
         $this->expectExceptionMessageMatches('/unknown identifier/i');