chore: 🤖 fix new Biome v2 linting issues

Author: lrodrigues-newstore

biome.json

@@ -17,6 +17,22 @@
     }
   },
   "files": {
-    "ignore": [".vscode"]
+    "includes": ["**", "!**/.vscode"]
+  },
+  "linter": {
+    "rules": {
+      "style": {
+        "noParameterAssign": "error",
+        "useAsConstAssertion": "error",
+        "useDefaultParameterLast": "error",
+        "useEnumInitializers": "error",
+        "useSelfClosingElements": "error",
+        "useSingleVarDeclarator": "error",
+        "noUnusedTemplateLiteral": "error",
+        "useNumberNamespace": "error",
+        "noInferrableTypes": "error",
+        "noUselessElse": "error"
+      }
+    }
   }
 }

packages/array/src/sample.ts

@@ -1,3 +1,9 @@
+type NonEmptyArray<T> = readonly [T, ...T[]]
+
+function isNotEmpty<T>(value: readonly T[]): value is NonEmptyArray<T> {
+  return value.length > 0
+}
+
 /**
  * Picks a random element from an array, or `undefined` if the provided array
  * is empty.
@@ -15,8 +21,9 @@
  * @returns Random element from the provided array, or `undefined` if the array
  *          is empty.
  */
+export function sample<T>(array: NonEmptyArray<T>): T
 export function sample<T>(array: readonly T[]): T | undefined {
-  if (array.length === 0) return undefined
+  if (!isNotEmpty(array)) return undefined
   return array[Math.floor(Math.random() * array.length)]
 }
 
@@ -38,12 +45,11 @@ export function sample<T>(array: readonly T[]): T | undefined {
  * @returns Array of random elements from the provided array.
  */
 export function sampleN<T>(array: readonly T[], sampleSize: number): T[] {
-  if (array.length === 0) return []
+  if (!isNotEmpty(array)) return []
   const maxSamples = Math.max(0, sampleSize)
   const result = new Array<T>(maxSamples)
   for (let i = 0; i < maxSamples; i++) {
-    // biome-ignore lint/style/noNonNullAssertion: <explanation>
-    result[i] = sample(array)!
+    result[i] = sample(array)
   }
   return result
 }

packages/emitter/src/index.ts

@@ -1,6 +1,5 @@
 interface Events {
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
-  [name: string]: (...args: any[]) => void
+  [name: string]: (...args: unknown[]) => void
 }
 
 interface Emitter<E extends Events> {

packages/error/src/index.ts

@@ -11,22 +11,22 @@ export class BaseError extends Error {
    * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error#Custom_Error_Types
    */
   public static imprint(instance: BaseError): void {
-    // biome-ignore lint/complexity/noThisInStatic: <explanation>
+    // biome-ignore lint/complexity/noThisInStatic: imprint class name
     instance.name = this.name
 
     if (Error.captureStackTrace) {
-      // biome-ignore lint/complexity/noThisInStatic: <explanation>
+      // biome-ignore lint/complexity/noThisInStatic: imprint stack trace
       Error.captureStackTrace(instance, this.constructor)
     }
 
     if (Object.setPrototypeOf) {
-      // biome-ignore lint/complexity/noThisInStatic: <explanation>
+      // biome-ignore lint/complexity/noThisInStatic: imprint class prototype
       Object.setPrototypeOf(instance, this.prototype)
     }
   }
 
   public static fromString(message?: string): BaseError {
-    // biome-ignore lint/complexity/noThisInStatic: <explanation>
+    // biome-ignore lint/complexity/noThisInStatic: constructor method
     return new this(message)
   }
 }
@@ -40,13 +40,13 @@ export class ComplexError extends BaseError {
   ) {
     super(message)
     ComplexError.imprint(this)
-    this.causes = Array<Error | BaseError>().concat(causes)
+    this.causes = ([] as ReadonlyArray<Error | BaseError>).concat(causes)
   }
 
   public static fromErrors(
     errors: readonly (Error | BaseError)[],
   ): ComplexError {
-    // biome-ignore lint/complexity/noThisInStatic: <explanation>
+    // biome-ignore lint/complexity/noThisInStatic: constructor method
     return new this(undefined, errors)
   }
 }

packages/flux-actions/src/index.ts

@@ -1,11 +1,11 @@
-// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+// biome-ignore lint/suspicious/noExplicitAny: ignore
 export interface Action<P = any, M = any> {
   type: string
   payload: P
   meta: M
 }
 
-// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+// biome-ignore lint/suspicious/noExplicitAny: ignore
 type ActionCreator<P = any, M = any> = {
   type: string
   (payload: P, meta?: M): Action<P, M>
@@ -15,7 +15,7 @@ type ActionCreator<P = any, M = any> = {
 
 type Reducer<S> = (state: S | undefined, action: Action) => S
 
-// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+// biome-ignore lint/suspicious/noExplicitAny: ignore
 type ReduceHandler<S, P = any, M = any> = (state: S, action: Action<P, M>) => S
 
 type ReducerMatch<S> = [ActionCreator, ReduceHandler<S>]
@@ -58,7 +58,7 @@ function createReducer<S>(
     on(creators, handler) {
       return createReducer(initialState, [
         ...matches,
-        ...Array<ActionCreator>()
+        ...([] as ActionCreator[])
           .concat(creators)
           .map<ReducerMatch<S>>((creator) => [creator, handler]),
       ])

packages/interpolate/src/index.ts

@@ -7,7 +7,7 @@ export function interpolate(
   const regexp = RegExp(pattern, 'g')
 
   return (data: ReplaceMap<string | number | null | undefined> = {}): string =>
-    template.replace(regexp, (match, capture = '') => {
+    template.replace(regexp, (_match, capture = '') => {
       const key = capture.trim()
       const value = Array.isArray(data)
         ? data[Number.parseInt(key, 10)]

packages/jest-either/src/shared/predicates.ts

@@ -1,20 +1,20 @@
 import { isPlainObject } from '@pacote/is-plain-object'
 import { pipe } from 'fp-ts/function'
 import { type Either, fold } from 'fp-ts/lib/Either'
-import { F, equals, map, where } from 'ramda'
+import { equals, F, map, where } from 'ramda'
 
 export interface AsymmetricMatcher {
   asymmetricMatch(other: unknown): boolean
 }
 
 export function isAsymmetricMatcher(
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
+  // biome-ignore lint/suspicious/noExplicitAny: can be anything
   matcher: any,
 ): matcher is AsymmetricMatcher {
   return typeof matcher.asymmetricMatch === 'function'
 }
 
-// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+// biome-ignore lint/suspicious/noExplicitAny: can be anything
 export const matchObject = (s: any) => (o: unknown) =>
   isPlainObject(o) ? where(map(matchObject, s), o) : equals(s, o)
 

packages/jest-either/src/toBeEither.ts

@@ -23,7 +23,7 @@ const failMessage = (actual: unknown) => () =>
     '',
   )}\n\nExpected Either, received:\n  ${printReceived(actual)}`
 
-// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+// biome-ignore lint/suspicious/noExplicitAny: receives anything
 function isEither(actual: any): actual is Either<unknown, unknown> {
   return (
     actual !== undefined &&

packages/jest-either/src/toMatchLeft.ts

@@ -36,13 +36,11 @@ const failMessage =
 export function toMatchLeft(
   actual: Either<string, unknown>,
   expected: RegExp,
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
-): any
+): unknown
 export function toMatchLeft<L>(
   actual: Either<L, unknown>,
   expected: Partial<L>,
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
-): any
+): unknown
 export function toMatchLeft<L>(
   actual: Either<L, unknown>,
   expected: RegExp | Partial<L>,

packages/jest-either/src/toMatchRight.ts

@@ -36,13 +36,11 @@ const failMessage =
 export function toMatchRight(
   actual: Either<unknown, string>,
   expected: RegExp,
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
-): any
+): unknown
 export function toMatchRight<R>(
   actual: Either<unknown, R>,
   expected: Partial<R>,
-  // biome-ignore lint/suspicious/noExplicitAny: <explanation>
-): any
+): unknown
 export function toMatchRight<R>(
   actual: Either<unknown, string | R>,
   expected: RegExp | Partial<R>,