Skip to content

Commit 331c4d2

Browse files
authored
Set approve checking for config.py, worker, model and cudagraph (#4276)
* set approve checking for config.py and worker files * update * update * update file list * check worker * update * check graph * check model_loader * check models * update
1 parent 838de53 commit 331c4d2

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

scripts/check_approval.sh

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,20 @@ if [ ${HAS_CUSTOM_REGISTRER} ] && [ "${PR_ID}" != "" ]; then
5050
check_approval "$echo_line3" 1 XiaoguangHu01 jeff41404 phlrain
5151
fi
5252

53+
WORKER_OR_CONFIG_LIST=(
54+
"fastdeploy/config.py"
55+
"fastdeploy/worker"
56+
"fastdeploy/model_executor/graph_optimization"
57+
"fastdeploy/model_executor/model_loader"
58+
"fastdeploy/model_executor/models"
59+
)
60+
61+
HAS_WORKER_OR_CONFIG_MODIFY=`git diff upstream/$BRANCH --name-only | grep -E $(printf -- "-e %s " "${WORKER_OR_CONFIG_LIST[@]}") || true`
62+
if [ ${HAS_WORKER_OR_CONFIG_MODIFY} ] && [ "${PR_ID}" != "" ]; then
63+
echo_line1="You must have one FastDeploy RD (gongshaotian(gongshaotian), yuanlehome(liuyuanle)) approval for modifing [$(IFS=', '; echo "${WORKER_OR_CONFIG_LIST[*]}")]."
64+
check_approval "$echo_line1" 1 gongshaotian yuanlehome
65+
fi
66+
5367
SPECULATIVE_DECODING_LIST=(
5468
"fastdeploy/spec_decode"
5569
"custom_ops/gpu_ops/speculate_decoding"

0 commit comments

Comments
 (0)