Skip to content

Commit a6e8b78

Browse files
authored
fix approve (#3224)
1 parent 8939751 commit a6e8b78

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

scripts/check_approval.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ echo_list=()
2424

2525

2626
function check_approval(){
27+
local echo_line="$1"
28+
shift
2729
person_num=`echo $@|awk '{for (i=2;i<=NF;i++)print $i}'`
2830
APPROVALS=`echo ${approval_line}|python ${FD_ROOT}/scripts/check_pr_approval.py $1 $person_num`
2931
if [[ "${APPROVALS}" == "FALSE" && "${echo_line}" != "" ]]; then
@@ -40,10 +42,12 @@ function add_failed(){
4042

4143
HAS_CUSTOM_REGISTRER=`git diff -U0 upstream/$BRANCH | grep '^\+' | grep -zoE "PD_BUILD_(STATIC_)?OP" || true`
4244
if [ ${HAS_CUSTOM_REGISTRER} ] && [ "${PR_ID}" != "" ]; then
43-
echo_line="You must have one FastDeploy RD (qingqing01(dangqingqing), Jiang-Jia-Jun(jiangjiajun), heavengate(dengkaipeng)) one QA(DDDivano(zhengtianyu)) one PaddlePaddle RD (XiaoguangHu01(huxiaoguang), jeff41404(gaoxiang), phlrain(liuhongyu)) approval for adding custom op.\n"
44-
check_approval 1 qingqing01, Jiang-Jia-Jun, heavengate
45-
check_approval 1 XiaoguangHu01 zhiqiu Xreki zhangbo9674 zyfncg phlrain
46-
check_approval 1 XiaoguangHu01, jeff41404, phlrain
45+
echo_line1="You must have one FastDeploy RD (qingqing01(dangqingqing), Jiang-Jia-Jun(jiangjiajun), heavengate(dengkaipeng)) approval for adding custom op.\n"
46+
echo_line2="You must have one QA(DDDivano(zhengtianyu)) approval for adding custom op.\n"
47+
echo_line3="You must have one PaddlePaddle RD (XiaoguangHu01(huxiaoguang), jeff41404(gaoxiang), phlrain(liuhongyu)) approval for adding custom op.\n"
48+
check_approval "$echo_line1" 1 qingqing01, Jiang-Jia-Jun, heavengate
49+
check_approval "$echo_line2" 1 DDDivano
50+
check_approval "$echo_line3" 1 XiaoguangHu01, jeff41404, phlrain
4751
fi
4852

4953

0 commit comments

Comments
 (0)