Skip to content

Commit 0fe3079

Browse files
author
Tomasz Patejko
committed
MKLDNN conv + elementwise_add fusion: fix for order of parameters in elementwise_add in resnet50
test=develop
1 parent b73b868 commit 0fe3079

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

paddle/fluid/framework/ir/conv_elementwise_add_mkldnn_fuse_pass_tester.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ TEST(ConvElementwiseAddMKLDNNFusePass, ConvolutionWithElementwiseAddRelu) {
109109
}
110110

111111
SetOp(&prog, "conv2d", {"a", "bias", "weights"}, {"b"});
112-
SetOp(&prog, "elementwise_add", {"c", "b"}, {"d"});
112+
SetOp(&prog, "elementwise_add", {"b", "c"}, {"d"});
113113
SetOp(&prog, "relu", {"d"}, {"e"});
114114

115115
return prog;
@@ -160,7 +160,7 @@ TEST(ConvElementwiseAddMKLDNNFusePass, ConvolutionElementwiseAdd) {
160160
}
161161

162162
SetOp(&prog, "conv2d", {"a", "bias", "weights"}, {"b"});
163-
SetOp(&prog, "elementwise_add", {"c", "b"}, {"d"});
163+
SetOp(&prog, "elementwise_add", {"b", "c"}, {"d"});
164164

165165
return prog;
166166
};
@@ -211,7 +211,7 @@ TEST(ConvElementwiseAddMKLDNNFusePass, SigmoidConvolutionAddElementwiseRelu) {
211211

212212
SetOp(&prog, "sigmoid", {"a"}, {"b"});
213213
SetOp(&prog, "conv2d", {"b", "bias", "weights"}, {"c"});
214-
SetOp(&prog, "elementwise_add", {"d", "c"}, {"e"});
214+
SetOp(&prog, "elementwise_add", {"c", "d"}, {"e"});
215215
SetOp(&prog, "relu", {"e"}, {"f"});
216216

217217
return prog;

paddle/fluid/framework/ir/graph_pattern_detector.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,15 +1024,15 @@ PDNode *patterns::Conv::operator()() {
10241024
return output_var;
10251025
}
10261026

1027-
PDNode *patterns::ElementwiseAdd::operator()(PDNode *y_var) {
1027+
PDNode *patterns::ElementwiseAdd::operator()(PDNode *x_var) {
10281028
auto elementwise_add_op = pattern->NewNode(elementwise_add_op_repr())
10291029
->assert_is_op("elementwise_add");
10301030

1031-
auto x_var = pattern->NewNode(elementwise_add_x_repr())
1032-
->AsInput()
1033-
->assert_is_op_input("elementwise_add", "X");
1031+
x_var->assert_is_op_input("elementwise_add", "X");
10341032

1035-
y_var->assert_is_op_input("elementwise_add", "Y");
1033+
auto y_var = pattern->NewNode(elementwise_add_x_repr())
1034+
->AsInput()
1035+
->assert_is_op_input("elementwise_add", "Y");
10361036

10371037
auto out_var = pattern->NewNode(elementwise_add_out_repr())
10381038
->AsOutput()

paddle/fluid/framework/ir/graph_pattern_detector.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ struct ElementwiseAdd : public PatternBase {
631631
ElementwiseAdd(PDPattern* pattern, const std::string& name_scope)
632632
: PatternBase(pattern, name_scope, "elementwise_add") {}
633633

634-
PDNode* operator()(PDNode* y_var);
634+
PDNode* operator()(PDNode* x_var);
635635

636636
PATTERN_DECL_NODE(elementwise_add_op);
637637
PATTERN_DECL_NODE(elementwise_add_x);

0 commit comments

Comments
 (0)