add (#13377)

gongweibao · web-flow · commit 3a3f28f99b87 · 2018-09-13T16:35:56.000+08:00
diff --git a/paddle/fluid/operators/distributed/grpc_client.cc b/paddle/fluid/operators/distributed/grpc_client.cc
@@ -290,12 +290,18 @@ void GRPCClient::Proceed() {
       c->Finish(false);
     }
 
-    delete c;
+    bool notify = false;
     {
       std::lock_guard<std::mutex> lk(sync_mutex_);
       req_count_--;
+      notify = (req_count_ <= 0 || !c->status_.ok());
+    }
+
+    delete c;
+
+    if (notify) {
+      sync_cond_.notify_all();
     }
-    sync_cond_.notify_all();
   }
   VLOG(3) << "GRPCClient Proceed end";
 }

Original file line number	Diff line number	Diff line change
`@@ -290,12 +290,18 @@ void GRPCClient::Proceed() {`
`290`	`290`	`c->Finish(false);`
`291`	`291`	`}`
`292`	`292`
`293`		`- delete c;`
	`293`	`+ bool notify = false;`
`294`	`294`	`{`
`295`	`295`	`std::lock_guard<std::mutex> lk(sync_mutex_);`
`296`	`296`	`req_count_--;`
	`297`	`+ notify = (req_count_ <= 0 \|\| !c->status_.ok());`
	`298`	`+ }`
	`299`	`+`
	`300`	`+ delete c;`
	`301`	`+`
	`302`	`+ if (notify) {`
	`303`	`+ sync_cond_.notify_all();`
`297`	`304`	`}`
`298`		`- sync_cond_.notify_all();`
`299`	`305`	`}`
`300`	`306`	`VLOG(3) << "GRPCClient Proceed end";`
`301`	`307`	`}`