Skip to content

Commit 3b46680

Browse files
committed
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into fix_squeeze_check
2 parents 6a5545a + da39a70 commit 3b46680

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

paddle/scripts/paddle_build.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,7 @@ function assert_api_spec_approvals() {
453453
echo "checking ${API_FILE} change, PR: ${GIT_PR_ID}, changes: ${API_CHANGE}"
454454
if [ ${API_CHANGE} ] && [ "${GIT_PR_ID}" != "" ]; then
455455
# NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
456+
# approval_user_list: velconia 1979255,panyx0718 2887803,XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,jacquesqiao 3048612,typhoonzero 13348433,shanyi15 35982308.
456457
if [ "$API_FILE" == "paddle/fluid/API.spec" ];then
457458
APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \
458459
python ${PADDLE_ROOT}/tools/check_pr_approval.py 2 2887803 35982308 46782768 30176695`
@@ -462,14 +463,14 @@ function assert_api_spec_approvals() {
462463
fi
463464
else
464465
APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \
465-
python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 2887803`
466+
python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 2887803 1979255 21351065 3048612 13348433 46782768 30176695 12538138 6836917 32832641`
466467
fi
467468
echo "current pr ${GIT_PR_ID} got approvals: ${APPROVALS}"
468469
if [ "${APPROVALS}" == "FALSE" ]; then
469470
if [ "$API_FILE" == "paddle/fluid/API.spec" ];then
470471
echo "You must have one RD (panyx0718 or chengduoZH or XiaoguangHu01) and one PM (shanyi15) approval for the api change! ${API_FILE}"
471472
else
472-
echo "You must have panyx0718 approval for the api change! ${API_FILE}"
473+
echo "You must have one RD (velconia,panyx0718,XiaoguangHu01,chengduoZH,Xreki,luotao1,sneaxiy,tensor-tang,jacquesqiao,typhoonzero) approval for the api change! ${API_FILE}"
473474
fi
474475
exit 1
475476
fi
@@ -479,10 +480,10 @@ function assert_api_spec_approvals() {
479480
HAS_CONST_CAST=`git diff -U0 upstream/$BRANCH |grep -o -m 1 "const_cast" || true`
480481
if [ ${HAS_CONST_CAST} ] && [ "${GIT_PR_ID}" != "" ]; then
481482
APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \
482-
python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 2887803`
483+
python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 2887803 1979255 21351065 3048612 13348433 46782768 30176695 12538138 6836917 32832641`
483484
echo "current pr ${GIT_PR_ID} got approvals: ${APPROVALS}"
484485
if [ "${APPROVALS}" == "FALSE" ]; then
485-
echo "You must have panyx0718 approval for the const_cast"
486+
echo "You must have one RD (velconia,panyx0718,XiaoguangHu01,chengduoZH,Xreki,luotao1,sneaxiy,tensor-tang,jacquesqiao,typhoonzero) approval for the api change! ${API_FILE}"
486487
exit 1
487488
fi
488489
fi

0 commit comments

Comments
 (0)