Skip to content

Commit 59c6653

Browse files
committed
add more logs and comments
test=develop
1 parent cb2d33a commit 59c6653

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

paddle/fluid/framework/details/op_handle_base.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ constexpr char kLocalExecScopeName[] = "@LCOAL_SCOPE@";
3131
// It's responsible for populating necessary fields of ir::Node.
3232
class OpHandleBase {
3333
public:
34+
// Owned by `node`. No need to be deleted explicitly.
3435
explicit OpHandleBase(ir::Node *node) : node_(node) {
3536
node_->WrappedBy(this);
3637
}

paddle/fluid/framework/details/var_handle.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,19 @@ namespace details {
2020

2121
VarHandleBase::~VarHandleBase() {}
2222

23+
VarHandle::~VarHandle() { VLOG(4) << "deleting var handle " << DebugString(); }
24+
2325
std::string VarHandle::DebugString() const {
2426
std::stringstream ss;
2527
ss << name_ << ":" << place_;
2628
return ss.str();
2729
}
2830

2931
std::string DummyVarHandle::DebugString() const { return node_->Name(); }
32+
33+
DummyVarHandle::~DummyVarHandle() {
34+
VLOG(4) << "deleting dummy var handle " << DebugString();
35+
}
3036
} // namespace details
3137
} // namespace framework
3238
} // namespace paddle

paddle/fluid/framework/details/var_handle.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ class OpHandleBase;
3535
// A variable can only be generated by a single operator. i.e.
3636
// This is a single assignment graph.
3737
struct VarHandleBase {
38+
// Owned by `node`. No need to be deleted explicitly.
3839
explicit VarHandleBase(ir::Node* node) : node_(node) {
3940
node_->WrappedBy(this);
4041
}
@@ -96,6 +97,8 @@ struct VarHandleBase {
9697
struct VarHandle : public VarHandleBase {
9798
explicit VarHandle(ir::Node* node) : VarHandleBase(node) {}
9899

100+
virtual ~VarHandle();
101+
99102
std::string DebugString() const override;
100103

101104
VarHandle(ir::Node* node, size_t version, size_t scope_index,
@@ -123,6 +126,8 @@ struct VarHandle : public VarHandleBase {
123126
struct DummyVarHandle : public VarHandleBase {
124127
explicit DummyVarHandle(ir::Node* node) : VarHandleBase(node) {}
125128

129+
virtual ~DummyVarHandle();
130+
126131
std::string DebugString() const override;
127132
};
128133

paddle/fluid/framework/ir/node.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ class Node {
4949
public:
5050
virtual ~Node() {
5151
if (!wrapper_.empty()) {
52+
VLOG(4) << "ir::Node deleting a wrapper node " << Name();
5253
wrapper_deleter_();
5354
}
5455
}

0 commit comments

Comments
 (0)