Skip to content

Commit 5daad16

Browse files
committed
polish
1 parent ff5a7b6 commit 5daad16

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

paddle/fluid/framework/details/var_handle.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ struct VarHandleBase {
5656

5757
void RemoveOutput(OpHandleBase* out, ir::Node* node) {
5858
pending_ops_.erase(out);
59-
std::remove(node_->outputs.begin(), node_->outputs.end(), node);
59+
node_->outputs.erase(
60+
std::remove(node_->outputs.begin(), node_->outputs.end(), node));
6061
}
6162

6263
void ClearGeneratedOp() {

paddle/fluid/framework/ir/graph.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ class Graph {
6464
return nodes.back().get();
6565
}
6666

67-
// TODO(paddle-dev): There shouldn't be kNone nodes in the ir::Graph.
68-
// node should either be a executable kOperation or a kVariable. kNone
69-
// node is a temporary solution.
7067
ir::Node* CreateEmptyNode(const std::string& name, ir::Node::Type type) {
7168
nodes.emplace_back(new ir::Node(name, type));
7269
return nodes.back().get();

0 commit comments

Comments
 (0)