Merge pull request #13788 from wanghaoshuang/cherry-pick-fix-normal

panyx0718 · web-flow · commit 717fba816f91 · 2018-10-10T11:25:23.000+08:00
Fix truncated normal.
diff --git a/paddle/fluid/operators/truncated_gaussian_random_op.cc b/paddle/fluid/operators/truncated_gaussian_random_op.cc
@@ -148,7 +148,7 @@ struct TruncatedNormal {
 
   T operator()(T value) const {
     auto p = a_normal_cdf + (b_normal_cdf - a_normal_cdf) * value;
-    return (std::sqrt(2.0) * Erfinv(2 * p - 1) + mean) * std;
+    return std::sqrt(2.0) * Erfinv(2 * p - 1) * std + mean;
   }
 };
 
diff --git a/paddle/fluid/operators/truncated_gaussian_random_op.cu b/paddle/fluid/operators/truncated_gaussian_random_op.cu
@@ -42,7 +42,7 @@ struct TruncatedNormal {
     rng.discard(n);
     T value = dist(rng);
     auto p = a_normal_cdf + (b_normal_cdf - a_normal_cdf) * value;
-    return (std::sqrt(2.0) * erfinvf(2 * p - 1) + mean) * std;
+    return std::sqrt(2.0) * erfinvf(2 * p - 1) * std + mean;
   }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ struct TruncatedNormal {`
`148`	`148`
`149`	`149`	`T operator()(T value) const {`
`150`	`150`	`auto p = a_normal_cdf + (b_normal_cdf - a_normal_cdf) * value;`
`151`		`- return (std::sqrt(2.0) * Erfinv(2 * p - 1) + mean) * std;`
	`151`	`+ return std::sqrt(2.0) * Erfinv(2 * p - 1) * std + mean;`
`152`	`152`	`}`
`153`	`153`	`};`
`154`	`154`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ struct TruncatedNormal {`
`42`	`42`	`rng.discard(n);`
`43`	`43`	`T value = dist(rng);`
`44`	`44`	`auto p = a_normal_cdf + (b_normal_cdf - a_normal_cdf) * value;`
`45`		`- return (std::sqrt(2.0) * erfinvf(2 * p - 1) + mean) * std;`
	`45`	`+ return std::sqrt(2.0) * erfinvf(2 * p - 1) * std + mean;`
`46`	`46`	`}`
`47`	`47`	`};`
`48`	`48`